From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09FD4C77B7C for ; Sat, 27 May 2023 10:37:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92DD0900003; Sat, 27 May 2023 06:37:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DEB26B0075; Sat, 27 May 2023 06:37:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A525900003; Sat, 27 May 2023 06:37:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 67FEB6B0074 for ; Sat, 27 May 2023 06:37:47 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3784F80223 for ; Sat, 27 May 2023 10:37:47 +0000 (UTC) X-FDA: 80835684174.21.C47DC13 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 7CA82160006 for ; Sat, 27 May 2023 10:37:45 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AfYWeDlo; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685183865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2vCZ6nV6Oz5VQlvq5z3F0gC5WNK9C59EZrmylNwFbqw=; b=ww9TQl3mHDAE+ZyHuA+JkLh3IzjHVryWsI7PgCRpGjxJYHdUG2NIcKW4oIJLjzi+8bNA3+ uj1gaiLjTzKPSLgYLTRuYnnSH4Dr9Kj5jRY6NBv6u7wCrstU9mcdVFEQPkLwZS+O9GdD4u j7maGi0nuDtuOz9eyvQPQ0wMw+85H1o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685183865; a=rsa-sha256; cv=none; b=acuJb65ve3jCVVj+xnL4VR4dtv2tFvbroBejXy6Su2Yy5tXbMCwmgmbvwleoMLHm+CV64N b1O6GkFslxfYTtIF8PhfiTKOgLqmEWRR0okSqNY75bLQ5ZiG13YWvk7GElQAPtwmBKzYY7 4lkgB+VYBkFl2iWoKs8uhhlaVwrfJg4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AfYWeDlo; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F09E61856; Sat, 27 May 2023 10:37:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A2DCC433EF; Sat, 27 May 2023 10:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685183864; bh=YlJmW59Ll9MCRkxVrjvQCYDI/5jdB08w1bLYrI2oHEg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AfYWeDloLV9dO/4sQS3YWekNp4H2v425dD4nZHCE/LMe1o+Sj5Ph/aNrCmG6SpRTy 6vt4BZoysxNPfbV3W+a9u4hDAjH2mI4ehYjJkXiqEJiOQWsE/VQxZvqSQ7TDmTX5mA YeDTwO3pbM2gxGINOzzpwa/zzRv53TpoJPyyPfVHjjfhU8R4IniomyLHgWMKLUul+p a+XD1YiBsrv0lW21CFBbvkKtcPMvPt2PMz1i98oKjZzjIpUc9PYHQIXB07SDWla04s DGxIgDkXMkeHWi29xXHz0LGTDldK2/dWXJppDHrVCiYu5WBv6HgGFFCZiYx3GHjQct IkdpcL5r2G/7w== Date: Sat, 27 May 2023 13:37:22 +0300 From: Mike Rapoport To: Yuwei Guan Cc: akpm@linux-foundation.org, tsahu@linux.ibm.com, anshuman.khandual@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] memblock: Add flags and nid info in memblock debugfs Message-ID: <20230527103722.GG4967@kernel.org> References: <20230519105321.333-1-ssawgyw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230519105321.333-1-ssawgyw@gmail.com> X-Rspamd-Queue-Id: 7CA82160006 X-Rspam-User: X-Stat-Signature: eb97qbzzzxh1wumk4bxk9gqdxnyppx5r X-Rspamd-Server: rspam03 X-HE-Tag: 1685183865-75250 X-HE-Meta: U2FsdGVkX1+YdRRFWeEj3dEhwIiZ8o+14V57o4WeRPaqVZ9DrUqgrTk4yjcTakBT7pdGgIy0gQpChpeZCLdJd394pPsKScCYXSfOdJW1fQF9eSLi1D2ufvu15j5Hg/d4W8l7aUKITG+T0OGhTYQt/JwwYJHKjr8gvf0FbLWjjV0IkKF57qYBg4HpuLQiHA8elpgN0+6SlY0rkOYcVqIfHNaVnKiJ3UAerPtzdiMHaEwQRI3E29FYm5JiMGCeVJxPMz33tMJUCP8hxEIJLZ6iuv9C0NxeOIynBWMeaCPNTjM6aIcB2aWRHW2sXJrb9QBkSMA+fvC+sRb3MQK7Y08+/SCMKyrIaFWO9hr1CNvg9fryZvYp5crnlwA7HVc9YGE1hw7KvFypHojbdlroBNNcH2cruVpbhv71XRQYx96zOCO9bZfYWld2mAHjf1iyqn8NuWPTRP1TBN2hBqbmsnJh5VHJxj5AK9BN8Ea48uZR7FipnJ6Rt/MFl4mZq5pLbtviENlfvWR3+mjaiUvLzp3yCeQEEitRi673H9gA3R6h8fXh76un4bok0wolyiShkPBTq4A1yFDEYe0h6UTlXmzJGAZYF5vm/JCJb0BbF0muenl+8DlJhTP4bdowgkvNhmI6Azs2Ab7hcnpn86aKUQvdUniTUENENx3TO+vT1watsBnQLmXqc5UVjs72fVYWuEJOzGDR82Ycfe872nO+kFFZvhkM2NS2p9NSOR7psT+BMK97ve8kjobcGMZA54BQUPPkkcSJkSvbqoSDgRlI9b1czm0hJ1/+hALQpeCjKOE4ykvjz3bkrnigdWnCWpzPV2D5xfYc2UgsW/kXw/KwLCgktXjlNVKNiXlI58T9QcUKPW9A7alJOoiF8LkYk+7Iyn1KxKuxSmeZgsvqObhK+nPYVIB9t438KllPLGF5QqFqI07LpcVKSpBAkatnIIcZnQH0oaEviKYw9Q6mGqdQUBj +769rnYb t4/CjGD2BrpSYxFU4vTE4j4DkXtaQzQ6fkvluMF1wuQ5aP27/gxbxknZoKaEWdoPv63YydHH7XPiV8r77VaXGSUwc/tHdTDsoV6tF0iMkeiCElssJyVv/ErNQ3J5mMCNo8H5l0Ofas9KdAuHYMFZQy38IRICApQ9Jt0N8jV6qVYaGtLz+sgQlAe50A+QtVj+Sun981bNGwQnBTZlYLHaU7v8pHZ/768f7XrSne9pSGzp8ZFrBFK6MYpffyk7FaLeXc8/l/CxojPaGxJLb9sCsYAe/ysZxVCr5lS3gVWp9ZTbeke3VGPRjxDOvfw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yuwei, On Fri, May 19, 2023 at 06:53:21PM +0800, Yuwei Guan wrote: > Currently, the memblock debugfs can display the count of memblock_type and > the base and end of the reg. However, when memblock_mark_*() or > memblock_set_node() is executed on some range, the information in the > existing debugfs cannot make it clear why the address is not consecutive. > > For example, > cat /sys/kernel/debug/memblock/memory > 0: 0x0000000080000000..0x00000000901fffff > 1: 0x0000000090200000..0x00000000905fffff > 2: 0x0000000090600000..0x0000000092ffffff > 3: 0x0000000093000000..0x00000000973fffff > 4: 0x0000000097400000..0x00000000b71fffff > 5: 0x00000000c0000000..0x00000000dfffffff > 6: 0x00000000e2500000..0x00000000f87fffff > 7: 0x00000000f8800000..0x00000000fa7fffff > 8: 0x00000000fa800000..0x00000000fd3effff > 9: 0x00000000fd3f0000..0x00000000fd3fefff > 10: 0x00000000fd3ff000..0x00000000fd7fffff > 11: 0x00000000fd800000..0x00000000fd901fff > 12: 0x00000000fd902000..0x00000000fd909fff > 13: 0x00000000fd90a000..0x00000000fd90bfff > 14: 0x00000000fd90c000..0x00000000ffffffff > 15: 0x0000000880000000..0x0000000affffffff > > So we can add flags and nid to this debugfs. > > For example, > cat /sys/kernel/debug/memblock/memory > 0: 0x0000000080000000..0x00000000901fffff 0 NONE > 1: 0x0000000090200000..0x00000000905fffff 0 NOMAP > 2: 0x0000000090600000..0x0000000092ffffff 0 NONE > 3: 0x0000000093000000..0x00000000973fffff 0 NOMAP > 4: 0x0000000097400000..0x00000000b71fffff 0 NONE > 5: 0x00000000c0000000..0x00000000dfffffff 0 NONE > 6: 0x00000000e2500000..0x00000000f87fffff 0 NONE > 7: 0x00000000f8800000..0x00000000fa7fffff 0 NOMAP > 8: 0x00000000fa800000..0x00000000fd3effff 0 NONE > 9: 0x00000000fd3f0000..0x00000000fd3fefff 0 NOMAP > 10: 0x00000000fd3ff000..0x00000000fd7fffff 0 NONE > 11: 0x00000000fd800000..0x00000000fd901fff 0 NOMAP > 12: 0x00000000fd902000..0x00000000fd909fff 0 NONE > 13: 0x00000000fd90a000..0x00000000fd90bfff 0 NOMAP > 14: 0x00000000fd90c000..0x00000000ffffffff 0 NONE > 15: 0x0000000880000000..0x0000000affffffff 0 NONE > > Signed-off-by: Yuwei Guan > --- > v4: > - show string value for each memblock flag > --- > mm/memblock.c | 24 ++++++++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 511d4783dcf1..10d0ddbeebc1 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2136,12 +2136,19 @@ void __init memblock_free_all(void) > } > > #if defined(CONFIG_DEBUG_FS) && defined(CONFIG_ARCH_KEEP_MEMBLOCK) > +static const char * const flagname[] = { > + [ilog2(MEMBLOCK_HOTPLUG)] = "HOTPLUG", > + [ilog2(MEMBLOCK_MIRROR)] = "MIRROR", > + [ilog2(MEMBLOCK_NOMAP)] = "NOMAP", > + [ilog2(MEMBLOCK_DRIVER_MANAGED)] = "DRV_MNG", > +}; > > static int memblock_debug_show(struct seq_file *m, void *private) > { > struct memblock_type *type = m->private; > struct memblock_region *reg; > - int i; > + int i, j; > + unsigned int count = ARRAY_SIZE(flagname); > phys_addr_t end; > > for (i = 0; i < type->cnt; i++) { > @@ -2149,7 +2156,20 @@ static int memblock_debug_show(struct seq_file *m, void *private) > end = reg->base + reg->size - 1; > > seq_printf(m, "%4d: ", i); > - seq_printf(m, "%pa..%pa\n", ®->base, &end); > + seq_printf(m, "%pa..%pa ", ®->base, &end); > + seq_printf(m, "%4d ", memblock_get_region_node(reg)); As Kefeng mentioned, the node id for reserved regions will be wrong, so this needs to be updated so that when reg->nid == MAX_NUMNODES we'll print e.g. 'x'. > + if (reg->flags) { > + for (j = 0; j < count; j++) { > + if (reg->flags & (1U << j)) { > + seq_printf(m, "%s\n", flagname[j]); > + break; > + } > + } > + if (j == count) > + seq_printf(m, "%s\n", "UNKNOWN"); > + } else { > + seq_printf(m, "%s\n", "NONE"); > + } > } > return 0; > } > -- > 2.34.1 > -- Sincerely yours, Mike.