From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D210C77B7E for ; Sat, 27 May 2023 08:00:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7B506B0072; Sat, 27 May 2023 04:00:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2B726B0074; Sat, 27 May 2023 04:00:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91AD8900003; Sat, 27 May 2023 04:00:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 82CD66B0072 for ; Sat, 27 May 2023 04:00:38 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 40A588017D for ; Sat, 27 May 2023 08:00:38 +0000 (UTC) X-FDA: 80835288156.15.3BA4249 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 55A461A0028 for ; Sat, 27 May 2023 08:00:36 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rrCI02dr; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685174436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FoQTyR18fbPj030xWgxcsdalbjLS32AeQlt/m/XBANQ=; b=cufqcQVHnTFKaVsz5bXQ81yjwp92Wl+xOi3htPFy9xWAD9J7fEJfdjIH4lg4KC/wYO82ba tqEoubYXwBRibwgzltzATbHmKdtB93Cg4moJGjcYc5RVchaZpDR6t/DMP7xrMQT527c8E+ 2xbOp/IpV2gxnmCHUc1QqpB3ILunryY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rrCI02dr; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685174436; a=rsa-sha256; cv=none; b=GKOAkXiSNbIRZbj/2znhPZmOQ7UYlodVJ8FzdF4NuzBqNboAtChVvbGIVJjytuv2d9lgjp VgbVbH0S9GZexxe40z0BrEqUln1zPe/o4iQcCqqo2JLvumvBmFa07TtU/wbie+B9ml+C9q GvigbllZ5mUGW/quhrilYIFWcT1BvGQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8753960AC2; Sat, 27 May 2023 08:00:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE395C433D2; Sat, 27 May 2023 08:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685174434; bh=1IJdM/Bry22ESZ9un0C7ZvpkLJqgF412vz9PcaQjdIg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rrCI02dryYG9OHO3mYKo2BBgLeIlw+ElNUV0aH9Wdc/NH2b+J5QIdIGXJexUS5sNW +JMj5YGpSOLFP+yOoBAso0dUSDDFSrfOQOPGYZruEwUHLV/pAizUbs/n5SPx+1rEZ7 +YEHSd4tlKNmlGsRfmPCj5ufH3dYpSVv9RMIAyb6+72bpvhbqnTyhVL6KrMAv8Db2Y S7mgF2AbAwDtFYfIFZhvuyNK5skvr+CzUwRFmqibpVRT8xjAbjiQD9fQC7zv6IFBsP 6tQxC0qR+rp7FUB99VtQTeh5YSkQcxAPWYVd9NElX3tcssMp7qesq1X2cCaKu0EBlC K+W/iSib06T8A== Date: Sat, 27 May 2023 11:00:14 +0300 From: Mike Rapoport To: Haifeng Xu Cc: akpm@linux-foundation.org, mhocko@suse.com, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] mm/mm_init.c: do not calculate zone_start_pfn/zone_end_pfn in zone_absent_pages_in_node() Message-ID: <20230527080014.GD4967@kernel.org> References: <20230526085251.1977-2-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230526085251.1977-2-haifeng.xu@shopee.com> X-Rspamd-Queue-Id: 55A461A0028 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: fdwpuq4kfnab8qthbu9cm4i7n7hg1i8z X-HE-Tag: 1685174436-27781 X-HE-Meta: U2FsdGVkX1/EbB8KZ7G3rxNiecS3LFrTUtftJqITdWLjisv/KIGh+KUDjR9zWE57Sie09gve8Y/mXFVuX7fuqWg1SNG4NlLRD+QQPFIPC9uCbskvVhpYlBxjKDMA1Q2YTa0RXu7Z8xBJxqnElr6L/gMO7+MKlBSNm9McY495zpcZj6JybSgXvWnbvAh6ifB8cM+nxVWY8bFA7uIp5xFSZqlRgadWNpL1fTJlSMm1I4DU7gmP95RAObffNK/h2U9grVAnHYNjcy5UE0VyDISdgqVlbD7Yrs2IIQSajVQJmFtD31doOTR1q5AGKehCFFqS6dFKQoN0PXqnQOZ9wCbdm7AqXV8+acGX90mwvpHWNX3djZ/Bvxp8s67EZIGdCZOv5zag6W0RPjXZA3Oe26vOqwZw11mvVgtgDsKVMRi2CudTAFho7Ljts44Sahi7SQFlc2abTSamVVMwM7akqiP7462WgGoY+d4pttPCv/kxPdoEbAoj5QfK2eERtK7CGkaY0Zk9hDHQSLUxnxea7ZNC2mmhlGLd3Fz/mYQ+ZPd3GiBVv//CojoZctdaYHDngN8KubPyqHkPjUN64xOvdG+szI+gRu89ISUAhn5ruwUkAkBerIQ+XWkisOLoFTfpUgzXshfy7SPByGmx6UoPXXY0my4qGWmRZoQazo/3OoBiWW2L5UPrfc3sY5gSxhhsinIX1UHM06Ayy/gl8Hcwy+E9ok33HP3rFYT5C76WtLVKEoHzBvD83CTAa+ae60LpYf+XNIScIpgFo+YgHCofZMk0Zsc9qu+JXlqiR4LDVqFm92071hA8lgXyRRfIfslH+k2HinmAfovyNDu63OoGR/6aa4GCwzXimJQg9fJj3j3zAZMNbyXlelCanzK1QOZrCeXQkcDEAFSdDGXcD3+CnaMLKmkazjmuJ4WkDZW+lSBgpU1bfsvniftOXDxtCUj5MOIHmE7mxbkV+6HLtw4TZDL 8nbIDEuq 7mvmcTN3qYjz8dtHUss/hJQqWj88m1LD1OoO88ExlISeqrVtOgUszOmNjYVbqOSIdAqmvmJDsRCLvIBcbYAzzfNI32f8UfQCoSc3u6V61Oh3FTOPr99XG8Ia/sELwNdhlWKBmww7ci318UV9SZTLQ/gvmFMAaZVfOQtcIVjzhkgKWcEBywml3JvNGlZTbxyD6BaHViZ5IrUVUa5+spA8zZFLJr1b4ctWQ9upx9Nd2nUM5lRk0HTfhiG7+ClX83WW/rou0a504DcAlhhlAiE1S0b/Hs5x6V3neyfF5RGEJT3smXNIWB+AalsWc3RV4F+SXJ9eXsOjzOgWx/5SuCTW9EX9IwXtSQzJtQQHXQsGnkoxra67d2Ju4JwPTmBmaFsz/X9iThSCX0Jjeah7eXegMYWPQ003ihDQrzpfNN/IiSdwPN7+xbeqPiB2iVHMvPePALt+PXbkg6GeBwd4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 26, 2023 at 08:52:51AM +0000, Haifeng Xu wrote: > In calculate_node_totalpages(), zone_start_pfn/zone_end_pfn are already > calculated in zone_spanned_pages_in_node(), so use them as parameters > instead of node_start_pfn/node_end_pfn and the duplicated calculation > process can de dropped. > > Signed-off-by: Haifeng Xu > Suggested-by: Mike Rapoport Reviewed-by: Mike Rapoport (IBM) > --- > v2: > - remove unrelated whitespace changes > - do not replace pgdat->node_id with a local > variable > - remove redundant variable 'size' > - add check that whether a zone is empty or not > --- > mm/mm_init.c | 30 ++++++++++++------------------ > 1 file changed, 12 insertions(+), 18 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index f674e5798f7d..2d91bb52c619 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1166,20 +1166,15 @@ unsigned long __init absent_pages_in_range(unsigned long start_pfn, > /* Return the number of page frames in holes in a zone on a node */ > static unsigned long __init zone_absent_pages_in_node(int nid, > unsigned long zone_type, > - unsigned long node_start_pfn, > - unsigned long node_end_pfn) > + unsigned long zone_start_pfn, > + unsigned long zone_end_pfn) > { > - unsigned long zone_low = arch_zone_lowest_possible_pfn[zone_type]; > - unsigned long zone_high = arch_zone_highest_possible_pfn[zone_type]; > - unsigned long zone_start_pfn, zone_end_pfn; > unsigned long nr_absent; > > - zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high); > - zone_end_pfn = clamp(node_end_pfn, zone_low, zone_high); > + /* zone is empty, we don't have any absent pages */ > + if (zone_start_pfn == zone_end_pfn) > + return 0; > > - adjust_zone_range_for_zone_movable(nid, zone_type, > - node_start_pfn, node_end_pfn, > - &zone_start_pfn, &zone_end_pfn); > nr_absent = __absent_pages_in_range(nid, zone_start_pfn, zone_end_pfn); > > /* > @@ -1272,7 +1267,7 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat, > struct zone *zone = pgdat->node_zones + i; > unsigned long zone_start_pfn, zone_end_pfn; > unsigned long spanned, absent; > - unsigned long size, real_size; > + unsigned long real_size; > > spanned = zone_spanned_pages_in_node(pgdat->node_id, i, > node_start_pfn, > @@ -1280,23 +1275,22 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat, > &zone_start_pfn, > &zone_end_pfn); > absent = zone_absent_pages_in_node(pgdat->node_id, i, > - node_start_pfn, > - node_end_pfn); > + zone_start_pfn, > + zone_end_pfn); > > - size = spanned; > - real_size = size - absent; > + real_size = spanned - absent; > > - if (size) > + if (spanned) > zone->zone_start_pfn = zone_start_pfn; > else > zone->zone_start_pfn = 0; > - zone->spanned_pages = size; > + zone->spanned_pages = spanned; > zone->present_pages = real_size; > #if defined(CONFIG_MEMORY_HOTPLUG) > zone->present_early_pages = real_size; > #endif > > - totalpages += size; > + totalpages += spanned; > realtotalpages += real_size; > } > > -- > 2.25.1 > -- Sincerely yours, Mike.