From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E7CAC77B7E for ; Sat, 27 May 2023 07:57:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30380900002; Sat, 27 May 2023 03:57:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B3B66B0072; Sat, 27 May 2023 03:57:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17A8E900002; Sat, 27 May 2023 03:57:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 077386B0071 for ; Sat, 27 May 2023 03:57:33 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8C958120181 for ; Sat, 27 May 2023 07:57:32 +0000 (UTC) X-FDA: 80835280344.10.E93914E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id B3EE6C000B for ; Sat, 27 May 2023 07:57:30 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cZUSTqgK; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685174250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b98808muFBDJ5CCgbmVQ0LNxUw6dWRrG8Hqa7s6lts4=; b=7EWktFD+7CBrtvAojGu/678yQIpgtQ5uN1jw9Ejf+DpBFAzmz82wKPy79ultpLDfcZzw3F RPeLNytCPycDczylAGSQhopcyBliwwAejqbTTvU6AzH59DMJGmsIV+nSqTHoq6VaSojlDq dgiKvpoRrgvpjdbRQqfDU6MQGAied0o= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cZUSTqgK; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685174250; a=rsa-sha256; cv=none; b=VyNqkypSh2Z6V84pZ6qHP/0NIBJFY8I1bysmPZfXf9f4lWZ6TW+7+Kw0R8MKNfIt6mv3BT 7YXbvGMRsL8w5TDNXxK/jDYeF4oApX94m0O2k2ydYkYr8PBymMnyYaeRX9Vdnhf9g34vII 964Eb+09JZQBn6IKBDNkbdx/1s3BHe8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A3736612BC; Sat, 27 May 2023 07:57:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6085C433EF; Sat, 27 May 2023 07:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685174249; bh=QVGsdUWRa7+6zdomEtsHcXdZSbuGegR+5TFaLMUQvEk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cZUSTqgKkqifSGE1El9TcNeSYuoe5dbA/eaBUZUkYlUC7So1rdOvNFCGUpVMJss31 DJSG/W4JlcPrciNeL7QHFYuSFfdzefd3+DUT5bkVTiJS6T0YEHLpisOjLp/n8xKxy9 GXF0WDNcVXePYT9ESOF/GKYFrixzwf2kc+KlqVNQblT4a31F2sAc/VutdMsk7PzqBH wdpy18cZJnCoGMvbScyO9HxvQ/4m3+mBBh9JC4551BM3wePdSfHcuyPiZWSC7+KKaK +a1/lzhwqFTlEKn2eIW0zxOutsm8pY5ZwsGyU3YyHdo82wHrKCgxzFDBbuNU4gr7bA XgtB7Kw97pd+Q== Date: Sat, 27 May 2023 10:57:07 +0300 From: Mike Rapoport To: Haifeng Xu Cc: akpm@linux-foundation.org, mhocko@suse.com, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/mm_init.c: introduce reset_memoryless_node_totalpages() Message-ID: <20230527075707.GC4967@kernel.org> References: <20230526085251.1977-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230526085251.1977-1-haifeng.xu@shopee.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B3EE6C000B X-Stat-Signature: gf46un7hxhece5w1cf5mw1ykhbzzyrjp X-Rspam-User: X-HE-Tag: 1685174250-54876 X-HE-Meta: U2FsdGVkX18vGESvrOX/lX1LJST6zgpKP21AI1syKH1zEFlvCPpcZgun2lirL0qBY7sfW15yCrUCsDAWkNRhY3/Dsef6YCFR7K8swMlo4OhiaiLls3VTWW6Fyf4SnfOiK4ECWRc5gF+sKc0WhQ0LJsJit4EB2wY4JYrWpldLw8sK2pcra147qZ9Kl7p1ryi8n08ULo1dWcJ5knbzCyN2EC6Ci8OZi3PQeTbtosjJ8F5cI8MGTXkIQWLyjO0h0tjwT2T/W4IWWgE2a0G74VewJey/+IGwDxDKnkeTGm0NrUD1KExqraWvcfO0cPdKcfk5DcjgbbwSpbQNebkyfM3922ZsY1k3Rat/QpTfhZnHGgd5BBIfdBgcIDwSjDwOvZL2MoDqMWZ2nTeAsSsoE0LtMIpYuvR3rCde7rBW6dh9LK6tQewnW3fpS1KMsjV58nCg5sd4UAVIiiShDLt+roKuRafvL1YGTMDWZl1LDVDoIzWzb9bK3QfZqSe/QXsaRq7CpTuZS8QH7viQUitz0AhdZ5ZyphMuOMGgu2IT3Iu9m4pctNUzGugMNK+KtLvn7zWNfbn7cP2WXFULLiiWjxLTpBjYVVxQfpVYJfOaa1gOxk4E6no7/ZCyJhG4CGcKKbe4oWbXn5iMdl72nBMM7JdcDtr/CoVeT9obwuqeVzCwW849La45FyPmxAjiY4xsmjl+AVnA8bXGYRgjZjKGAewRB2BB8qrrrm3CTyuV9/fK7xPkCfUayt6eIg5kRX9dQfY3929BNpBXmLMX3XBrrlCnc7D0pkv45UzpG1vOXRW6QCbBc6tClbTZ06NLHxhjXjFd/wZL0DpIwVVUKlbdoBY61vVuSOBLX7jOZ1HAZoQtz3ZK4IqndJkgKNtBqbKqy30D50cOSterAyQ/cIA8x5fmWWdBQVmr7+P8FRgKIX06kCbLmutfRZ1GflHzD9mGJiaAqsJsqhzfoins/WDrkyA zN1ANr3V C2aAtVIQSes9oEtHaa56/82CuGp1vhgoKgy01PL+NtHR98D8+1HJWa9YONxfi5coVDG4DnxbYME2nrW1pyiY1Bl8KuLGZ/YnChkt/BQvC5LuLPUxfYgek7OwWmnuo2p2N8GPb4IDxV6+kcR/L+X6mGHuFOm8yAt6u4DI5EQeIcSB6h4OsrgOTXuKDVTq5cZgGXyB2ck1sejmfUABzHUdJ06w4N16Vx3fEY8AnxouMHUaraa7R2Tc7Ju19W+ZdIZYBnD/zBONoKqftmnwPjcYso89Xp0BuxwjekaYZatsxEcG5XH5wIQp3kbrF5ydPzOH/PjjGdskc5vVMpNfrg490ks2pY7/iBIO6+OucipywvnzMHG4xLzCqIqcKwSFYs55MTiY9g7vt4n3S7ztG9hZgSVVOCekxbM1ubWOuEMXV5DKYHn4sRO3wr4OlCW2XocHy+1SEmJFdnH2ptq8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 26, 2023 at 08:52:50AM +0000, Haifeng Xu wrote: > Currently, no matter whether a node actually has memory or not, > calculate_node_totalpages() is used to account number of pages > in zone/node. However, for node without memory, these unnecessary > calculations can be skipped. All the zone/node page counts can be > set to 0 directly. So introduce reset_memoryless_node_totalpages() > to perform this action. > > Furthermore, calculate_node_totalpages() only gets called for the > node with memory. > > Signed-off-by: Haifeng Xu > Suggested-by: Mike Rapoport Reviewed-by: Mike Rapoport (IBM) > --- > v2: > - drop patch 2 in v1 > - inroduce new function reset_memoryless_node_totalpages() > - call calculate_node_totalpages only if node actually has > memory > --- > mm/mm_init.c | 31 ++++++++++++++++++++++--------- > 1 file changed, 22 insertions(+), 9 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 7f7f9c677854..f674e5798f7d 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1174,10 +1174,6 @@ static unsigned long __init zone_absent_pages_in_node(int nid, > unsigned long zone_start_pfn, zone_end_pfn; > unsigned long nr_absent; > > - /* When hotadd a new node from cpu_up(), the node should be empty */ > - if (!node_start_pfn && !node_end_pfn) > - return 0; > - > zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high); > zone_end_pfn = clamp(node_end_pfn, zone_low, zone_high); > > @@ -1227,9 +1223,6 @@ static unsigned long __init zone_spanned_pages_in_node(int nid, > { > unsigned long zone_low = arch_zone_lowest_possible_pfn[zone_type]; > unsigned long zone_high = arch_zone_highest_possible_pfn[zone_type]; > - /* When hotadd a new node from cpu_up(), the node should be empty */ > - if (!node_start_pfn && !node_end_pfn) > - return 0; > > /* Get the start and end of the zone */ > *zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high); > @@ -1250,6 +1243,24 @@ static unsigned long __init zone_spanned_pages_in_node(int nid, > return *zone_end_pfn - *zone_start_pfn; > } > > +static void __init reset_memoryless_node_totalpages(struct pglist_data *pgdat) > +{ > + struct zone *z; > + > + for (z = pgdat->node_zones; z < pgdat->node_zones + MAX_NR_ZONES; z++) { > + z->zone_start_pfn = 0; > + z->spanned_pages = 0; > + z->present_pages = 0; > +#if defined(CONFIG_MEMORY_HOTPLUG) > + z->present_early_pages = 0; > +#endif > + } > + > + pgdat->node_spanned_pages = 0; > + pgdat->node_present_pages = 0; > + pr_debug("On node %d totalpages: 0\n", pgdat->node_id); > +} > + > static void __init calculate_node_totalpages(struct pglist_data *pgdat, > unsigned long node_start_pfn, > unsigned long node_end_pfn) > @@ -1702,11 +1713,13 @@ static void __init free_area_init_node(int nid) > pr_info("Initmem setup node %d [mem %#018Lx-%#018Lx]\n", nid, > (u64)start_pfn << PAGE_SHIFT, > end_pfn ? ((u64)end_pfn << PAGE_SHIFT) - 1 : 0); > + > + calculate_node_totalpages(pgdat, start_pfn, end_pfn); > } else { > pr_info("Initmem setup node %d as memoryless\n", nid); > - } > > - calculate_node_totalpages(pgdat, start_pfn, end_pfn); > + reset_memoryless_node_totalpages(pgdat); > + } > > alloc_node_mem_map(pgdat); > pgdat_set_deferred_range(pgdat); > -- > 2.25.1 > -- Sincerely yours, Mike.