From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5DE1C77B73 for ; Sat, 27 May 2023 02:32:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43CF5900003; Fri, 26 May 2023 22:32:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ECE9900002; Fri, 26 May 2023 22:32:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B416900003; Fri, 26 May 2023 22:32:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 18863900002 for ; Fri, 26 May 2023 22:32:09 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DFFC412104A for ; Sat, 27 May 2023 02:32:08 +0000 (UTC) X-FDA: 80834460336.20.F3189AD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 5EF3C1C0003 for ; Sat, 27 May 2023 02:32:07 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Fi9HR5yO; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685154727; a=rsa-sha256; cv=none; b=be73koM+lK7woj/p5ER1G+0Svjac3f1/8nR2BvC+IztbPO78maOC6euWm6RBMGm7ZRXT2y F94AG6XK2G4pkwt8xgniewk/6WumI0LUUoajiZkH5fT3QQ8VU/jQCt2DFK2oIDq0rwwagw IuFjfevTXKyLNf1o5tAskQc3yybCwYg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Fi9HR5yO; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685154727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to:references:dkim-signature; bh=C57haIPYbUJyEcAG+GurftuNFyiqW7lHVHFo5MNwFkk=; b=zi1u71PU/Xeho0lusB1be7LnR3RHb+PUqr1t8XY/ECF37yQvJ+fGKulrB3LdmuC4P6ogLz btbSJhEx6LPLP2IqIjkJlpIryg7MIpdA0WW4NUASsMLgm9460g26gHX4qK96rKcYOCpLQH iJYZ0VZVwxbMg8aNZ8MZeEJ/Uo394iM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7A84D61485; Sat, 27 May 2023 02:32:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88C59C433EF; Sat, 27 May 2023 02:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685154725; bh=6yooBvheHKI+vBto37tEhoVjPjXcHeAsQbQFuaxF9SI=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=Fi9HR5yOl26i1ImnXJq9YKMVKdwvNf8PKMJr/PTv24loJtVvdccwm1pP7BlgztHcc skmqnJbpUTUBTX8aZKpcguYHBaiVLCkmXgKV4iXR8mrqnyJ8lG2vtoKUr1/dBe9hJk RQE5NwYRG7uNO+r56Sb915yyysh08ZEwnJlcBCrYV38zZ8REA6sPBy8tC90K0aTQLg J6mY39awDIlELoYkwX5M2Y1sRGhIfxac8cBGpBA5O+H/G9YIOaE3ijfX4/bfUm6Qas h2PoWDGfCQtvwwZrxVVY5GhP2btwVt/kaz+L2diWB/pS+i/KnqFGmBMdoTCoIEgsOb m0vgScZ8gQwpQ== From: SeongJae Park To: Kefeng Wang Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, syzbot+841a46899768ec7bec67@syzkaller.appspotmail.com Subject: Re: [PATCH] mm/damon/core: fix divide error in damon_nr_accesses_to_accesses_bp() Date: Fri, 26 May 2023 19:31:49 -0700 Message-Id: <20230527023149.8441-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230527023330.23535-1-wangkefeng.wang@huawei.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5EF3C1C0003 X-Stat-Signature: uakqmknruth1ad1wy3wpghs4shf78n6p X-Rspam-User: X-HE-Tag: 1685154727-548330 X-HE-Meta: U2FsdGVkX19HMczNJ9q+lra2TIL3x+cucXhVfivYmWaY/wwOUmvSEDtUN5UvwLRSyeO8XOOWVRr/P4WLuBZuvJzDC0AsJMQ1zD6hm03fT19s53KyOXv/VjEf+8rNjJL8c5/X6LBrecQ42rFZYbGoK42PhRVKVnrnyJknf0WjCK+L7u30BgwPfiEUULlf8q3V4H8bnmyF+ZVbylBo+xCJzY2guvWFp7XZFW41yYoH2b1SpK9Ui0q800EONUkoIKq0ZLgsMhcmYPSFFOxRtT/+JirxH4qldSZzyMvd2GSUNa9ua7XbnisWSu7vHf51K75Oxb0eA86gblRQXXM3mdAE5WjISKeedOroPw7944zKMtU0aXIGmo5VyNlnngJPYXFagMy774ovJ9t24HC2LT1gVA66bGpOvW2y5TiPfmKG/qpp0r9OdgpvAG0jlQRcn1NnS204ISC0IcD8DPn4XNsVg1VQsxYs3mn3+UzN4Yd1/SI6fO/xZSu53NpqHMIana1B4tAFVx/R5HyjZI3PgBgldFmyXTAGcWmKYkAaW+FXMFA4bj5eXO7nIIONNpucFfwmlAjuKU1VBZVqsC2FQr9tc+jSfFkVwltnXdRBHckhZNJP0zZU4d9VXGLCpwVwqUBRlz7Jnk1WjHk7TLWBvDP7DQAe0yOXdH0LqOhgLMSHZQ5uhBivLM3ErlbXUAApQdlcLxJDda9FH6kawA2OLpTdqpL5qTu4d7OTkIKOnDOYX/XqrWgVOytXhzaT+EZAcRDlVkGUh936h/4DU1DD+9MGs1Ekc3T+u3oWHXj5HQrSiy0QM03HFoOV8xneQ9lUB1KFW1LE8BwqMlED2EiTjiYWbE/uAJ8SLFGco7q0CzOxNAvhP6WyhKl3mMBoFJ6PgQxyfC8rs50X4p8JvSiZJQDPlLMsDydQNMEC6RNvUWk69cni5rEB7TBl89e7o0NkL8Wt8wllQ8DZJXFy74FxcMY fVw7nz6U sVOFm123phlolmH0pxDCDNXoUtqA9lX/VPm+FIzTO2Zq+oqNDt50RBggQo5mPACG3wfu4fAxPsjrhGU72/6L5L5oX9jA3UdyFzQPrirGWg0e5lT03oc5HvOwZoHq9SXwKwLC6leRSt1ry2/DKs3sWt1h+lkiUmd8YSmVQaDBNbIS8wuVci46fDDZ3t0qEjsz6AeYZ1caT8gkXE8KGoJdQhZZ146PXU5SX6BswVQ5QinMr/JpR1/BYeQ9WPc8vniaOg1yVSPr/XhO5cpQvbtqZNRDMoSjoz2GIxp1NLx+xQpV5fGY4bsGhO0RHKlD4ADyHmVsu4BfwTn526KUpsqrAiOt9tgEslw28rYT6TbEK6EEuYiKX07a1SIhH2UU7PBY4orHZFIXHcV9EoehrGZf3WP4HGsQ1vncTqjXUy7/HX58o1sjdBuWBkjoV/yNG1p2e+1DEWPOdOWw6KYZ+9jOXEFJ42kI5TaiC26dZY0DISI6/oK4OAwlKcS6u+fAxnjm+SBelkJ7zqkr528ZRyLbw5vLF5maH//TNjVYMI9l8KLcihGU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kefeng, Thank you so much for this awesome patch! On Sat, 27 May 2023 10:33:30 +0800 Kefeng Wang wrote: > If 'aggr_interval' is smaller than 'sample_interval', max_nr_accesses becomes > zero which leads to divide error in damon_nr_accesses_to_accesses_bp(), let's > validate the values of them in damon_set_attrs() to fix it, which similar to > others attrs check. > > Reported-by: syzbot+841a46899768ec7bec67@syzkaller.appspotmail.com I think it would be good to add the link to the report, e.g., "Link: https://lore.kernel.org/damon/00000000000055fc4e05fc975bc2@google.com/" > Fixes: 2f5bef5a590b ("mm/damon/core: update monitoring results for new monitoring attributes") Could you please add 'Cc: # 6.3.x-' ? Also, checkpatch.pl raises below warnings. ``` WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #61: If 'aggr_interval' is smaller than 'sample_interval', max_nr_accesses becomes WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report #66: Reported-by: syzbot+841a46899768ec7bec67@syzkaller.appspotmail.com Fixes: 2f5bef5a590b ("mm/damon/core: update monitoring results for new monitoring attributes") total: 0 errors, 2 warnings, 8 lines checked ``` Could you please resolve those by wrapping the commit messages and adding 'Closes:' tag? 'Closes:' tag might be able to replace the 'Link:' tag I supposed above. I have no strong opinions there but having both may harm nothing. Other than those, Reviewed-by: SeongJae Park Thanks, SJ > Signed-off-by: Kefeng Wang > --- > mm/damon/core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index d9ef62047bf5..91cff7f2997e 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -551,6 +551,8 @@ int damon_set_attrs(struct damon_ctx *ctx, struct damon_attrs *attrs) > return -EINVAL; > if (attrs->min_nr_regions > attrs->max_nr_regions) > return -EINVAL; > + if (attrs->sample_interval > attrs->aggr_interval) > + return -EINVAL; > > damon_update_monitoring_results(ctx, attrs); > ctx->attrs = *attrs; > -- > 2.35.3 >