From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D801C77B7C for ; Sat, 27 May 2023 02:09:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9752C6B0071; Fri, 26 May 2023 22:09:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 925096B0072; Fri, 26 May 2023 22:09:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 813EE900002; Fri, 26 May 2023 22:09:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7203D6B0071 for ; Fri, 26 May 2023 22:09:11 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8C75740FD0 for ; Sat, 27 May 2023 02:09:10 +0000 (UTC) X-FDA: 80834402460.11.DC59F50 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id E2BB91A0009 for ; Sat, 27 May 2023 02:09:08 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YYMmaGwo; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685153349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to:references:dkim-signature; bh=JS6cY2ucjez6eb3phn2EYR5q1ofBPJgMZL+DfzgTSRY=; b=Y8aIVlb90bxvUv895sSpLk2kkJ2juNUaGml0TP6O5QepphaORvSJhixDjJZCupDQsKT3TP iW2a/49uSL9+Of/NkrVT3ow5tGKSAi/a6eMrMMRZ/j9Y+0gC8U/Qz0DOrQ6MPsXElUVEj7 NEA6y90dlYVPC583XxdmkxgS1oP6t/A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685153349; a=rsa-sha256; cv=none; b=kocU8u6fMmQJp9z7RbXyBg4X0oNQczSTcDHnbnfMs3bkse4CfyUJJlpZE+nqO4YPfpy71i nKBbwBf8VTOKWUv1ONaP4NyNSwb++nylx9eTayIfE8lqsS4WO8lXuN4so75K7nfY/nahL0 bcvnHF68e/DEDhCEsxcWCZbrzm+4APM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YYMmaGwo; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BD7DD61789; Sat, 27 May 2023 02:09:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5480C433EF; Sat, 27 May 2023 02:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685153347; bh=HN9NwkpD1iuTdQGq2w1K5FjteO+8O/u8Z419WVY0jwU=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=YYMmaGwo67YMuvAG4IqiZxvJBDzjj1lsDAT9lxqlhcLdxk4tYmTRwTqv7gDVLzWiQ f4jqOoGVEU/vaCd5z7MG8XvlRr4iuJrBhQ1/6ffwKU6mW/qPwLqrtPS/otAo3dYLyQ wLgvfXYJaV+62HBxf520xvXF3Fu+BYHAt2DfdcBChjruXxCJZ8fjdU7DBa5abQFL27 H18U1jrgQZiycmV9ZucdsYjG2P1oC5tnaJy/+ULlPqoOnCdU7i73Mdd+NwwtRDI/Gb A2Wb3/TwLatioa0XJKJF6GjC2o1zhZ89B5aBPazxNExc5iLoCsPwXib+v34lLXjyJg QLn8Z1y75EJOQ== From: SeongJae Park To: Kefeng Wang Cc: SeongJae Park , syzbot , akpm@linux-foundation.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [damon?] divide error in damon_set_attrs Date: Fri, 26 May 2023 19:08:51 -0700 Message-Id: <20230527020851.7855-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <81956ca8-8228-1210-c855-e652e2f263dc@huawei.com> X-Rspamd-Queue-Id: E2BB91A0009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: eycxj8e4rbjcsg7qmwg791bmngqz1o6t X-HE-Tag: 1685153348-959854 X-HE-Meta: U2FsdGVkX1/Le7frF7Bu4y1FwlFx3YHQTKCWUKLnHAmOK/IFrXjyczZZ+Vlax0+AtrdY5OKO3YXdugcEUgtCqLI/72KgEl4ilkGuRjDUxWZ2GCa/BWQkYmaNX/ZXp/Z+1d1Pv8lrJVcVMBMI5+bVs+Zn264rUn3qV+JOvFyuQrLW6mj2trFpE5UIhhNM233AoESQ7HrK1qZAyuxcAkDvH6Wehm6A1kI9Gwi8YmBgfvF2P6XW8gZ58crcqhrVGhGDCAT5JlW7j7R7CeemFndxyYCASdMIk9j38g+M+N1TcvyoOVhxzr2HcQQWym3mNcHj1MN4Qg35huq4HxqH4wz9fwzAk1pVH4CEHetHA6iA9Tg3ZJ3zSqtnL94+yBcwoNZpELlc2YlONyGmgyhe2qb1jOoWBgwTeMkxaMEzrFX1aTTX/NIxgoNQnKFiMSSN+AU8GiQ7aRtn+h9vLxUlvKqInEFnCscPM6uUuM3/vIcQk7ndAm50RnqwZuSan97+cChvwT+BknUvlX/VtQ++5xpeO0oKPGCjFdN97sMAAVaiqqaD9SACh70gha55RFys84CIfaknSJUVdf1xthWJAwiT+E2S2v2xKotZXNtg05FPVpPX5N+TF923dnB4BCcsXh4P2eQYimLzytvu9lWunJwUPLg/Iv4QOvAZFK/wjlz4SLNCR1C9nxmy2bj30SqdfiMhvDvkpIjctvkwmqyDPWfJ7QZ2lJdxZ91poeFfVGo1XNKKJcI8+fM465yDutjEE59tQcJ9arMSumjmF6cUrJYyValnMBioCOmPJdVHVdByjYM8FLUX6ruuNH1lv0Tthd3mvNOpuctPIwFIHQp7qeWBMgD/Hikwk+q/k1UWLTkaOuej2FOIXHQfYk1CEqAdviBVgmIETq0+qjdsIUUmpyc7EkCympX2Fj1kUBXkS5zyrgDKL77g+yWTCD2fwqu4eyR8gNdidjspljIC6BHyuGL d7ZbaxKs avtGqlzgzxktht3JfHVXE1kqP0QLTbLLBPTBhDiEtKfQ0EChzvmIdSEvzrYpM6pH+jeJtJqOBJYFiCQ/qV4v/U/7LqEK1bfhXo+w/e0Xd73U34HMAnkGRRiAc6s4y/NR4DYmutKkfnJ+KRpA/uS8MDgmB7jTNLI4915rfuvpOAC3lXoTgQ+lEYuQLWN6CQjar4PhRqD2g8nW1r4BLfdmr1nPrr1fsYdGLPiibvtcMoLfVIt9XVDnQOnaaWyL7rhmFA8zokcTJr08tElfemKzbbh4I6uTVmPLSWHsH4u5tmOzValZL1ceVVEb8V1Q0yLsIWJgf6e1YlDx786mFEoEe87hxySYDxmET4lhVZwdXo3KC+NCOCe7FLqs/g0dZVFFZ5V9Vqk17Z8L1KMChH2IlkxFV9/AL2SUaRiahnxUfmN/V69HtwroTCKDrDDdbG8pr40W+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 27 May 2023 10:02:38 +0800 Kefeng Wang wrote: > > > On 2023/5/27 9:46, SeongJae Park wrote: > > Hi Kefeng, > > > > On Sat, 27 May 2023 09:15:01 +0800 Kefeng Wang wrote: > > > > [...] > >>> > >>> Nice and effective fix! Nevertheless, I think aggregation interval smaller > >>> than sample interval is just a wrong input. How about adding the check in > >>> damon_set_attrs()'s already existing attributes validation, like below? > >> > >> Yes, move the check into damon_set_attrs() is better > > > > Thank you for this kind comment! > > > >> , and it seems that > >> we could move all the check into it, and drop the old_attrs check in > >> damon_update_monitoring_results(), what's you option? > >> > >> > >> diff --git a/mm/damon/core.c b/mm/damon/core.c > >> index d9ef62047bf5..1647f7f1f708 100644 > >> --- a/mm/damon/core.c > >> +++ b/mm/damon/core.c > >> @@ -523,12 +523,6 @@ static void damon_update_monitoring_results(struct > >> damon_ctx *ctx, > >> struct damon_target *t; > >> struct damon_region *r; > >> > >> - /* if any interval is zero, simply forgive conversion */ > >> - if (!old_attrs->sample_interval || !old_attrs->aggr_interval || > >> - !new_attrs->sample_interval || > >> - !new_attrs->aggr_interval) > >> - return; > >> - > >> damon_for_each_target(t, ctx) > >> damon_for_each_region(r, t) > >> damon_update_monitoring_result( > >> @@ -551,6 +545,10 @@ int damon_set_attrs(struct damon_ctx *ctx, struct > >> damon_attrs *attrs) > >> return -EINVAL; > >> if (attrs->min_nr_regions > attrs->max_nr_regions) > >> return -EINVAL; > >> + if (attrs->sample_interval > attrs->aggr_interval) > >> + return -EINVAL; > >> + if (!attrs->sample_interval || !attrs->aggr_interval) > >> + return -EINVAL; > > > > In my humble opinion, the validation for monitoring results and for general > > monitoring could be different. For example, zero aggreation/sampling intervals > > might make sense for fixed granularity working set size monitoring. Hence, I'd > > prefer keeping those checks in the damon_update_monitoring_results(). > > > ok, will keep that, Thank you for agreeing. > I check the damon_set_attrs() called by > lru_sort/reclaim monitor and sysfs/dbgfs, the above changes should be > ok, maybe missing something, the working set size monitoring is not > public for now? You're correct. Working set size monitoring is not somewhat currently publicly exists, but only possible usage of DAMON at the moment. Thanks, SJ [...]