From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18613C77B73 for ; Fri, 26 May 2023 18:54:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADAD8900004; Fri, 26 May 2023 14:54:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8B9E900002; Fri, 26 May 2023 14:54:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95468900004; Fri, 26 May 2023 14:54:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 864A8900002 for ; Fri, 26 May 2023 14:54:24 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 53629A0222 for ; Fri, 26 May 2023 18:54:24 +0000 (UTC) X-FDA: 80833306848.07.3DBCC96 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 9130F1C0005 for ; Fri, 26 May 2023 18:54:22 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=j+nYEZTg; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685127262; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FvdzceZomaXiAP8zg+dxcckUNrrnHH3YQFppRqWPV3Q=; b=ldmHkUiBxIQxjhvgwlTArWWUXkhXMKCW05IsDTb9Z04EUSPMiv9baglWUht4yHDBbHzj57 rwvGbTkR6WLjGh4oh+smJaFGria1xhWrZIDiDCxcO4D/WSPqyTBs9BR0ex7PK9Ka9+ovfJ ve/Z2Hg4awHADJeJqmqtE0stVPLr6H8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685127262; a=rsa-sha256; cv=none; b=HaWFJT6uasRNtdCTLGA/YfWJqyhrdxreHNNUbM8bTZhjCfkRT0AlvRu5Z/5BF/SJSiVW15 TbqBok+56kBdj6cL+mdMuTodZov4SWv0lfNUl689L0VgRfikd3tiXNiTb4ag41zND4srAx j6pn9ywhpAfwjGk5t+w95EJ1dno0wvo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=j+nYEZTg; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8A0DD652A9; Fri, 26 May 2023 18:54:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6055DC433D2; Fri, 26 May 2023 18:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1685127261; bh=Urg86fkvb89N1W4EU22LaP2G2rEesdWCWKmXrLhixPA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j+nYEZTgiX0csmwuA4GsCM/V/trUTp+2wIJY1+q0YXr3lfeWIc0JQ8XaLhi81frAG u5uFSqDQBRakCBxnbiR7o/6J2w7YB5QmbfVH0JJuATcydi0/Flu1+0Cw/T1dtCz6Mr OHf5lqgpAN9lXal0ddy1I44pvXiYtrIseirqKkY8= Date: Fri, 26 May 2023 19:54:17 +0100 From: Greg KH To: Jiri Olsa Cc: stable@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Masami Hiramatsu , Tsahee Zidenberg , Andrii Nakryiko , Christoph Hellwig , Daniel Borkmann , Thomas Gleixner , =?iso-8859-1?Q?Mah=E9?= Tardy , linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH stable 5.4 0/8] bpf: Fix bpf_probe_read/bpf_probe_read_str helpers Message-ID: <2023052646-magnetize-equate-2b24@gregkh> References: <20230522203352.738576-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522203352.738576-1-jolsa@kernel.org> X-Rspamd-Queue-Id: 9130F1C0005 X-Rspam-User: X-Stat-Signature: hoptppbhx3khzk4yoi59kfak9u8qgxsg X-Rspamd-Server: rspam03 X-HE-Tag: 1685127262-85901 X-HE-Meta: U2FsdGVkX1++4qaCsXKJ0AfwHa4WS5opp/SAffyEeGKi+LSMf+IPavIf4DMu7PASyuLti0KMgzPRQLkf1Qdf7FmxuZ9AZetYfG7NvbDDB+WNYPo7n0VbBXdtJqxL+OTXbqko5YCrEznL5vIYRzrLxWGnTp7NHC005XZ4vrdU5Y9L5zp1cfYADq0uGzqUhPm8uBfl64Oknv7hIZ3F01ugHLuV9nLBIW9qWyRTS+0I9jqAkimw8ZcgdLniTQegx7tpIO8lgoLTSKPfzbNdQ3aQ87yh6ubinL/jevUm0qkLiYOwMTYrZ6kv1gZOwhJaBkHUUAjnuqfZH1yW6Go6rMFWPNDGJvUAxl4vVhwULrbz5CLTB5ESGGJaUEbkZJWEg40+jOuQAQ9+MMHDHimQxWvjbHSngg0UtpmSzshNwWGETRcauvWbo1G5O24ifBkJ8psyBQJuBwTBkp83zSvDFvs1v776nCLK/h636gF9BjjtEbJI9ldIxQKIhbMdB2DvFW9bYhDQqPgs6km5rUFnIZlbgsROYfqtj5/7x89PjL0KxtvgIrSUCPqvSbqJuUZ38vedQxNkHw8LogxFk1duNajUXfK3kEbq33bcRlEKlh4P0KWMefg0KJGi+iX3G7thzZoBpsIV1MjF/tYibto+GHamKb4VVV10WHzlT3YvsHGw7qg9/G5x+PE7FNeNSRdCKrFKu/+imvRP5FnRJ0ZaVsm8FVZ1yxgsue43Lv64LBJpuYFXPqrnyGcjAtZKYBiU29JLtQD0atFsJrXYRJNAVveSZlh7Qzf9YDE8Is3VRzmSEO5oCYJMdnoLwMebh4yg7MqtY+Zs0yME9AYoQ+D6+6ryBk5z/kEbr+EYX4vqXDRmTd1IEp6MqNz3CFR4av5TZTmR8e3vD/hQWOfY4Hy8qIbdibVyXL76G88NGI+aUNbr4/19TJYqT3chPRjPuLpHUR+1Iob4kSgaeQaqOhOQrwM 84iG7Vku Ck+aZLj4bU07BU60LtieOyOXM3a9VSGtsIHQG84M9XSNTeYg7D1I4UKhxo3bVjOE1NJKy7JVnchtR8GMeQ+IBLsO/JwWQP9xzanTszpZtebd4Pm8b5kCtD2dd0t00WZZRR07RItiYppDI+SDTF5i1GGVxf+wbiqlXtEBbMkOlybLKpYvpIKeaMN+dwe3vCDCTCoDRTRNPZ/wz6+DlQkv8tFGqRKKoX33mkvpdcB291xm5498fDs/WsdS/4Y5SZUHVtCDuKGLItRMGXF4Vn1jp411U6aBi5etKBj3f4dwIUKKtXNCgPAYgMY0PCE8xWba/nZf9LViJenfCdyxCSM6szqeuB5t8Vsj7Fd6iruc7jFwgyFFF/GNlvTqeda1ejGFr+RXo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 10:33:44PM +0200, Jiri Olsa wrote: > hi, > we see broken access to user space with bpf_probe_read/bpf_probe_read_str > helpers on arm64 with 5.4 kernel. The problem is that both helpers try to > read user memory by calling probe_kernel_read, which seems to work on x86 > but fails on arm64. Has this ever worked on arm64 for the 5.4 kernel tree? If not, it's not really a regression, and so, why not use a newer kernel that has this new feature added to it there? In other words, what requires you to use the 5.4.y tree and requires feature parity across architectures? thanks, greg k-h