From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 718DAC77B73 for ; Fri, 26 May 2023 18:58:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 003E9900003; Fri, 26 May 2023 14:58:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF665900002; Fri, 26 May 2023 14:58:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBDDF900003; Fri, 26 May 2023 14:58:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CA625900002 for ; Fri, 26 May 2023 14:58:48 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A04B4AEB07 for ; Fri, 26 May 2023 18:58:48 +0000 (UTC) X-FDA: 80833317936.18.3D5FDC8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id E637C10000A for ; Fri, 26 May 2023 18:58:46 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=ysYJlGcP; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf05.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685127527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vb0PCBdhRD64CcmwrigPxTn9ULzhjI9TSi5enaleezQ=; b=TF1gvfdErw/CdSTPKPLj8Lh/j2vOBDUSPTabaNwQ2epykObznljltQw/zCvqRSyzovjyl5 zlIk2GydJbd23R4rmUa8D9yieRtvtv9tj/gR1sCsy6u3VRgYHbHArWybuGxnsnrdzBpRqG 1JLEHE+knbzT4dPM1tWtwCPBdOjl0uM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=ysYJlGcP; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf05.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685127527; a=rsa-sha256; cv=none; b=D/VJB9tqhCNkPxSw4N1IGFy7B8x2o8yCEeMVgdBshSHGYTmCyM+/WDtoFdSbF4YUiYRq7r A20brLS+wO3IPGlsnSAXCZgQloAy82/C/qbSaiYgXMzezUyeMzZf7/dG1dw1UHT5/liG8E 9dcacfD8JlMD05lS1pmt3nryWWWa4Fw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0D423637F7; Fri, 26 May 2023 18:58:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D75E1C433EF; Fri, 26 May 2023 18:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1685127525; bh=LuO+2BJiNosMjkbK4fDQs2ihVslEgPpRQZiIowABKv8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ysYJlGcPZEXxZ0oRwjaaJraIyWWhNulZ9Iry9w8t7s2NOOepQFmyzmfg7rEmvhzU3 m3f/gzlVFnr64EKNS5Stc0FM2o9MLonz2h+67ZRIWfPLuUG5fXGXsk3w7QHv0s2iH6 +OHfChmguWsVQx4dJS3oYgklMWqtjMXTwYUk85D0= Date: Fri, 26 May 2023 19:58:42 +0100 From: Greg Kroah-Hartman To: Vegard Nossum Cc: kernel test robot , Sasha Levin , oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , Daniel Santos , Ryder Lee , Felix Fietkau , "stable@vger.kernel.org" Subject: Re: [linux-stable-rc:queue/5.4 4610/23441] include/linux/compiler.h:350:45: error: call to '__compiletime_assert_215' declared with attribute error: FIELD_GET: mask is not constant Message-ID: <2023052621-raisin-clergyman-47ff@gregkh> References: <202305210701.TND2uZBJ-lkp@intel.com> <07135e22-253f-cfdc-dbba-0e5e670c25e9@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: 3zanykax9suc83baph1em8cr6n4cz8f1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E637C10000A X-HE-Tag: 1685127526-557529 X-HE-Meta: U2FsdGVkX18bhuzo4vKz23jxfe2GXnK5FcQkNWkhTvxdDGEM266B2hSzkjpc7t5mDt6xRoLgWkDyVguyMxPEi3xnT+AtTWKQXZ0bf9CNd6bxHk0dlvtfIVSmRt7fDXfj0FFKG243nUOOjYCR9JEl3x26chCgMHExbWRKdz5hzr4PHfor3RhlNiAFWpV1E8H2ptaDx56OFOPqTWa4K4WmssldMmIJQDR60QCCnGsSAHCttZfQk/yEpljUdBA+L4b/MwvHYox12/LGVStaWFrynKIeZNLSLXeXNBftFu/bixvcXTEJm0oBkE7kDRHppdEmFt1R+IgL98WeqVzccRObNh0XT1mSTgQBeGmeHqOE6QETgsmFG0llbSR1+0DqX2FMWXHoNIkqcDLfmG2ZrBAMhPb+xD4W/SjAq+N75lhgf2SPudjKM8doxt+czQOCFvncNLQxoio/lgABY5ezpFbOuVdp+IwNzhSjLQa4MyJIuX8kmD2zeSl1R3VPQ8/dgtxLdwssBZ47scQODGVP5OmrDbW5vdVa1kRMW7YhoAnaNHyslpeJ65wA6VvyAi/05r67NejX5VOGP6eZT6MHXjuzM/ePVIHzS1Qtlby+GdOt7JPtjNKQQEBexefCVg3a37TGtnthWOBWnWq1KA/kXTYP831uDSv7m9/5iAQSFVjWTh64Cyz9UTlogT14mfLaTBWZl0kSGiWAsG7Efn/5fPHDtKO9ngrudVI+b+1HAlo4qR+KbovsjO25en8KWpwcWmbhFUYTrnE2kNG3GuJe7aNrpBl6/CIz/BMrgkPHGpLdHog1BbDfUWR59E+ABXRGsSZJjaY5APm8mrPyN5K6jtxwehk1tlLv7o7S5ikDkBSyrarON29TgkMayipjwYmdGTNTCrBI0s17dFuNV/hUVdrd2qfyYb78MA6Yuy/Rhzlvlra3pdVXx9Wixv9QBHWIV3iyegTfxDpqeBgnRtNMUup wvgk+MZa Lyf6mTvuo3SSnNO+iUcdqOItEla9QmCNKVOEfBhXrkHQCbqcqNfEZcZaQ3zbg8bUUgPx9Y2nEhnsmAIYCIqSJm6QnwJzOJuD5VbP2lua7tIzbEnj1ZkWbkN//7ThwBoA4F/eriMOZDoI9if5lf8AbMyw1NAXHcosBlVG9dhmUue9r69oMrYsRZzZosEgqsMnk8s+BaowtsRbrRAixDZPxwo5H9DcMRWPL7oDwDyZvDWe6YNanVvwIXxo717bWXqcA4lI/6YTa7Kfe7jc8hi7YkUkONH0Z98XZis5oxmx3apTXj87rNwEeNzeCx113Mg+RPtcOdwfRpfFxYQ/gkY0WBdHurhwSPjzZ1U2+zP0eoQm3VGu/8KzMrs5nVDV1trIjl0xMDrHH24OyM5UaorYmpYXAplc51Z3YbRlf07y/2M2W4O6T9/bnpzT4RHAM0qlLwdnTPYU6jQWKlq6mVOyRCE81CkmjaOPc3yzkA043QsdsYyhhgY8dFFfvGovViNFYLteHdoiCrHVnXZc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 23, 2023 at 03:45:29PM +0200, Vegard Nossum wrote: > > On 5/23/23 15:37, Vegard Nossum wrote: > > > > On 5/21/23 02:12, kernel test robot wrote: > > > Hi Vegard, > > > > > > FYI, the error/warning still remains. > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > > queue/5.4 > > > head:   9b5924fbde0d84c8b30d7ee297a08ca441a760de > > > commit: 3910babeac1ab031f4e178042cbd1af9a9a0ec51 [4610/23441] > > > compiler.h: fix error in BUILD_BUG_ON() reporting > > > config: sparc64-randconfig-c44-20230521 > > > compiler: sparc64-linux-gcc (GCC) 12.1.0 > [...] > > > I'm not sure why this flags my patch as the culprit. > > > > I just tried this (with the supplied config): > > > > git checkout stable/linux-5.4.y > > git revert 3910babeac1ab031f4e178042cbd1af9a9a0ec51 # revert my patch > > make drivers/net/wireless/mediatek/mt76/mt7615/mac.o > > > > and it still outputs the same error. > > > > The FIELD_GET() call was added in bf92e76851009 and seems to have been > > broken from the start as far as I can tell? If I checkout bf92e76851009^ > > then it builds, if I checkout bf92e76851009 then it fails. > > > > Should we just redefine to_rssi() as a macro so it actually passes the > > field as a literal/constant? > > Ah, there is a mainline patch that fixes this, doing exactly that: > > commit f53300fdaa84dc02f96ab9446b5bac4d20016c43 > Author: Pablo Greco > Date: Sun Dec 1 15:17:10 2019 -0300 > > mt76: mt7615: Fix build with older compilers > [...] > > -static inline s8 to_rssi(u32 field, u32 rxv) > -{ > - return (FIELD_GET(field, rxv) - 220) / 2; > -} > +#define to_rssi(field, rxv) ((FIELD_GET(field, rxv) - 220) / 2) > > Greg, Sasha, does it make sense to pick that for 5.4 (as it doesn't seem > to be in there) to shut up the kernel test robot? > > If so, should we add this to the changelog as well? The changelog says it already, so now queued up :) thanks, greg k-h