From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D77CDC77B73 for ; Sat, 27 May 2023 01:13:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25EAB900004; Fri, 26 May 2023 21:13:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20DEA900003; Fri, 26 May 2023 21:13:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D67F900004; Fri, 26 May 2023 21:13:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EE5FF900003 for ; Fri, 26 May 2023 21:13:42 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BD44CC030A for ; Sat, 27 May 2023 01:13:42 +0000 (UTC) X-FDA: 80834262684.19.D8EB24D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 07E5540006 for ; Sat, 27 May 2023 01:13:40 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=T0S4ZXib; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685150021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AlfmYzIoiKo/BoKxuxICyp2smxZCiLJelwwfMJDh0C8=; b=5whirvXlsqqQEFAfazGrbbj3oGy8HMv67UP6PnMjAWX2h4VkKKthgXRTeDyUf5UqB10EBR n+4Zn/vEPB7ObOxT3QAYh51lw9dcJz+l+z15h2CMrKLAEtYIC3U1uuzeke/vbM0ROvM5mA wgncjg3MRudDH1mcL+R55NFGmkMYc04= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=T0S4ZXib; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685150021; a=rsa-sha256; cv=none; b=yMID4cC2EwDpagz0roO1CcO5Z9dkJmpA5M+xItY+4D/mTI32/sIQ9XiUpPi+GEpLLKWv3M LRzboueMWkZnWEu1q+2NVfcWlDii9/EOYEfce82XCUEP+LHch1Jwsr0QPgsAMLgt/w/BiX G4ZbuxWABVVvUtsL/N7IKDVoksNF3j4= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B22C614CE; Sat, 27 May 2023 01:13:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12EE4C433EF; Sat, 27 May 2023 01:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685150019; bh=bnZn/fQHYsSl0pv4U7PItA9rlBxxlQgsJQwYXNj4rNk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T0S4ZXibwLE948S8DRkzaDSL0v6FqP/y6telzB9wrL9huYI6cKGaMzFhOr+Pgqhyr L52M64xyEB3qyUrRqc9lOSlGxwf8O/Evs//Dr8tmDSQ5zDmrZSjnSFtpG+SvcbGg21 AlC2Dd7CT/iaW9EuBn6kFNvboA3TIQ+KXblFHF/ZJWEAvn8cEmp2EQmcyMYtlxhJGH znZxp/KUtnS5hM/pWGE7sp+VZD+tvEC2616y+RGcnb2UuXbhkalLlcRbIuArJ6AKs/ vLIopOHNRkuWFx1VTcwciH0SAVhfg8LT6eOvHa0PhwGMsvVJXNSOHDEr7blO/kBIep 049T+tKPBZfvQ== Date: Fri, 26 May 2023 18:13:38 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chuck Lever , Boris Pismenny , John Fastabend Subject: Re: [PATCH net-next 10/12] tls/sw: Convert tls_sw_sendpage() to use MSG_SPLICE_PAGES Message-ID: <20230526181338.03a99016@kernel.org> In-Reply-To: <20230524153311.3625329-11-dhowells@redhat.com> References: <20230524153311.3625329-1-dhowells@redhat.com> <20230524153311.3625329-11-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 07E5540006 X-Stat-Signature: mof4ookfbmotqxbi17tnbazeknikxdpd X-HE-Tag: 1685150020-57177 X-HE-Meta: U2FsdGVkX19wUsLyK76TpJ7yB9dgJLHeo6FHadT7aW3e4YOu8cWSzPaSgJbfOhvXL/IcvBfwB9SsQ8SEayEnny6bQPd7nwMGb/NIEi5P8JviYnTZNAs0xm/7ihPQ4F3MImxjTLQBJ3zy8kTqs/x2f3szJX+R/V2ezaY0YMyIH9d6vNthJeZC7nNkzfu8PmoVSilQquBhjyGD+2z9OhePPmYz6OUTuur3mMG14eBdRWnrvWdNmvpsCFNIxNmpbmqkfPaUDW0z6yerTIN50zcOBh9p+SMq8fuPJYLC5X7OQgtCiiXRsABU+753H52EaBFiZTiGaM60rmmAX8MUXY82sTcwPyevxACAkQXsZei9q43VJb+xhxj8dMhmk6HDid5vv1LCMFMQkzLmS2Jm/Dr8urzu8ToEUL5G7SLhAeLzzMDehsDv/qh9JnpX9rS2It7TMLtsClC97VIZbXR7T5tN2qerfJx+I7C/TXMvhDaFo2Z11mjCFr1VaRfT6Jwh6TYpUSdnMFpQvU1bnK7lRwe5qbTwFtkC4byo5a8Cq/RbE3h17KDXnEyLVtqKS0yXkHezn2o3hif/RbsIlUFRglZq/OLQbi0xj/5QEMhtiCvSPx5qO5VwR0NGotUiq96EnpAM2I/XZTfCMtsZT4bDv36zP1Z/E4iz5j3Maww+w+6iqBWYPm72InXckclm/hYhALeSkAPjaOuFMQ+PRSIqSNDphwjO+mNNLtZdnw6t+h3fUfeV09rzN/bqh26XTk2eXirzZSBL2KKJVIKWI2d+ZInlhgqCrbg5f/pqF/LR7E+KNIeFHoQ74lZlVK9ieNqm/i3DM1gw8n4QJJoZxwxloFTUtXPs238Y6rE/OHX4OpKRJw7z+bXJiVqKd6cQ3o4L8mcA1P9ZoKxR9hiYeHgC6FUPgNUvG9/WbVtQj2824cHXnIe0w2euZ8CDnLie/GaG6Z6NnxJqkprr9S8FMV+nonD 3wIzCRDd yGnJhu6E5zd8e5xDHfaGFHE+61mgfbUAt1+7N4hNm+Fdnwx+75NGr6X5Oe0wDa5GqLlla0qpNRsiIZVIxj5GbTyfJGykUD/v3UQmZWXygNpqSt8aYAiS2Jg2HCrXghOBLAmar9QVR88XQO1C1hNcMX3M06KzDGIG0kAZHZLrx2JwDpT/r21IxpptVnKPtolP/B3knJ0T9H26tHvpmZltElC4IwIbS4v8czY6ewVP+3TJ9l314xZt7Eg/Njds+up0pQ9N+EQgMnuH6NUUNt4KhTcfbnFe85ASyN+ASaDuhMzWVYlunlZ2WQqKHLcWsS/EIzA+OvRzlZuVYGkPMl45xbt9IaoJtUm0hF6n9mGdWNT7d+pP3rLg50INmCCgmPEO7Lpst77S3c+UDpw1aVEVKKqfdtDfN9x7HfrUGMvmYEvQH1HSexrK3dWmNgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 24 May 2023 16:33:09 +0100 David Howells wrote: > Convert tls_sw_sendpage() and tls_sw_sendpage_locked() to use sendmsg() > with MSG_SPLICE_PAGES rather than directly splicing in the pages itself. > > [!] Note that tls_sw_sendpage_locked() appears to have the wrong locking > upstream. I think the caller will only hold the socket lock, but it > should hold tls_ctx->tx_lock too. Lock ordering, as you probably discovered. It is what it is :| > + if (msg->msg_flags & ~(MSG_MORE | MSG_DONTWAIT | MSG_NOSIGNAL | > + MSG_CMSG_COMPAT | MSG_SPLICE_PAGES | > + MSG_SENDPAGE_NOTLAST | MSG_SENDPAGE_NOPOLICY)) > + return -EOPNOTSUPP; Now MSG_SENDPAGE_* can leak in thru the sendmsg() call? Letting MSG_SENDPAGE_NOPOLICY in seems pretty suspicious, no?