From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 927C3C77B7A for ; Sat, 27 May 2023 00:57:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DE736B0072; Fri, 26 May 2023 20:57:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98E40900003; Fri, 26 May 2023 20:57:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8560C6B0075; Fri, 26 May 2023 20:57:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 71E906B0072 for ; Fri, 26 May 2023 20:57:42 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C830CA1003 for ; Sat, 27 May 2023 00:57:41 +0000 (UTC) X-FDA: 80834222322.11.319C5ED Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 2C9BF1C0005 for ; Sat, 27 May 2023 00:57:39 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aLfMMwQj; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685149060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rUdtr6r3PmoAaW6qIy5abu2LwEp/uvxptQKJhnykm/I=; b=RICJNtymf1V5+GLkz5kaHv7P9szdcP5hD3z6WvEvpjBd+uT6IG1AZkA1Gi6QKcAtP0aVh2 1ab5tB9dv2m4Enh+PEtgBUvJR5JH0AODOMXLDGiiE5e9Jwtmm6Dkv/TPpZ3TO2p7N4nx/N 1Hd17hHuqh9HZBeshDFGMwrbBhfC00g= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aLfMMwQj; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685149060; a=rsa-sha256; cv=none; b=pLLAvB6gH1lAfxPydmY6dlFBG4yAUH4hH6QS7vlUU/mrbQzpw1YORXO4mDHa5vGAw1iVYO PtNHVmaafCRWOirGQ0le9vne9qhg97EvpDxJMkSP9PtUSdkJbi2zcIQ3DQb15+5bgrH6Pr 3u8uE9ITMJTpBnZ4zEzWd28iWT0rwMI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 110F761B07; Sat, 27 May 2023 00:57:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E64BC433D2; Sat, 27 May 2023 00:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685149058; bh=3vBQ3hNzB1htnPz205IbCSBNbcAAWMD/jc/FlGUItp8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aLfMMwQjdwdNcKtVFIzBBfhEKhzY8608s+2D5qjQ0I+cctckwK72Fr7Ero4sCyOay M/qiFF+9oqlrfB5lFVHgvB/IQFsOfaf9ms4w4pJrRSwroXILirP80J7tw+IvtlmrB6 C+axsiXhIPb8oG6HjqUu7w30SCHCFMI12quWVnGd07HNn5WSmjsVZ80qw6vSUhzlYV EFiVNxsX5sNgu7rqArJbv4j1C2nsqWjTEvKw/tWgLNDZQKKWCIFaxsDirhg7FmbgbK bcJ2BPiFi68edlfm+RtL/oOWB1hkdQHSRtYO/JKM041QmrEIOMfmOFV+oB8n4stFXo EfbKoqmE3Uf6w== Date: Fri, 26 May 2023 17:57:36 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeroen de Borst , Catherine Sullivan , Shailend Chand , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, Alexander Duyck Subject: Re: [PATCH net-next 05/12] mm: Make the page_frag_cache allocator handle __GFP_ZERO itself Message-ID: <20230526175736.7e75dcf9@kernel.org> In-Reply-To: <20230524153311.3625329-6-dhowells@redhat.com> References: <20230524153311.3625329-1-dhowells@redhat.com> <20230524153311.3625329-6-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2C9BF1C0005 X-Stat-Signature: ocz8gjprwxp5ajjf8e1dpw7rpx6f6gzn X-Rspam-User: X-HE-Tag: 1685149059-534174 X-HE-Meta: U2FsdGVkX18VE7frxiKW6tA3+IWIva+KfTb/OtwvjZuondKg/frqikjFCMb9Kz1Q5k+sUGj1dk1k8YdOlauv1COCoDDodv3MH5rUhWJTLfa1UyTbSxh9iI0rpQyHTGjH0OZtTz6/kzVinh0pbPi8AVBTkRjxRhaWZkI7nWIFzRp1CCSeWsNUkTQlgNqgZMRPp8hADhHFNWDfngxeVgk78AoWVCGcCr5dPiL9z95Ku9LsKOxkrdMV+9V/HpxzwFhNMjNTGiVf0xmf6cWYFlDYGY3mYaOJ3giQ0utoCifWqfxEBPU0iYtgNER+DDWqVUpMAMRJkEgfpKmFUWM49W+nNdHEOfmsPUdKgrBN2KFHXD68RVfcPYF4IrMOkmKrKSYZPMZ6DPfxWeZMikCD+EugX/TkHXYWYjHJHgRkoy5lTdDsDgs7yJLhufnHdudGh/icvDOMmy8udfj4sqbfG5LTrNu32cvlMflbN1rWTlzw0UrWdaKdjofqLqbNjtJmouFLJVJECzFsid3TWulS7l07shF8YuVfyStyMxQ0Rq9D0TlW1cR3xoXxVIescffvPUpFIoLZt9hwsamFLMceIcvjxSTjWFKTDqkmDKXTkJzbKtph75u1MXHkZ9uu59z0CO2CwicF7i/OJAOXx2goDCLu+KmZU7FpDkQWlKfu7E3N16vGbdmP0XdbRBXJ6Adpwb/4pRmzWHDNPzHR6VkMQof2Ogc9eQHay5Che2gqGK66KYP32MZRfkejDDO+AdwIoCdzd/zuMaP4BVEy4jbPT6Ti+XDqPgQqYKXvsTTYlEMOznYn+euSqbwEYkM54NNc1HefJ+dLCFwq6CgxK9WIe24agutG84I+fQ4cIJmZb5t1SeYW9jjfzIfrDZNOFwSVSfiasjN7qOZ/AD5TUmTIuS+ZlOIV/Xq27a4xCJPt9SqSQvqbOkDwe2l/csq/xSrZ3twD0ng1IYgcO3nJUOIVQ19 2pA1rLCM sgE8eh/cBbpYLhSq2KMq/RTU4jVaFhTSG1/ocBQ6fX1Xuf0OKQUa56stip2E3asZzb3Ygs2woAiPybwPzKc5pZcoT7TidadPv/8RoZxOHUK1DeQQJeEiIasDoASwBiX23pF717owZ0aVXQcqg0+cHQhJrpSyLCuGpwOoADMAUmeNwMIw6D8qIBO6dBFPCwZwPJi/2+qE+kK18e7dIF/Wop2wgAJ/5OjUcHrz2Kwjsc/5oK8bhOOFvHihKIfuEOA0h3NEQNUZXJKxtyIJW0BIfWYI3oYmTCXOrO2Y7zHxVSxUi6IpyLMzarZNBQQX9OsHWdLaXo1FWwT58fwL4MsILcT72xun4FlJya8rGXyi6w0eni3OZSOWr4L97A0DnwZlQFAEQHJozi7YgCz94glDvPHztvKlfpxM6PYO3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 24 May 2023 16:33:04 +0100 David Howells wrote: > Make the page_frag_cache allocator handle __GFP_ZERO itself rather than > passing it off to the page allocator. There may be a mix of callers, some > specifying __GFP_ZERO and some not - and even if all specify __GFP_ZERO, we > might refurbish the page, in which case the returned memory doesn't get > cleared. I think it's pretty clear that page frag allocator was never supposed to support GFP_ZERO, as we don't need it in networking.. So maybe you're better off adding the memset() in nvme? CCing Alex, who I think would say something along those lines :) IDK how much we still care given that most networking drivers are migrating to page_poll these days.