From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A55AC77B7A for ; Sat, 27 May 2023 00:50:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A56D0900002; Fri, 26 May 2023 20:50:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A07196B0072; Fri, 26 May 2023 20:50:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CE1B900002; Fri, 26 May 2023 20:50:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7DA186B0071 for ; Fri, 26 May 2023 20:50:08 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4A012A1008 for ; Sat, 27 May 2023 00:50:08 +0000 (UTC) X-FDA: 80834203296.29.6F02275 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 94B0040010 for ; Sat, 27 May 2023 00:50:06 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=b5IVwgYR; spf=pass (imf01.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685148606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F2xmqKILWJ1dgLZi6wOxmDNvNF7phhliXPZojQMvl0g=; b=JykNH7znOsj7Q8wb41h0rqP12yH4j9hTsMmpYJqOPLDoMxKjByY8LDCSzbeWofyETfAnQC xKXcu9OjWk8xrwRiZTiTkBko+aKFiCrK3bzohK25cRjNFqM/LfuJI4oNaqvCz/KwMgByO9 fC9Djt/0y6/ah6Y0Yid/Bw0gjDGNpvo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685148606; a=rsa-sha256; cv=none; b=vCjn8fhJLbMPn0TmKDxagUxEob1V0KaK9oQSk9sHbqFnYVFg5Rksxeoa4cYvkzITpNo49O Rn7jdxo7ezNw/a24n1/+tBNsyczCNKCZMb6HL3VzBfWgaGPlGeYaOP79QYE9ncOC5QSg7J gUmbbxj+2FQVrKoXzNvt5wUhV9YcwuM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=b5IVwgYR; spf=pass (imf01.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7AD4E65489; Sat, 27 May 2023 00:50:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2CF1C433D2; Sat, 27 May 2023 00:50:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685148604; bh=PctGZlrrzibp7UAnk07C/sOmUfyQ9mUKgJg38V2xuBU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b5IVwgYRE/2EVTpq7191D0vqSuCOLDLA9yxTg8kzF2RTtrFlASvkrFmPLaJtaVukQ dx5NKWsr6CkQoGLe9DVthIsfhGRUMLCIhOM3QVgrl7be2FWaDy+DnfW190vcVwTJ2s zU16jMx+fgyZWf833+TKCK1dS9ojn0TwISpmHXXc4A6MxBBQ/0mOPvMaIk698Velpj TprITEm52LvMpvY15nmUsfSBRWn/PIGwebDUf9F7yPhJw536eOoYIVLCUc4Fu6rjuw 5mKxlb8geTfkhmlqwBdxW8lU1ju4L3hTlb8r95qR77Md4eoESwaMNVfTOzd1VQdYKQ 4GtDL57/Vxi2w== Date: Fri, 26 May 2023 17:50:02 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeroen de Borst , Catherine Sullivan , Shailend Chand , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH net-next 04/12] mm: Make the page_frag_cache allocator use multipage folios Message-ID: <20230526175002.2591ccae@kernel.org> In-Reply-To: <20230524153311.3625329-5-dhowells@redhat.com> References: <20230524153311.3625329-1-dhowells@redhat.com> <20230524153311.3625329-5-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 94B0040010 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: mmbqkpmbhq4wc4ci7z8it5qpotdp59qf X-HE-Tag: 1685148606-870563 X-HE-Meta: U2FsdGVkX19otD5knFj4bydoPXf0N5lRgr02rpykmYteXRVI0sttjOMNb8DN6RfnUYHxN+GeSiv4wQMFPs4FLFdT4DVR4anOzhrjkoNa+kF3JIbpd3e/HIHSeKBbtGRn+e6kiIKiCFyiLYwD0AKKyX27JaFLFVdR/PC27YDD2oAmGtAPijiNEReZK55lqPRk4eef4ABxfOQ06FuZ906iHwFxNkvhBo7kfdIJ0RiZ2ReLjuvj4ppiEYhTC4egFnVKaMPCCY8Ia5EKHg3ilnIz3DSFwp/IzeTdtsZ9d8DrY0OjN1seqJ3IRln+thSS17Q2cN7zUnbkaZj4p1o8hIce3J3+Q9GhG3zKxMd+POb02cNCnlVTk5EmtIuI85ViE9YuhUp4B8m2BsDsiQfcqZYNTxGmoUNsgttTNpwYPtuMrJntjbGHwb061yeA4u7bKmWrHD0ootNmvqYpYAmGB5FDktVwzZhBo6Xm1/hcG0MTRg9leh9wUvxifn4KTHpEB87sgLCMzMtnp+krSWdcmZe8YpSjZwR7SAKaiT1uqtXKZyNVAaOvTlb720GjKUfcRIdPtwLq0DLJDmoFO3OmX1nqm2GjykXz0w+BT99ksroVDpDCxjORbza5VYGRCdIemxScrK0/lKD+/JqIyaG9FAoy9e6EsyJFzkAgqqPONff0mTFwYLCA6Crd1EVTiZ1fidraoCy/Q9xzdcpsO5qV6EL6U9Qd9jwYURs2+ZTcj1WBkWxSHFNkNJD4+yO0rAnJQPb5DEJYYQy3e2C/a6FKsJvdIdYg8ac9YSkbNc0T7N/S+PAZNUEp7YGspcxSIYOJVa42tZXtV69QhlHIsEaJKKrI/WoCVQasKs4RLNB+Yu0WhF+R4x6dUTF0qPRhPL8drCJ5aaZbuDzNqrc/6b4Qj0Znj9VTPE+FeBm4gEfgagqzj/Ziiolee5E11wfdOyZr3JC8gR2I9FD5k4JMjg/YZiY gK8f1Sx5 f6VF497YGUJYvKDU/ups+aIxsr5y1K9fVWWsrZ3JvorQ1H+M0cq5taqCj6/6p/iip50ync3I9ew2Nl6u25vfHM6fuH24IvpdPRyN00LG6Djsj8VC3/zYgphbAGEl0YZsfY5JGbw07JFoPI572w1QDF0L0reIBIrkq8ZUnsTUNGcGKCOctfhzlHpFC1uoEWwfuRGKQxSVMDgpB2tm50e4gR3Mrmj/ZrueH0/d8wyZ3+1EoPXn1comvE5GoqUnfizcTUioh4Ovy7E7LP1oqaCpG8hLtbLZ/Sr9ZechBfK0gG2NLSx8reD03LjNkJykBMpZOuPFpCbMt88v0sjBlTzns5LURDD5Ioy3BzGGjLnH8gDTVLP5esPiaqQg1r4Z8NQX+ykYdhzNaxdDnMI/nYpgjUm+McKWNJMzKXijQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 24 May 2023 16:33:03 +0100 David Howells wrote: > - offset = nc->offset - fragsz; > - if (unlikely(offset < 0)) { > - page = virt_to_page(nc->va); > - > - if (page_ref_count(page) != nc->pagecnt_bias) > + offset = nc->offset; > + if (unlikely(fragsz > offset)) { > + /* Reuse the folio if everyone we gave it to has finished with > + * it. > + */ > + if (!folio_ref_sub_and_test(folio, nc->pagecnt_bias)) { > + nc->folio = NULL; > goto refill; > + } > + > if (unlikely(nc->pfmemalloc)) { > - page_ref_sub(page, nc->pagecnt_bias - 1); > - __free_pages(page, compound_order(page)); > + __folio_put(folio); This is not a pure 1:1 page -> folio conversion. Why mix conversion with other code changes?