From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C2B2C77B73 for ; Fri, 26 May 2023 13:56:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9790C6B0075; Fri, 26 May 2023 09:56:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 928906B0078; Fri, 26 May 2023 09:56:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F01E6B007B; Fri, 26 May 2023 09:56:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6FDCC6B0075 for ; Fri, 26 May 2023 09:56:22 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 43F681A04BE for ; Fri, 26 May 2023 13:56:22 +0000 (UTC) X-FDA: 80832555804.11.D47BA46 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf06.hostedemail.com (Postfix) with ESMTP id DE744180012 for ; Fri, 26 May 2023 13:56:19 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=AXdjZQ9L; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685109380; a=rsa-sha256; cv=none; b=K5oX1ifNVW8hL4/sCgTXdBvawrZKAKWbHdaMhw8XRnh5MXXB4EhfOzl62Qh4qFHK9/sjUw p9wCzfSD8YTTZsKnOvLsnf42eFu37UZXOKc6xdfF9+lO8yqV0X3OKBqgj3qPzlYAQP7Afh tmwqJ5E8zmhEbJ/AcwH1UI+Ho8kwx0E= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=AXdjZQ9L; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685109380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zQIVOVK9K5N12JOPQK9cZ6VstYGEEtnt+WZ4R5PlTpk=; b=G8F1DbZfvapBbyvSXfE3glbwRbaecZlUMvxgNY45psRHPOgaYVzu0SsD+1xYez9K74jlgx LLjcxfusF9EEBRv3NisyiLsJsQpjc5BKmYfBZ9hVd7rxq1FT01K2ewVUnlktiDcFGWU+wC Fs5basSOpYCOCfc6GMFQlhk2Z4qpf98= Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-75b1219506fso53600485a.1 for ; Fri, 26 May 2023 06:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1685109379; x=1687701379; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zQIVOVK9K5N12JOPQK9cZ6VstYGEEtnt+WZ4R5PlTpk=; b=AXdjZQ9LEZqRgWdysoO62Dv5Jouqvf2vQsmRkfBYLT4J1bdSWX+8uVS4JaRrPln5qr x4G/28k4M5BGIb6rU/g6iuPw2IGQhrWzhmvlHEAKp7Uxr2CYhKgciFUsocMolg31ytds 3PN7K+AkSXfwsgAf7pcYpF3P92HODPZUA7mmGWtJp+4rwtTWesg5520gijlCgB6HejqS M5tF6bMCq3as2bspt6d+ICGvjVPh/A7xJg/ctY+iDnDJp9h470ygDE57z9uN1eRBy9fu KEyfjdSse4QogIu4/Eu8F3YPnt666wSVuiSImzJsRdP0SlWTkmuObzB9l0BGJfNbBadN bLiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685109379; x=1687701379; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zQIVOVK9K5N12JOPQK9cZ6VstYGEEtnt+WZ4R5PlTpk=; b=eDSOsStPxrKtKslQjuLM2Nj81dzqOZP0U/zJBqi3mFtyLU1Xx7qaH/NUu8iMY72fYa 8aJ+7PCM+miYXl9CsyfZ+5YDOM/eMIccctg5M5rJMil8+oWtjdNdm3bEzrAV+S4Zwoy8 gvfJZE/N4xooQFgtGX6ft+uf5192DY3vmcMJJk4Wrg+P+XIfDVMoVUY9XVHLXNcX6VkV TJTmwCKv+onpnV7P4n/Ph9z7HBSu/uhqWx/w1NFw13OZv42iBIvV07JsNUD83eboGdUx QkFeZTqdFtGqmpxrc7EoDQtiembWoBGpapO9MWQvoy5XhqoCodwQ7751cDu/Us42nn2H 6cGw== X-Gm-Message-State: AC+VfDwuCJCXHxUOJWCC9WqORyIxTzeG3eIVj9rig5TWG6ZThn7Mo5fx XHgFjKMOAWKqzCndP0B5LZR6dw== X-Google-Smtp-Source: ACHHUZ4gdQh29zUVAFMruhmhHTn/Sm+mhUUpS+je9800rAkdD1NefGJWUClptbI7O9M3D3wUwyLauA== X-Received: by 2002:a05:6214:5184:b0:5ef:8c79:fe88 with SMTP id kl4-20020a056214518400b005ef8c79fe88mr1960398qvb.2.1685109378926; Fri, 26 May 2023 06:56:18 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:8bb6]) by smtp.gmail.com with ESMTPSA id s13-20020ad4438d000000b005f2dba7a5b0sm1216977qvr.132.2023.05.26.06.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 06:56:18 -0700 (PDT) Date: Fri, 26 May 2023 09:56:17 -0400 From: Johannes Weiner To: Vitaly Wool Cc: Domenico Cerasuolo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, ddstreet@ieee.org, yosryahmed@google.com, kernel-team@fb.com Subject: Re: [PATCH] mm: zswap: shrink until can accept Message-ID: <20230526135617.GA44890@cmpxchg.org> References: <20230524065051.6328-1-cerasuolodomenico@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DE744180012 X-Stat-Signature: y77akgnn1whw8j1yxx5q7pbhmgfpfz6p X-Rspam-User: X-HE-Tag: 1685109379-937914 X-HE-Meta: U2FsdGVkX1+JAm0QK+gFkPfG5p9/kQLNSzKlO9OnNdBXiJ/sSrSiVXQaknN/Yv5D2RfaRB9h71g3nfLzRmkSJY5upjHP1Nn8Z8kbYe1fmICh0NRsts21mtPbUC92DNDjgADj3LUyPmo3V+1OOZUr6plMIbUyRUrl/2fnn+X7rXmetGLGzZ32lyXrDlnxrNB3ugKK+CdP2YMf3qkLCNCRogeIRCFsGyXXK7yO3Wv7tlK1TM0B58WdlWpVinAhJvhF0kpwBfAWk9zXeILI57ZPEqQVlgezVBrTR4VW3dpu9GLBYUKt4IwURE/7d3QRpxwcowumbdcscGyzINRkb+BgMoL9RwDhTiasJvbQtKqfBmi7hvwSlu22M82mpoWSjwnjEymzaZzKC9bRjhx8bsuzGbNZ+dDe5BBGDm5pGel9eX/aqcSgiqmIeebFmNXHk09R64JVREJ+99nzSoZTlq1QBnZRL5ywfD//scV//jLe51ldO6bHSW/XhNN+8am7N8Ft7Dd2cDnmLG2KC/Lf89cchbo4gGYN1s77caM0ElrdDZ6ZuwqzfpRRE8EXS9PmA6GSsVpuGpBRZp7sqkVNsycfPIVB/TNCSFY/jIGf3KT3fL5J9gRuorguE0LZ3Tawwa10OWmdMy4fVXzIR1H1YJHkvJxcArwY0Jg/LrM0keUIeBtQSusr2qBc7pkWax8i2LDnN+iImC2QBXjZ2ULKfKegXoR+Eo8+MXzz/2tZHgznM5Cbxwcg6a/PiSyIwYt/Qln0zg++lkgROUHeLSogbM4rWZZiEcd0vQRMP9izx94P63Eon3d0sg8oS3Ul8URgJH0uy/A1q6KdH/3Jpw5MRcT/e21kPlPIB4LJIdzZ9M3PxT4XDWLvCHP3d4quknX8bkkyTNplmxKL4IYKAJm+hqMyS+/4DKefXdeWLA0eF/8eJgPBf/N0wXZbyCmKhgUeax4pYClz5JDzCIUkT1iCY27 jAv1Shu2 GcDm7dlrJtcBOTiAPxXFoDtkgzuHgM6Fq5/pDvszzeBVm9yqXrIWH4I2S6bhy508FkdNRSvY941YZON2nkTQOtuSaDgBij714UI/x962ihkGr0fzka3/W4ndJ0bgZnlwAa1gjraAs7wB3467Dr3bCStNSyNgAFMjcEx9er7nTTq4R8AQCzWp35VvE8N8ktIek+VW8VqCTb9S75vzctk7gkB3pKblrJmToKCQRVFhfUlT79xPjlX49Z1dTNF79s1XlZULF7AzqiNA897DxP3OE7idmEBhWJ6+Rq1LWhFgyptfVQDI8mmMiothjBTR5IhFPtk7IEt37JKq+w+meo/TLoa8RFYq0Y39DoxoEXhcTx+E4g6QE/Ex058JmEA9uwD8opFDifgRPvKvtEHKZuz4I1fXIef1lpzZZ70qKaM4WUKhUVKU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 26, 2023 at 12:18:21PM +0200, Vitaly Wool wrote: > On Wed, May 24, 2023 at 8:50 AM Domenico Cerasuolo > > @@ -587,9 +587,13 @@ static void shrink_worker(struct work_struct *w) > > { > > struct zswap_pool *pool = container_of(w, typeof(*pool), > > shrink_work); > > + int ret; > > > > - if (zpool_shrink(pool->zpool, 1, NULL)) > > - zswap_reject_reclaim_fail++; > > + do { > > + ret = zpool_shrink(pool->zpool, 1, NULL); > > + if (ret) > > + zswap_reject_reclaim_fail++; > > + } while (!zswap_can_accept() && ret != -EINVAL); > > zswap_pool_put(pool); > > } > > while I do agree with your points, I have a concern about this > shrinker logic change. The reason for not doing this as you do was > possible real time/responsiveness characteristics degrade. Have you > checked that it's not really the case? Good point. Adding a cond_resched() to the loop would be a good idea.