From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC1CC7EE2F for ; Thu, 25 May 2023 20:26:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38795900003; Thu, 25 May 2023 16:26:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 337C3900002; Thu, 25 May 2023 16:26:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2273C900003; Thu, 25 May 2023 16:26:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 14803900002 for ; Thu, 25 May 2023 16:26:06 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CDF7DA02BF for ; Thu, 25 May 2023 20:26:05 +0000 (UTC) X-FDA: 80829909090.08.1A1F859 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id A3831160008 for ; Thu, 25 May 2023 20:26:03 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SQE8oA8l; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685046364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hGWF7oh2LEzmbxCkXSbyfIxYb1F69eWOzVXNnT6su9c=; b=MlI4WgqpseA/MIHgI+A2ANK6/b5VIHgR3Iz0jr9n42pbU36H6aBx+yFAPWyKxyiKdGAL7r JP2fuNAvfjGgu60Hh5nJP91/UpMTg8pw1oOJqJVG1ulsHcLgqnKFnZyHJFL7vOEKwyhmyd w6tV3x4xHFhHRgemZyBVtjkDmT0KHyY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SQE8oA8l; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685046364; a=rsa-sha256; cv=none; b=357upB4wHLX3HslyH4dk3JTAB/dDp+CMT9e1aZ5A94j0Ats8UhkXAFFfBJx1QJNawh1bYH 8loQjaWCUQ9NpdvGqWywDYd/0pvCCH9fS58f6LVWORIH4XIwziykpzWmw1YcmvXtgtBmGQ vTg9aYCb87QxlH/N3zRYZAUu3Y5UF1o= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EBF4A600BE; Thu, 25 May 2023 20:26:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 185ECC433D2; Thu, 25 May 2023 20:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685046362; bh=q0CSXKuNpY/cOn/THS8/5Wy4aJR83TTmgU6zxWwJSXw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SQE8oA8lQRwEus253i9PgXAYxS+1hfEWgxQkG8dNMuK5+C2MzFWHC2gCVa/sCTaIh mINB5DgFECw+pGenAIWbq/ant+MDQxcFaxJeNamZqmWfH2SE50ljnoCt5WDkZMFN/y zSsFGUWBnPo7WzVzFj57OnJKTLZv8v06II8J4E2+FMu/J0lzw0cg8/Um5wKRhTuiBz M1a9kePx9hC6/XnF66pTT3tDmfydVWOZ+PUuN61Pd1nQtUDi8l6wozX8HGFWMhSLig QS2F5MDwxfui88OZl1d4xhMuIeMffwSLM7NnRPkICdlmFaTyYVH5nOaWhDuFI01iqL PEjExdKRm1jxQ== Date: Thu, 25 May 2023 23:25:37 +0300 From: Mike Rapoport To: Vishal Moola Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 05/34] mm: add utility functions for ptdesc Message-ID: <20230525202537.GA4967@kernel.org> References: <20230501192829.17086-1-vishal.moola@gmail.com> <20230501192829.17086-6-vishal.moola@gmail.com> <20230525090956.GX4967@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: A3831160008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: jboiycs8kqg9p9dhypp8hnyrj4g46ony X-HE-Tag: 1685046363-387660 X-HE-Meta: U2FsdGVkX1+kgIXT0o2bc70bvJTakl7UIybXhdU77XOYkFqgGTjQTNfF/UBg9r5YLHXbwtV//pAldn3gsMtHLPrKAvuQdFmtyayGfekSXeWziHQglmhe4W2N1Ou3AD/0r9Lifxw7xoaDvAzASCD/sOMy3UlmVgB1BIyLaSzqs4ty7nOp3he0O+Axc0eeY+g4IaTIxYGQ3w9yAcGw0o6xKK8eUt/+ZOvqaJfr+7ux2D999+4Min38b+SqAj+5WZe3qBEZgkEquLFX7eIEGH81cycAojEfwYBiZ+Et8m+KXiAvo1/R4phHzVlCgaJURAq5X4I2QgfOpG0TVGth1Fn2bzWUz0n45G6RDEu9v088VAgi1CB+T+9HDd2QkX74Lb9rSwGc7od0hA254Tn0cA43ZHggx1RMuXRtKN5JlfbrP/tc7AUiBItl+e0A1fdalj2Gc7bkdviELcpUoff1TYUQMtC/tlMUcIXKvcRfHpDJHIf2w27ICjCVUvgo4weeAQWCwDNinQOi7ZIY5cZxvcio6iYPkOwd89kAffDO5tnhDx0RFfzczUwKPOZi4iFI1i+iMvcUrw/AOez4kFroOj0EYM5PN5L0OgNWVFMqf73WALT63Ej0A18KGtzdWmju2viNEadu2JWhk7XeRkqIbgMkTNWc+8bFJ3ThCyRdMa6zE7+myulBrQobv7wK4NoZAQxgbsLcA/zVTKDoHVNYlnJlXzyi3frC52LNHoPQ48Pjux7x/hGvLyQ4Pc8NcjDXe6AJTKcyG7MCK5qb9JVXCySNFZ9N9fBBnCGtCUr+waekw0PAJxlX9IsYv0mAc9Rb9IsdR1hSNSrKqeY77OKVKZz7/mXwkqFpVRioxkeco3kvrdlyd+D7YKvHokdpGfeumezCxowwaTTOczzVLLq0AecIY7Rhz+vP/c+dIh3f+HEIQixA422JyBaZf098FSfHTs+GV2BkmQo9AUnaciSuX+u CqyAdj3T W8D1Mgb9ZHsMKUsFJSNLqjKpbKy5QHYnEp3UJLvM/E+2vLxlLsdx9KU9EyoHpM86hlGfKMM+wcuk1wkr+4Az+FH4Rmy7IulFpN9IDZPs6anoQTLP1ZIxShOER1NTHZjC1fcOMTFCnW00PyOOeZrbeJY1o7bHLBFLaqhI1NasqUCWCkXpi26PqI11YmeLugJAwp8D4JbliZnAMe46kaJMQYLQbRfNGFlCb+F7FfALIlHlQHn6x2bTpWJTofjO5qMwv0MBiJmBxie3T9q+vIYvgo6Bv06/ntLNPTNL8I0zJBJUmQD8GOZ6JfctODSB8Mh+QsJh0R6URb4+WB69R+SWx9VIcHLkGe+m03FQeYJNWRdSEtdde9mU42MNMHqww5IE6p3Kpzj/Q34Xzth5jPfIdnUNvY3J0584EZt/i+ol4oeVApXI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 11:04:28AM -0700, Vishal Moola wrote: > On Thu, May 25, 2023 at 2:10 AM Mike Rapoport wrote: > > > + > > > +static inline struct ptdesc *ptdesc_alloc(gfp_t gfp, unsigned int order) > > > +{ > > > + struct page *page = alloc_pages(gfp | __GFP_COMP, order); > > > + > > > + return page_ptdesc(page); > > > +} > > > + > > > +static inline void ptdesc_free(struct ptdesc *pt) > > > +{ > > > + struct page *page = ptdesc_page(pt); > > > + > > > + __free_pages(page, compound_order(page)); > > > +} > > > > The ptdesc_{alloc,free} API does not sound right to me. The name > > ptdesc_alloc() implies the allocation of the ptdesc itself, rather than > > allocation of page table page. The same goes for free. > > I'm not sure I see the difference. Could you elaborate? I read ptdesc_alloc() as "allocate a ptdesc" rather than as "allocate a page for page table and return ptdesc pointing to that page". Seems very confusing to me already and it will be even more confusion when we'll start allocating actual ptdescs. -- Sincerely yours, Mike.