From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E966FC7EE45 for ; Thu, 25 May 2023 20:20:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 538AC900005; Thu, 25 May 2023 16:20:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C035900002; Thu, 25 May 2023 16:20:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3636F900005; Thu, 25 May 2023 16:20:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 26649900002 for ; Thu, 25 May 2023 16:20:40 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E25E6C0265 for ; Thu, 25 May 2023 20:20:39 +0000 (UTC) X-FDA: 80829895398.11.9FD72EC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 4643E1C0015 for ; Thu, 25 May 2023 20:20:36 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oiC2XGhN; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685046038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X3MI+Fbff7tI82azeyixgPJmS3HoFTEYL6Fue6YzgmM=; b=PGbjkHp2+qj0hgGOpFP7blTAJQTmtm1iSt5FFCjNE07ptvbV/2kmlJh+Z6GEKaLgPLEV5u 3pHS3jdChlaImVQ9Sam0/zZRAR6tSUjyaChJjxOkC9CvgEsQxfyqCbF/IkQ4P6YMqoSJXF 9onxSQOl8lQgv3wVpS5XwqRH6HuyToc= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oiC2XGhN; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685046038; a=rsa-sha256; cv=none; b=BUJZvHzXT3eh0xsH1j8f10fahUfwKS05H4lvZwtODJxrwy/V0T9HNDbc1t9cZ921UrpIll YUvpdEK+RXMCqCwoknBc7d+h9PLSsUMJkKgJGuYaOQrM2ULzVQVmNzy0l9KQQ+nQNVcFRg cWaxPGdQKJlWqqOpfKEvOTqKZSwnjEQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DE92864A34; Thu, 25 May 2023 20:20:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D613BC433D2; Thu, 25 May 2023 20:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685046036; bh=TRdhRXxXUIYfs640uIn+I4Rf6UAXCv8idpkcYdsSebM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oiC2XGhNWUAmWE7pr8r3QtJ9JQsEo/jXvve3lXs2r5Y+W4R2mTSVXer6rhbIqd0H3 uoSQkJ728HLdXkJmf2eWWiJHTRm/fGQOsi2eZMGN8iMwau2U+ioJb0W4RoKYGYtykh z9scTeHJfdOUnqeX313qP2xIMkwidI5DxymtOtruiJkZ/HiGGdvi3+NdefCU8HC/4L yVF6ukcziPPo5ghUZkvreoJAGRzTQdLIctyd1RS1O+YIm3/yAJVKFl1SAT+U6nvVPE TUmcZj1oUZgh7b4Odb9/HzteZyqvh1+JrTl0ADJm08qL98dpyZZ8OeR78PQJMngFPN 0x/EvMWBkU0Qw== Date: Thu, 25 May 2023 23:20:11 +0300 From: Mike Rapoport To: Vishal Moola Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 01/34] mm: Add PAGE_TYPE_OP folio functions Message-ID: <20230525202011.GZ4967@kernel.org> References: <20230501192829.17086-1-vishal.moola@gmail.com> <20230501192829.17086-2-vishal.moola@gmail.com> <20230525085555.GV4967@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4643E1C0015 X-Stat-Signature: bh3heaosbobzsfywz4tunek7pxoqksk7 X-Rspam-User: X-HE-Tag: 1685046036-1782 X-HE-Meta: U2FsdGVkX1+Xp4/QkrDFPtZMRGsDwUbzF9CnaX4hfRDUOnwsnhlockxZFmsunUnD0VmRbmEC8GNaYzaMObua3qeIHCb8umQn+N/5thiLY2aakgjxoc0vxdoYeiGGfAxnNX5XqKSnOIqq0yMhrk8omlcp2y8xLbhDGbIYExcBE1Es9G7nYEPLW96LX/EseRVeX6JqkOYuIxz6FxvuPiS7Fb0yjp9ZUbo1kSz+t9lXHr6jQsPOZi4FnbKm1XGX7EAHrxg+UJQH8il0/vFtxJuXL5gpKixv953fEGQlx1ZweQOqNhRyKVQ4l3/YzRRysy86It6hMV72gsz1TC94ew8KqzG1JZBsJNGz1U85MN6S+D3XzTIAd9fN5cQE64wqhxb5QiqG8496wv78KoyRsrsvWrRT3ai3/mS890R3Loc5xn47msA889u7mYo85yPgdwpwiqkn3+pJq/jxoZleOi1l+eVvFXQmLSdxnoy/i2TbkI0TyOZz//T11hg9tu1pND7w4LTGi+EMbXok+xhMWqkTd3qJa4Od80QXBphJUgZQGRcWkWZ+3gYRYekqjldvcxNbMoOzG6cfeIiBpPNn3R7r+CnUAFM02V8SyFKnl5qPvAUQ59+2UIjx21A+fpy7aaGXwBdY9FtMHLLPc+An4bl3ByRZm68x7GLfv8Ey9/Uc2YNVINecUnev91UahMo9AXUbrlchomdYydKEUW4pDjM/7yYTR6xnF0p+beWGtvyQqOiy6ovKqUyXVEhxHjtlXZKc5iRDhr4SEAhC2+egiDwpAxpbwASXGP1vMZ8JM49Tck7Z5D3jEd7zeN6PjzLwEzktfXcLJ7M9CD868KVLayIa0ldtKSrMKLS2KmFMKTztDTvDjKD1zGp23urCjp+HfxF9yoXW7cr5x39k0F9Peag1hVRDI6pI5vcn7lm9sPCrUWE1LaekHUjAQYBUMD/Ld+OaY/CWUmAIwJ+RoGILrdl tHpWvIeA Tih8sKQ1Ilrp27JRLUQpnrWlSDkpJK8yttBzGZNSI5e9o4WxMncDCdvtiu8+LDu2dWyFCKKQx9EUssuZo1GMInCHszs3jufhA5E4sCKkE1Fe7hEE9vt/Fp8QZnC1C9OTUSU+yZWhyYYES2PIfH9jLkHnAgr+VbosLYnvs/qewleVZ31ZjP7WF8MmTnkV1pWmR1tBISQHI3G7MydeYzC/G55HM01sXRcIHYE5GUeiVKyccmE8Ot58umox9Ua9202RZQ3F5ztGu9yeW4Fz4aFtFF/QFp5OcVGjd8XE/1MHyX4+d1OJlPBdLU6/d6Ldyve9OEzsmrhp7Vtf+IlfagVW7AskmAMdN0yjZPu6AjbQULnYstL96MfidpVOQ20Kjatk5Y4oLZ1lrwAEQAaxIVeRPnfIDjuDdBZ7WyqKLd5uG61LEOF2hgU7scXrIo2TmgEWHROtRwvJQ+qlytlbojswiY5jqCUtdrgEyysLOJ0ptRlm+mg9925pOl4W3jA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 10:00:23AM -0700, Vishal Moola wrote: > On Thu, May 25, 2023 at 1:56 AM Mike Rapoport wrote: > > > > Hi, > > > > On Mon, May 01, 2023 at 12:27:56PM -0700, Vishal Moola (Oracle) wrote: > > > No folio equivalents for page type operations have been defined, so > > > define them for later folio conversions. > > > > Can you please elaborate why would we need folios for page table descriptors? > > Thanks for the review! > > These macros are for callers that care about the page type, i.e. Table and > Buddy. Aside from accounting for those cases, the page tables don't use folios. > These are more for the cleanliness of those callers. But why using folio APIs for PageType will be cleaner than using page APIs? Do you have an example? -- Sincerely yours, Mike.