From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 409A5C77B7E for ; Thu, 25 May 2023 10:09:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B76BE6B0078; Thu, 25 May 2023 06:09:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B25F8900003; Thu, 25 May 2023 06:09:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3BD5900002; Thu, 25 May 2023 06:09:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 984C16B0078 for ; Thu, 25 May 2023 06:09:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6B57B140B14 for ; Thu, 25 May 2023 10:09:54 +0000 (UTC) X-FDA: 80828356308.20.B91F68A Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf17.hostedemail.com (Postfix) with ESMTP id 95B0140014 for ; Thu, 25 May 2023 10:09:52 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685009392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IUR/eF3fmCh6yLsrTi60POyjHyPORNO396GBCktNTE8=; b=XTdUyGm0HBmhgEEOhpzTObnqEB/wqhmTJLlj3WrdEbu68hZwTlhHzRCYGy6zByhHQiQg9c lTJAbMGg0PsZ+ZyNBKJr5Yd/s6PoUE+iYYEt45dCokM6D5kf7DArkxYBBC7TAPb+1Q6pKB svUdrgDIS6mXHfUQaCVAU10qC3yZVlo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685009392; a=rsa-sha256; cv=none; b=DuZfEV0sy3DefsKL3txWsr+lRjAaYSUGPxpQpoEiJRpo2JgYv412depAuwktWoeOLe80CN oCqBI6E2YHdW6a/LKw0HVvzAz8MhuJFMRG9Vaj3ZzCnn/fJKsRp2pCi3H2XWV8PM7IetBk 6T+WxDymAkGFYek0F9OewipwRwqX7hk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id 3423B68AFE; Thu, 25 May 2023 12:09:48 +0200 (CEST) Date: Thu, 25 May 2023 12:09:47 +0200 From: Christoph Hellwig To: Miklos Szeredi Cc: Christoph Hellwig , Matthew Wilcox , Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Damien Le Moal , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 10/11] fuse: update ki_pos in fuse_perform_write Message-ID: <20230525100947.GB30242@lst.de> References: <20230524063810.1595778-1-hch@lst.de> <20230524063810.1595778-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: x3zq7cf8duymu7pmyb5aix4eng9nwh53 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 95B0140014 X-Rspam-User: X-HE-Tag: 1685009392-734755 X-HE-Meta: U2FsdGVkX18EGYDnX3NyKHjIOGtwyg/gzLY5DCF8UoCoyq0wO/FrgYnL5MFDFiS7bIuBm6m40YFg22e5yINssY/LveBTPXZhZfsl5M4jN6tBLuNyoX6bJWRVtfpK3vTByDZxwkRyX/3lsOEw1ayRgQX6078XO7UymF7Z8/RVCrbl8KM0GKamtN5tXeVCxr7nAkY5zR/KlSny4q9Vz00QfqnPu4hPQXnLskmkyJ9/yRKW/F/o1e/UpGZFfaE6stDGF6+KrGNmtC3Uzr3RWJI0YaUXLYtx4xdS9+hmiRj6jW61XnmMTwIzOpqZALd8XgjkrRfAy0IJrO2nn27WN4oFFsipwNYSXFVkLXwa88p2TvyJMeijWgggZfl1a7eusgGNp7TbE9aVoCX3DmQqZlvXQtfNJyCSodiasXx5A6qvtQJ0FAJ6llrRfhYsz3V8luo9Wo94C6RqzDK5ybbeL8Qeayoouc2wsSWaPfVUnp8dkN6cstl9XutXNiok0WfeJX07KvXvGg8Z+qjXjTxkhQJnKGq6do5RIo08wlzYX4z5W7nRwavvbRNHG4dvVh88PGfp5xiz/k03MgiJV1Wdo03MPOfX0Au/KbnRbNHBMWmJg448uy9Lk1zrMR5fNzqZqUbj79PtE5fI9A/ZqJg4N4rbx9kVmZhaF1Frfym/EoxSHMjiDRsHFqeQsCwSiOnD9KEYBqJ6trubM8DMZyJi4Th0BBWZkAF43qcFdZJcAxOVQVFYvZDgkuDuUPORtmttTU0vhDvRw9MO+slgBx/GCMlouuNA3YxvvX/XovLNQsCaG8WnwYLEeikYP4RRXSegjEL/ABrsTApE+EjYEIC+nVIe64ibt6ULjEvfGBo6+mXDscbEakEeCH2SKqR6GEmx3horI5H5X88DOOl2E5SbfkNDC9HhYWwnePrHEoyu/MeXrUvCfy5z5UxN1ADqt9jquLL534Hh/J8RfB3K/jGK7/7 hUkjGCc/ qSbjrV+owt5anKwmfWI2XVhvHaYhUvnVF6iBet9e4laUQD3cV3nEDMUTylyLZOqbocgcXD2a2bNKx2zHJ3BUyET0WyWQ3YbHQ8f9DhnmiThNzOqo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 24, 2023 at 09:07:22AM +0200, Miklos Szeredi wrote: > > - endbyte = pos + written_buffered - 1; > > + endbyte = iocb->ki_pos + written_buffered - 1; > > Wrong endpos. > > > > > - err = filemap_write_and_wait_range(file->f_mapping, pos, > > + err = filemap_write_and_wait_range(file->f_mapping, > > + iocb->ki_pos, > > Wrong startpos. Yeah, fixed for the next version.