From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF0A2C77B7A for ; Thu, 25 May 2023 09:19:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34B5D900003; Thu, 25 May 2023 05:19:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FB3E900002; Thu, 25 May 2023 05:19:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C453900003; Thu, 25 May 2023 05:19:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0CAFB900002 for ; Thu, 25 May 2023 05:19:30 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B3274AE4C4 for ; Thu, 25 May 2023 09:19:29 +0000 (UTC) X-FDA: 80828229258.02.F624DB9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 0ECDAC0003 for ; Thu, 25 May 2023 09:19:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=foE41UqP; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685006368; a=rsa-sha256; cv=none; b=SnTP2R/KKYGQXQBnKBgbdfxYYFnAHwHgR9A7pacxuEp3xV+El7x6cBz1zavMHKpKkhoSLA dcWx+1tUPss14iz6uIWtmEZjIr70aN5l/GUp0gBdVpC6GRwTKkljhVabkFixD99vbTAs1l 0mqnvHSTSAQgdXVWIZ5Of2pvB3TkZN8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=foE41UqP; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685006368; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P9OEYB0AtAOLlMcvUfkpsRlDKXPLe6xWe7lDPfQ2YNM=; b=D/IzftoDFFfBusKldvXLT3HAiKcLbdcdkqDKpqgHhDoaFiqjIrFti3FI0bdEFwn5cfWLTi cx9I8aPg1/mlz+c5DztB07K94BYkeJvQtnZNnXp5krTXjAfdUDHJGQjsJgw8xEe7wszgKr n1PJzHAXER/laSrZBU1+kkaDLJiRz3M= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0FA426442A; Thu, 25 May 2023 09:19:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3CF9C433EF; Thu, 25 May 2023 09:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685006366; bh=wqsrR+VLdLpuPAmDdXqCVY2XwnsXyfpXvlaNwL8b95Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=foE41UqPH1HgRiXHDcvmNVSgga8+6+movhrIvHcP0lKkim5d2C0CveXiAkrsugwUY mTMqHgjGefxYEA1DbMZBeEKmAQcDqRXgChs6yPJ6RFCubSjjaqUfXH5DibAVcYpUBA aCcKgzmG5mhVSa4fQNmh2lbUtoTD+weF0ODUHN0azy9cnLxTNG6czawfKdDGiZ3h9+ eQhVfl9VDk2zYUu2V/zd6ljbuCqaKQw9PEhJG6TAu5DceAsH/0TRlb4M7Mib7O0vr6 Y2yg35as+E26Oh74LjFv8mXxr+pdJYlNpysggvOKmpyB8i+xjdzE7MqNjdH/FF5KDP bMNE7SNyaBLAA== Date: Thu, 25 May 2023 12:19:00 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 13/34] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor} Message-ID: <20230525091900.GY4967@kernel.org> References: <20230501192829.17086-1-vishal.moola@gmail.com> <20230501192829.17086-14-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230501192829.17086-14-vishal.moola@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0ECDAC0003 X-Stat-Signature: 7jghkamuahdott6j9wk1f8e5jk3hfr31 X-HE-Tag: 1685006367-406958 X-HE-Meta: U2FsdGVkX1/2kk2x7l6OVHKh3ux1ZdhPaDnKDvLwZ6XD4b6dp3S78pr/KT4KOw7VnpwlGA3ALWFKr7MeiHIdHlw3HdQOq+FLRmUgKNm0Veyc8nIH1qN3fYULJGWeBSt/K88TtroOzAcrkSXPe2WrT23fIhK207VmkHlZ1LaD9MY66yIjoH0okfP2gvCMP1syBooAlJ0LTU43QWMT/WZxyNWBXvpU42BrOjsV011pOMY7/lssKDeakD0M5BXcYqkGS3zbwHHs/n8sp84OecIiTkN9BUrAmm15XPhF6u2NYix2UpxtK+bSyjKiUiF8tItX9IfRVJnhsmwFw6ZwGfYZOqKm3DKxwhHi424w3eQBqQ5YEdNDmxemsLzx4spR4sUmvaCfUFDSmARkK9TUOerh4fkSgWh1SQ9fiBIw8TGnGT3NSEZc++AqPy8O3p1RTS9IXmGufsCDx+9JawRdY/iQO+liGznz1ROrbY/tZyACfbFbUriOniNK5PxhjrKTWMnUwQbcDRgtWunHti3+VBsx4I6N4rTqQ9ojOWBEAk1jYWnUd6RGsHxIP03jYewFyYgdoVC4n1HQhYzJ9WUsrq+cwbB2VVJIoq+2OMm58RsiECqUeFdniD/sFITJcND9fX176Uo85zBvHBEclUozB7Ff2KDCD4BYUY4tHxKc+JP5KCDRQvMqqnpx2QuVjVaOHjPCFbTct5HRwccoWKpLbjps18WZUH3/UkYlkiwdv5h4lBT3ZZ3aCNEVE5ixj2OxzNx+Ye6o9t2BVUXue/CXMKtcMiXMwu631fwzHjGmfu1dVrKprwk0dP77S8RK45vcyAqGyy9P5VsJ0yDGsiEhLZzsa82np+qJmdN2ze+JhAe5gIw0rPjmCjzOjdafYh+gYyh07oodzNCAwcSuBgLNClcVl1olc7NE89VH2/NC3/DAj0Hy/Ergtz4fMTqYbvMJhpaXiFV5qTXIn5Wr5+U/sBs KhJO2hLR QMcu53ySj6yNu2Z7M6fHsBu0OdIzGkW5lZCW48c1Wm6klplP1Ws/BIjhWiSZBgddGnqp81uJy/TXAQ7RHGn5tBm6gPkyyc5Ekt+QCLleFPViLebrEVP9MQiiUkDQsdakq/rdkNks465w6Zf+uTF+bbLgduXorEQA2f/+g5rLe9mKAM/Kdr43t+RkgpFHX+MllQqJyUov5ldHyEXaZfvDjUfe4aRyaqxQ7FxBgCPT7fPq5yduXzI2R5yMfjYk+49cKJlWEx0qdMVZu3rl3Csv80HBIKdpnKJJ1D8YtaF7OQAL2tD0IOgpKAHBvn9kr8de604Gk5T2HQavhS8Z+aOg3ZX++ECXkCTCK5PzifiV6kTeovMFYaagzhSQ8aEIMFpq5NfUdtDXPpVPNhOuUMxD10ejECJ1whEv0AXFWXOzyH/zxt1D2YQ6tUTOrBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 01, 2023 at 12:28:08PM -0700, Vishal Moola (Oracle) wrote: > Creates ptdesc_pte_ctor(), ptdesc_pmd_ctor(), ptdesc_pte_dtor(), and > ptdesc_pmd_dtor() and make the original pgtable constructor/destructors > wrappers. I think pgtable_pXY_ctor/dtor names would be better. > Signed-off-by: Vishal Moola (Oracle) > --- > include/linux/mm.h | 56 ++++++++++++++++++++++++++++++++++------------ > 1 file changed, 42 insertions(+), 14 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 58c911341a33..dc61aeca9077 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2847,20 +2847,34 @@ static inline bool ptlock_init(struct ptdesc *ptdesc) { return true; } > static inline void ptlock_free(struct ptdesc *ptdesc) {} > #endif /* USE_SPLIT_PTE_PTLOCKS */ > > -static inline bool pgtable_pte_page_ctor(struct page *page) > +static inline bool ptdesc_pte_ctor(struct ptdesc *ptdesc) > { > - if (!ptlock_init(page_ptdesc(page))) > + struct folio *folio = ptdesc_folio(ptdesc); > + > + if (!ptlock_init(ptdesc)) > return false; > - __SetPageTable(page); > - inc_lruvec_page_state(page, NR_PAGETABLE); > + __folio_set_table(folio); > + lruvec_stat_add_folio(folio, NR_PAGETABLE); > return true; > } > > +static inline bool pgtable_pte_page_ctor(struct page *page) > +{ > + return ptdesc_pte_ctor(page_ptdesc(page)); > +} > + > +static inline void ptdesc_pte_dtor(struct ptdesc *ptdesc) > +{ > + struct folio *folio = ptdesc_folio(ptdesc); > + > + ptlock_free(ptdesc); > + __folio_clear_table(folio); > + lruvec_stat_sub_folio(folio, NR_PAGETABLE); > +} > + > static inline void pgtable_pte_page_dtor(struct page *page) > { > - ptlock_free(page_ptdesc(page)); > - __ClearPageTable(page); > - dec_lruvec_page_state(page, NR_PAGETABLE); > + ptdesc_pte_dtor(page_ptdesc(page)); > } > > #define pte_offset_map_lock(mm, pmd, address, ptlp) \ > @@ -2942,20 +2956,34 @@ static inline spinlock_t *pmd_lock(struct mm_struct *mm, pmd_t *pmd) > return ptl; > } > > -static inline bool pgtable_pmd_page_ctor(struct page *page) > +static inline bool ptdesc_pmd_ctor(struct ptdesc *ptdesc) > { > - if (!pmd_ptlock_init(page_ptdesc(page))) > + struct folio *folio = ptdesc_folio(ptdesc); > + > + if (!pmd_ptlock_init(ptdesc)) > return false; > - __SetPageTable(page); > - inc_lruvec_page_state(page, NR_PAGETABLE); > + __folio_set_table(folio); > + lruvec_stat_add_folio(folio, NR_PAGETABLE); > return true; > } > > +static inline bool pgtable_pmd_page_ctor(struct page *page) > +{ > + return ptdesc_pmd_ctor(page_ptdesc(page)); > +} > + > +static inline void ptdesc_pmd_dtor(struct ptdesc *ptdesc) > +{ > + struct folio *folio = ptdesc_folio(ptdesc); > + > + pmd_ptlock_free(ptdesc); > + __folio_clear_table(folio); > + lruvec_stat_sub_folio(folio, NR_PAGETABLE); > +} > + > static inline void pgtable_pmd_page_dtor(struct page *page) > { > - pmd_ptlock_free(page_ptdesc(page)); > - __ClearPageTable(page); > - dec_lruvec_page_state(page, NR_PAGETABLE); > + ptdesc_pmd_dtor(page_ptdesc(page)); > } > > /* > -- > 2.39.2 > > -- Sincerely yours, Mike.