From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 421BCC77B7E for ; Thu, 25 May 2023 08:56:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2E5E900009; Thu, 25 May 2023 04:56:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDDDC900002; Thu, 25 May 2023 04:56:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8056900009; Thu, 25 May 2023 04:56:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 960D7900002 for ; Thu, 25 May 2023 04:56:25 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6412CC0AAB for ; Thu, 25 May 2023 08:56:25 +0000 (UTC) X-FDA: 80828171130.14.F841799 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 5E48240018 for ; Thu, 25 May 2023 08:56:23 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mRtUeUA+; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685004983; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UKT68wtPcKeb5KwSH0TRslDxXMXNPd3gGglySBifsfk=; b=QvrT+V/FkL2BU5a/H19izEvbXqK6eoHL8jTFZQ5fpdneoCzeRBzpbKndsUZBFEb6Uow+Ld JzcYjqFu0NFKKfW/eiDclxdeodMKFLc5BlQiMc+SFSPOBA1eEE7pROJjpTvvA8uRtrnYSA CYxWZzaxymBf3u150B7+v+Vapt7mxv0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mRtUeUA+; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685004983; a=rsa-sha256; cv=none; b=svCh++QmjNNJ3NTT7o4aNdgWfM2z/mf1L1Ac6UJxwHGpJQnxo/sTBpkEpXjGuJc7ANUw82 kZykQIUNS5Sbim1uMqCfxY+SnXLBt6t1nbW5J0dJWv2KtmKskz5tQ6y8zxY9+XFfEnH1f9 Rcc0xITKCQXEpYgq0EdSoh/O8vQ6tcI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 443A86441D; Thu, 25 May 2023 08:56:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9425AC433EF; Thu, 25 May 2023 08:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685004981; bh=T3x6HsAO3RQbrXA8lAmGWzhIEFxQo3e/SuF/zmio4Hs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mRtUeUA+TIvgOPBLeDE0LEeluR6Lkzocki1ce4LxvGW3Kh74OsnmFoUFRRmQEOqgY vPbs8UllpBsHYQNETyRPKHNQXbkjzvcZ/qcNMJMO2YSn7oQ9dFwS8Ece6KmReDjGKv UHsfvGg5kn0tsbjmZAqeTwYppOTlzTxEsz6d+ZO+0GcrxaOJ0wF3N2ge6+B4EiqPJP Rr14bkavs3kxuqVnqdy8wSuE2VMYBsI0nPEtl+gq6jIzwj54Hlj3QoMxeOG7OsIhLt Fod2UUbjMqcZpiBjbvghJGsfjbRDVycHZQ/GoUx1cUGXfXrx/0id06caAMVPKwYBaI blTpXwhMXt6qg== Date: Thu, 25 May 2023 11:55:55 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 01/34] mm: Add PAGE_TYPE_OP folio functions Message-ID: <20230525085555.GV4967@kernel.org> References: <20230501192829.17086-1-vishal.moola@gmail.com> <20230501192829.17086-2-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230501192829.17086-2-vishal.moola@gmail.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5E48240018 X-Stat-Signature: odda5gqo13usd8sneoudku3gd5exw4u8 X-Rspam-User: X-HE-Tag: 1685004983-665233 X-HE-Meta: U2FsdGVkX19hFK3qff166CxQxVUpEWMmj8A9AhIBTz5k5C+5djVJz2H+az1qO4PVIHFxeV2FCEkp8tdf29uf5QskCoynAysJbtutPylS5JXv/3NHBezokC0JIUbW4KUoZvvWFMm/BO/MbN9JWvlNLhsLTeZgxE0Hxj1wEFPvJzZ1r6dWj/oWAp1xfLTjBYkLZJ/SxtGwhGrrqat6I/awdMciQAd24vgxxKFx2AphmrCQbqbG7bj+J7k30WPNsm04zYB7tkTV0bXTnlUiuKFNQyW7F1NmO91hvooBhgnlTX5UUzB0V8TqVvNgxUd+dUBNeEO470AV/5CYao8ao8bfQZDrNV4EWioYOhsmCWoQ/e7DKJJJu0g9WeF8YfiOT0SK9UXUabpHaolrxuLqbgG4rYK+CGRKdLyN+diALdk2wehXzWJ/lUGGMOCrkc25Kuqi+nx6p6SIJPv6JSUriJRZlLmrv5g+lFmxF4lPOzV4sT4n5FJW/CCbNn0votVQFpptQ+FESteswM61gBZ5mAnd7k7JsId5lyGGiLduTJt68EYZAEeOfqSwLvrRyBOAVFdlDa5//CLJcM2Ph4VUt4Fh4G7xVAvV1YYYjE274dR0A/YDoaJcm5Kddg9Pm9Z/FaAsj+uXvlIDyuUc3qa5pPla8ojQP1f8hfQTIVBAGO3ZbQ6BA8cIbrwGj7/9zP/gjMaZh2TRYj3asJa7jZnks9M5tP5O/gR5YtcWANXuRYEKOW/wqVk7wopZXb0FsLmmlqfYxGuI0X/OWlZdE3V8zZPlxVnGfW2EtjgYswCTLSpbW1Z/4y0P7qWTq2P7P83xMNXZqUvpw3WP09OkMAv5jDl7GLqv6XYKvRf58LESeCEmuKpeSO8iqiJTbJO1QT2Uwb+KFBxupMt6Esy5kCzyoL8l/0P1Aq3OoY3c/CLDYk8GZX7A7h8GEDadrECOUI/HCy2j5sLUXAWqFnBHnDWFB7W SWbqxTYp 5qggx38wgImCHEGkgsggptWjqNvQTo3/LrYU1fZNOVeIg74NkgUUhGjKC7UhLmihtUqpx2vB1fW+ewzPKW6QADwNB9EjP5GrLII4/Q58N8NliMtD+CjDi+Xz6I9vjO529Wd/xQfMKH2QZBhks1UuW4Q8NAKDmbm5pb4x/B5X++nCoK7H4D4yZRhUgIs0s+P0z9hOwVkT2D2PIz7MlGrNh1pHbx4nb17pRGhmMn+TIxy6QwCeGoja4oxX5pkUZXf2s6uxeO5h9ni9kUbO74SP8BNrnvzCg++drP80JzqEY+U1rjzLI5iSclHyXIKtCVGlX77gOFLlKPfYGNnM/c4Xq09nRX92U8Eu1+UOPM46yHaVd21KieqR09wVOITJY/1F5k777xTzaFrpb5rT/vWxKBHMHyUHw3j7JWwDMphptXCaf9+IVANGTbqKU0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On Mon, May 01, 2023 at 12:27:56PM -0700, Vishal Moola (Oracle) wrote: > No folio equivalents for page type operations have been defined, so > define them for later folio conversions. Can you please elaborate why would we need folios for page table descriptors? > Also changes the Page##uname macros to take in const struct page* since > we only read the memory here. > > Signed-off-by: Vishal Moola (Oracle) > --- > include/linux/page-flags.h | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 1c68d67b832f..607b495d1b57 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -902,6 +902,8 @@ static inline bool is_page_hwpoison(struct page *page) > > #define PageType(page, flag) \ > ((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) > +#define folio_test_type(folio, flag) \ > + ((folio->page.page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) > > static inline int page_type_has_type(unsigned int page_type) > { > @@ -914,20 +916,34 @@ static inline int page_has_type(struct page *page) > } > > #define PAGE_TYPE_OPS(uname, lname) \ > -static __always_inline int Page##uname(struct page *page) \ > +static __always_inline int Page##uname(const struct page *page) \ > { \ > return PageType(page, PG_##lname); \ > } \ > +static __always_inline int folio_test_##lname(const struct folio *folio)\ > +{ \ > + return folio_test_type(folio, PG_##lname); \ > +} \ > static __always_inline void __SetPage##uname(struct page *page) \ > { \ > VM_BUG_ON_PAGE(!PageType(page, 0), page); \ > page->page_type &= ~PG_##lname; \ > } \ > +static __always_inline void __folio_set_##lname(struct folio *folio) \ > +{ \ > + VM_BUG_ON_FOLIO(!folio_test_type(folio, 0), folio); \ > + folio->page.page_type &= ~PG_##lname; \ > +} \ > static __always_inline void __ClearPage##uname(struct page *page) \ > { \ > VM_BUG_ON_PAGE(!Page##uname(page), page); \ > page->page_type |= PG_##lname; \ > -} > +} \ > +static __always_inline void __folio_clear_##lname(struct folio *folio) \ > +{ \ > + VM_BUG_ON_FOLIO(!folio_test_##lname(folio), folio); \ > + folio->page.page_type |= PG_##lname; \ > +} \ > > /* > * PageBuddy() indicates that the page is free and in the buddy system > -- > 2.39.2 > > -- Sincerely yours, Mike.