From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C8BC77B7E for ; Thu, 25 May 2023 08:26:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C86F06B0074; Thu, 25 May 2023 04:26:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C10E6900003; Thu, 25 May 2023 04:26:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB238900002; Thu, 25 May 2023 04:26:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 97A206B0074 for ; Thu, 25 May 2023 04:26:48 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6609E160A44 for ; Thu, 25 May 2023 08:26:48 +0000 (UTC) X-FDA: 80828096496.02.2E420C7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id AE1E710001C for ; Thu, 25 May 2023 08:26:46 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Skq/px/L"; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685003206; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xx6P8FPtpaFx8DHks3gCM37QOEh/DSyfcKz3/OIio8E=; b=JCarKIcwooCVpd748D0lSeX7PTDi0b18kM9I/vtgpcB7Hl83C9YgXIsVLfijiyXBpEO/vR QM/qGZ/cOwppZIoHllJnPxTLVrf6D8XvEFqHJR0eE9RR3rRG+5oFE6hdp67bOtGj/uvlUC DDsdF4c1UH1ZFFgnazGg7BqOhtlPq+M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685003206; a=rsa-sha256; cv=none; b=dQJhKvsBhMjIroMtkBIb8hwaN2/bGQBryhaeLH6mms92z98dMrM70+h6m02m6H7eFQgsup TM1bspOYOS7IBk5lEAh4sP56os3aWs//SmydM9qsfq4u4tUZzsMVCGGk4NSGvUnuUBY74j DImkjz6dxfMmc71MnV+C6IbJnvQk6oo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Skq/px/L"; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A919A60FAA; Thu, 25 May 2023 08:26:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0ADAC433EF; Thu, 25 May 2023 08:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685003204; bh=G5OcWyr2B122xVxY4jWblz0GjpAgP1YgwoGovSGpD6Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Skq/px/LD9AWrEW21C+JiplzLT933iwefqVEE/ES4HQWqWRvI58QrCMTQna8tMjRh y9JFaZfEpRX1IHKqh1CFn4UyvylK6puq66sOkRvOCGoUzEeu546iXGzAhg+PwwsqBp YxDttTA2CcVeA4I9jSuxaUXnVY0/12H3cQS1CY2QhfosbhLiPWjYiwi115WBN6TrOU V+GGutoJIdL3iDw7jeSOh/DzpQQp+r7wM6TvseL9nbnQIjyFzaM45vbm4V4IS+S7RN 2vw52hFQqpLhf2v+4O3OFsMIobyk3IoxXJ7uJEVmOG13v+zVrkhezchKWaVgxi3P7f 2kGnRPKrKEaaw== Date: Thu, 25 May 2023 11:26:24 +0300 From: Mike Rapoport To: Haifeng Xu Cc: akpm@linux-foundation.org, mhocko@suse.com, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm/mm_init.c: do not calculate zone_start_pfn/zone_end_pfn in zone_absent_pages_in_node() Message-ID: <20230525082624.GU4967@kernel.org> References: <20230525040150.1588-3-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230525040150.1588-3-haifeng.xu@shopee.com> X-Stat-Signature: ozhnebddiyip87mii434wagmdjr71u1r X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AE1E710001C X-Rspam-User: X-HE-Tag: 1685003206-696334 X-HE-Meta: U2FsdGVkX1+Sgb1zNLcYrWj3zDy8YPrsY81qv+graiQLplT3D8LexmFRFuWXmFQpbOQtSWdiKFs3kMCUlYcvGNtNplE7mnro1LuT0Xa3zBoOc8cXnbEFZ4og2DtLQddnedPx7nItfUJ0elBpRKn7sUixOzbkqwi0IB7xJWeqBGT/iBGFb4i1ezSUNU2GtGwTc3lhP2zDAmXBGBYGQBy5VyxsEs1XiqKWE2iPMh5XZtsciPyBiHLvd38+1AbDeKmpVKXlqQvKepCEXmOdCSNq19l0fYDK1d+Z64DcaXs4S21WDTbVruOaXevLQ4HZY+IzanjN5TWpJkjNMyZeLpuUbLdeU/H4Y+sPU/Op311YQQWWfI+Vr+47DaMWuLpE0Ue0BI5yThYNUUSr/okOcgqU5vcSe+0F6FWmF/4k25tUZbaGFifwNk9ZB3TrX//T+BpAYt3bmSd/Q++1k/apoxwOobtGgWO3CaxaVFLFzbuKDPTmuNd+l6UfUAChFsGeVLQcmpY34RI+/G6qzwgLUha9b0IJtleqM/eOnnZ6FO8e/mb4DFoNohQbxsieNqQfTW7rAJX5MP3NeKixf9wKpWNxiyXK2ObgKbU2t+Xjrqb7eaGdpiPuubCH1VnMegiWtxa+WKJci1+lK9lSn7DK2EfzqhdGPU87G1S3bhMcMTMXJCyPes6No5uiaaeytQT6cGhVUzuG9B3a1/j3OaXQ0guH9UheFk3Ei8SBwjJ8FwvPI2KDu1kiuFpg72WseQKOD8xfOgoLXmnMWzU0U4jTNEEjezxKMI6/rmK3uafgt0duwCSZmM4pncXm68bB/fHBA0HwwVuVDM4/GsD6WeYk5oMaHMhHEapQrykb66oby1gsZCgUzlupJD8KxK2c3ePUmbkIKcukZWIuMl/63ZgYVsvByPjTHwQnzCv9nuPKqcP3X7iz/RHCQpIZORRDXHMkegyLrycUTpLJf48j09b7KiY 55G/gZDG ML9W+scQQrxp7TUtzMFD+o9g9neNWGsNugoD3r9RmjT3Ei+m050KbuROqOGYstosCtTKdBT15Je+jtSwTO2JipldiBM1lezuXUaXIWlWJon6a9P6zC04z8EtiUDYdiPZvPYQe7O1D322F9KYjYzBb5zvnamTKIqZAfCMXhgqMKZU/xBOAM31VF1pujvtV4Os7koAMdaYNMtWAuoM0W3Ob9UNMVOiwt8PIgeWGErcGwNmdWzTY1Gpnpgh6hhfxICnqxCfLA9f0+9UCwwAaLf1Bs6kpyrxOA9CEvCZpuXhMTe9PPcna+85Xtqd1zp4W5MTf/K0yosK9XDJr39CJ+iuD+OPOwjfFJ6yQpTCHnkceq/le75aZ5Sc8FkQZ6bo65jpYYOuz65javFAPnrU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 04:01:50AM +0000, Haifeng Xu wrote: > In calculate_node_totalpages(), zone_start_pfn/zone_end_pfn are > calculated in zone_spanned_pages_in_node(), so use them as parameters > instead of node_start_pfn/node_end_pfn and the duplicated calculation > process can de dropped. > > Signed-off-by: Haifeng Xu > --- > mm/mm_init.c | 35 ++++++++++++----------------------- > 1 file changed, 12 insertions(+), 23 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 898af4eb9ce2..88c4a9266e2a 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1166,23 +1166,11 @@ unsigned long __init absent_pages_in_range(unsigned long start_pfn, > /* Return the number of page frames in holes in a zone on a node */ > static unsigned long __init zone_absent_pages_in_node(int nid, > unsigned long zone_type, > - unsigned long node_start_pfn, > - unsigned long node_end_pfn) > + unsigned long zone_start_pfn, > + unsigned long zone_end_pfn) > { > - unsigned long zone_low = arch_zone_lowest_possible_pfn[zone_type]; > - unsigned long zone_high = arch_zone_highest_possible_pfn[zone_type]; > - unsigned long zone_start_pfn, zone_end_pfn; > unsigned long nr_absent; > > - if (!node_start_pfn && !node_end_pfn) > - return 0; > - > - zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high); > - zone_end_pfn = clamp(node_end_pfn, zone_low, zone_high); > - > - adjust_zone_range_for_zone_movable(nid, zone_type, > - node_start_pfn, node_end_pfn, > - &zone_start_pfn, &zone_end_pfn); > nr_absent = __absent_pages_in_range(nid, zone_start_pfn, zone_end_pfn); > > /* > @@ -1254,6 +1242,7 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat, > unsigned long node_end_pfn) > { > unsigned long realtotalpages = 0, totalpages = 0; > + int nid = pgdat->node_id; > enum zone_type i; > > for (i = 0; i < MAX_NR_ZONES; i++) { > @@ -1262,15 +1251,15 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat, > unsigned long spanned, absent; > unsigned long real_size; > > - spanned = zone_spanned_pages_in_node(pgdat->node_id, i, > - node_start_pfn, > - node_end_pfn, > - &zone_start_pfn, > - &zone_end_pfn); > + spanned = zone_spanned_pages_in_node(nid, i, > + node_start_pfn, > + node_end_pfn, > + &zone_start_pfn, > + &zone_end_pfn); Please remove unrelated whitespace changes. Also I don't see a strong need to replace pgdat->node_id with a local variable here and below. > if (spanned) { > - absent = zone_absent_pages_in_node(pgdat->node_id, i, > - node_start_pfn, > - node_end_pfn); > + absent = zone_absent_pages_in_node(nid, i, > + zone_start_pfn, > + zone_end_pfn); > real_size = spanned - absent; > zone->zone_start_pfn = zone_start_pfn; > } else { > @@ -1289,7 +1278,7 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat, > > pgdat->node_spanned_pages = totalpages; > pgdat->node_present_pages = realtotalpages; > - pr_debug("On node %d totalpages: %lu\n", pgdat->node_id, realtotalpages); > + pr_debug("On node %d totalpages: %lu\n", nid, realtotalpages); > } > > static unsigned long __init calc_memmap_size(unsigned long spanned_pages, > -- > 2.25.1 > > -- Sincerely yours, Mike.