From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A15BC77B7A for ; Thu, 25 May 2023 08:25:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20252900002; Thu, 25 May 2023 04:25:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B0436B0075; Thu, 25 May 2023 04:25:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A088900002; Thu, 25 May 2023 04:25:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EC8EE6B0074 for ; Thu, 25 May 2023 04:25:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B9E7F1607E0 for ; Thu, 25 May 2023 08:25:07 +0000 (UTC) X-FDA: 80828092254.20.03D416C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 1EEFEC0011 for ; Thu, 25 May 2023 08:25:05 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=V3o5NCJv; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685003106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=seF9cSUbTzK/Gr4zZ9DFqB+qh9yvRjJ94Eo0WuYDA3Y=; b=szLh+qxGsNsDu49wMuWfA8pYbV8AZQTOEayvgzZOBqjXHF1tXzl0d3NHRW1sBs/Q95T2gd ja8s/2PSl6SUTn62eTMR3t2a2ej8yhCe/QTf2VMcnsHis35YN1fgftDZbfAk4oBKc5NYP2 MEMLfMvyWWGbXLXkNFhY61Zt9ckGLGU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=V3o5NCJv; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685003106; a=rsa-sha256; cv=none; b=O6cW7VfLVpOlIghrgHNfjLEACSzlv65ee6enkBI2bBp2o0Frnqq+R/npBu20oC/6B31tbx piX1IsU6JJl2wYv7XyASAz0xMz2y7pBrz7nk2oLxwUVJsyC8QiiNZMnOrdB+qYtrXaUWIh LY6lV8chQ9RRqNen21EWyCdEYQgMgmE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0C9A563C3E; Thu, 25 May 2023 08:25:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7728C433D2; Thu, 25 May 2023 08:25:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685003104; bh=grNGwJfKWoBTpHT3Wmi+ZF/bEInd8peYBr4JARBqluI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V3o5NCJv7n+774JknAT+F+0rMRvBC6KmsOrVG4f08XgskuY4sSSiQi7M7cNRfTxXQ 5I6/akS+M3M7SP1DCY+34zoMT/xVgzoLV0+kGckVsZdDB9/+BUVtWkHMMN0rKTQ7mS W27f/A5CDV7sg5I0P7RDaL9UIWsHdn+DVwm+93nnd6MFwG/H3Q0R9Vx03TtgOjsacr LNA2Aad2GWcYq8TFWud+C7F8jdV9L6eVAVxbQgtapC/Fpf4ly/38ygoU+WE5AedTmX 9RCL5yidlze9IyNjv1rR/f61EpLLyQqz4stJmLjbOnspBIyJE+0EJVybRABtI37GaW +y5IXHjxX2vQQ== Date: Thu, 25 May 2023 11:24:44 +0300 From: Mike Rapoport To: Haifeng Xu Cc: akpm@linux-foundation.org, mhocko@suse.com, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm/mm_init.c: remove comments in zone_spanned_pages_in_node() and zone_absent_pages_in_node() Message-ID: <20230525082444.GT4967@kernel.org> References: <20230525040150.1588-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230525040150.1588-1-haifeng.xu@shopee.com> X-Rspamd-Queue-Id: 1EEFEC0011 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: dd9driezzk4ffcingp4jtfqh9rhoiouc X-HE-Tag: 1685003105-826349 X-HE-Meta: U2FsdGVkX19c5h4eiNXPq2dIvO+8l6siDpSOIeSbkTA6uMll4rCPCEnlTFIHwR2J8YIzs9smPXFCizKlSdaK/KniRq+5URWyiJW2S2zdhs58/EvN/fLg3hUXKSftOXMqWPsdlfjl7CPSQejRm9jD8056DhZKx6eLjIdMnK8GTJvLQqf8zMO1VnI+w2917Z+WepohjmgUEJpG2Mg4TyAQp1S3+5VDKbm50WiwO6kczCtK/9T9ws+BqL4rBhjL5DVdJkJSEyR1AeJGWcdZame6wY4Iy8WWOfYt/xXmoA1qNpAeIXBEHOmSY851e/3t/w+VrX7OSpsTbiLMYS5+3/61FWzeE9glZLYpGb6f5DTST2a+z4tH6yqfU5QzuIQPr08Ij6Hs4Ni2ikp0q/5HC0Hl8h3//uj4ceuoFudQx/XN7K78xkTSEy6BdfYS+A9kPv7TqrRiqEvLHFucOIk3n6O1Ea3ZQOVKYX0tHaBf2B7nR6DKSBIfAm7tPpZy4koiD5kk6CA68fGi3n96gXf9jQxGSb1Xf2ghfF+m1UO6q3cn9kMe2uuOl/Oy8+5GZ2a2zwRUIwTeLIPsHj+MzESh8ezDC2/1L6+FsiARQkTs+lLhgM86bnsIbQ9l7M3RGOLMGO+m2OnSaaemmuO+0thsiX5qcE+ExUgiD/E0BWsck8WGhvyVj7m2F6c5O0YzoUpI8nnBaXrZOZ8zXRNRFfOc/kIqtysu1yYMcpHuYQcITErhB4CPYGgm/oOtiex1v6KriCv7kNqs7BiNv+IhGwNhPapoBPoN1Exica3jPDl9Rqe8lt2rFMMOyPx2sAuvTCksLrlGkJODHCsVEneqkHHmI/P9s/U/G291oYG0NwyJ4d1nQxr+CIE/yWquDRE1XEncL1rTkA0kW9PEwzvA4ERBu8vu1Y+YCF+n+rprlrMeakgPw/s0azpZvI2ZXNfaJrWzI/lCreBJBsWUdbuiumgYnej 9lKYsoBD 68gvGVKE9cZT6qXo1Y6h3GBAvHDQiUWyuVCT6w/n1Ns2ktIRM48OFK36NkGi9EUuRthyayA90xgpLZ9KxcOEetYuaqH5y89lXa1lR4tXI99Et9qiiT9IA14RYQLaZsttX7viYOsyAvYAPJ5tGABx6jZ641+8AvXYM3GR+z5/y7vS5nqsGCFSPEQIFxo5i34iel/9QKHjxj3QE5gizV97hrDuJen8hNwt3pjmrdl71WJLuAu0sYW0Ugxkff8FgmRWgzmn4J1YWnobkPdg+Z8ZNfR+OPuHOT2/stw0UQLJJDPLgrWVel2IfX8kiUbIYcK2ttBvRBYQ1Z+PObME9V1Od7ifK9fjPzNGR8wWPGTzMODap1HAUwSE/Cki5IHMFBPE0Q1dM2+iJMSFMBE4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 04:01:48AM +0000, Haifeng Xu wrote: > Since commit 03e85f9d5f1f ("mm/page_alloc: Introduce free_area_init_core_hotplug"), > free_area_init_node() doesn't get called in hotplug path anymore, so > remove the comments related to it. > > Signed-off-by: Haifeng Xu > --- > mm/mm_init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 7f7f9c677854..cf55bba04b23 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1174,7 +1174,6 @@ static unsigned long __init zone_absent_pages_in_node(int nid, > unsigned long zone_start_pfn, zone_end_pfn; > unsigned long nr_absent; > > - /* When hotadd a new node from cpu_up(), the node should be empty */ > if (!node_start_pfn && !node_end_pfn) > return 0; I think it's better to call calculate_node_totalpages only if node actually has memory and for node with no memory we just need to make sure all the node and zone page counts are indeed set to 0. Then the condition here and in zone_spanned_pages_in_node() can be removed along with the comment and patch 2 won't be required at all. > @@ -1227,7 +1226,7 @@ static unsigned long __init zone_spanned_pages_in_node(int nid, > { > unsigned long zone_low = arch_zone_lowest_possible_pfn[zone_type]; > unsigned long zone_high = arch_zone_highest_possible_pfn[zone_type]; > - /* When hotadd a new node from cpu_up(), the node should be empty */ > + > if (!node_start_pfn && !node_end_pfn) > return 0; > > -- > 2.25.1 > > -- Sincerely yours, Mike.