From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31357C77B73 for ; Thu, 25 May 2023 01:21:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BCFE280002; Wed, 24 May 2023 21:21:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66D1C900002; Wed, 24 May 2023 21:21:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 534CE280002; Wed, 24 May 2023 21:21:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 429BB900002 for ; Wed, 24 May 2023 21:21:08 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F306F1C7438 for ; Thu, 25 May 2023 01:21:07 +0000 (UTC) X-FDA: 80827023774.27.3DB1829 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by imf18.hostedemail.com (Postfix) with ESMTP id DAE1A1C0003 for ; Thu, 25 May 2023 01:21:05 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=aM2MHGY4; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf18.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684977666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j98gJ4+KN81zlHrINZqrH05Pl+KjXomFxD3KB2ZcwUg=; b=PclEvl9paiZ6Cx50u+08AvqIh6z1xUqfSwXlGRFWp6vik1vZRe9tl91thWkTBdb6GeGhQs 6QPEjwnxGlBTzt4wVG5Qpe7SDr4ik/kfoTfC3D6SOmgOAgnIr0MN7MX6gNFDqwBgOaX+K7 W5C4/R18NQtw4N83syZtjJnhILXEhqk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=aM2MHGY4; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf18.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684977666; a=rsa-sha256; cv=none; b=nYGNpp/B6/GJu5i+HO9qi6mQDIF2575iWKA954cHlTDlFlY6ffGu4khTqSrsjNP6T2sI2F sOlMsU2cwD+YDXOBgONLJGksKbQnbFnfvwqKFwpDIgoWTMBi3sOJOhxZhP+IR36m9coOHK bNhngRbJxbcDGmhwWUvY8VCJYV+UUOI= Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-75b17298108so24624485a.0 for ; Wed, 24 May 2023 18:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1684977665; x=1687569665; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j98gJ4+KN81zlHrINZqrH05Pl+KjXomFxD3KB2ZcwUg=; b=aM2MHGY4xUTYKWMcoV1R2ROW5efcpmXigmAL+mMZ5XEnMx0rFxVwZKHGcFfPYyyt4C fgrmVpz11FsExkBVjSERPrjP/wh8NJ8MczWW9ITix0Db7wdihD4Ac3W9Mlx3hGIcY5TV eWQRaHpScNvFpMGTp8PaXSBqvklX5x18eHZyXR1L9T342LW4WcMfkmIGLFObi24tJs7s r0eLa8u0K8XpmMUwXl6S5cB/KijNkqetUl/um5sOvatWTu21sGkGtGRXB3jq44zaDkwf svBLbM/mdYZ5c5IYM34uw64uf1dbIgdjkcoAQJCLo/AQyVz0V8ojNZ34TAgKmo2ooHRX L9hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684977665; x=1687569665; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j98gJ4+KN81zlHrINZqrH05Pl+KjXomFxD3KB2ZcwUg=; b=KLc0rWedDhmTeN8GErNds2ws+WaAcp7bgOX/6kofaIaqGPmuELJ2jNYj4EqTBYNrl0 UbFiEkbQTC8WOuec3X0YMR1m0dnN+3rLGx0sLmzQoWozD4EaQB4RldW6L65ECLL/PR9n Y+/rcwiEuLo3C67QaXUklqlK60Vrrasv7e2lorfGHtsrDKczXMBnGXSlJ2d9+BpYn5yu lAhZc4VAhO65qgVsNMgiG8ZCFaxkT0VK25OnI0BrsGAkEgICBx4ZbAytPIcegYpbQCH5 CFHAVS12/BH5SDVHduxfJCOByW0Hbnk/9A1fuC3fJuTgsVPcuQfakP2xSXgSTLpj5Jkh On/Q== X-Gm-Message-State: AC+VfDxznxfTR34pq319vFITs5N9v4jsj8DTQ7wJuKbliUMb4D5tp4LX fZkAsP80Ee+KiKFPY+WvxxoM/g== X-Google-Smtp-Source: ACHHUZ6e38+gKVOV7QYsLseVpmGvLBi+8/rvohpxXpAcIjVmnxVHK7W7V7pTLM2gUdYJlDIVRMbk+A== X-Received: by 2002:a05:6214:124b:b0:623:8896:2d77 with SMTP id r11-20020a056214124b00b0062388962d77mr32062976qvv.41.1684977664722; Wed, 24 May 2023 18:21:04 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:8bb6]) by smtp.gmail.com with ESMTPSA id q5-20020a0cfa05000000b0061b73e331b2sm26089qvn.30.2023.05.24.18.21.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 18:21:04 -0700 (PDT) Date: Wed, 24 May 2023 21:21:03 -0400 From: Johannes Weiner To: "Lars R. Damerow" Cc: mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, tj@kernel.org, lizefan.x@bytedance.com, corbet@lwn.net, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/memcontrol: export memcg.swap watermark via sysfs for v2 memcg Message-ID: <20230525012103.GA24888@cmpxchg.org> References: <20230524181734.125696-1-lars@pixar.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230524181734.125696-1-lars@pixar.com> X-Rspamd-Queue-Id: DAE1A1C0003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: gf9hiitckhfxoc8p77u6ob65uhfrrcmf X-HE-Tag: 1684977665-295838 X-HE-Meta: U2FsdGVkX18raxR4XrzxCKGBkE32dzLlZp6S5ucNjFI3UFYMIOuhBcEotDGYB8UZQBFFdoNzVzuFXHL8C8+ObUCKbz4pMBr5tgPcc58sHw+EyKxhZoUwJpho1bQSzv4kqkvdISqKxmMlANNwwPOCC123k6mAFWefT5fPup97fOcrFHVH4iyTJdSmG0UP+Wy/B3Qz53raAiXkQ0keDTNN5SxyhgrjqBTnbfcoagHpZ8GuwC17S9udzdgJqdlzDMIbHSUFYsjKBfWcFaUW6OVZ9yZzZyFoSTuZVJurUbd9Lwuf6MogTXbmg5mQKkTAu4wpdXpHH+L1eZI04OkhF/wfkNlXULDgOe4Ug/bS8CdSSBAAMki/HzHwNK2T/TRJJkbnEoW4mDnJRlXE9t2Je9sHyRtOs9BblG2uJdxe8PJKetaxOGFXf6LiAkIH8Tc7mXDl2WwUkyiiFm/cfgwIQPu2Y87UIZ6C0gzlfX4X/6i64N7Jxg609g5HirYZgd/ysimp/81gRLvx43qYnpFgoJXPQlx0N8gAO6sq6eJtMIMxR+RSe/xZ417VgA8BApu6rXNUktZ+cU4m/m4qgI3nXQ7jvSI7HcOBTcih9qM1UVoexG8CGGzq10HAYwGHhUIsmql7d1pzwg1kY54O7ZfzsSCzRlzZLP5Tz6rn6msUrHGPdZLtc2+ZyJB+AMbEqHGrDFrgshaxuxk2evm6dPa3ib/vGZCWhw/Z+PCal8y+o8pPOSDekXPTR0Iey+ZhIt3OM6TpwkP1uwMFbTKAeAJmQsK/ijI69S0GfihOe17CyyQq3G8FvuCPtsXGwv+g3WT7kkcZPhVXvJ6IKM6xZl+VK23zPS3ESV3B+a3iehTZgHqbNQODD5tk15ArOEymygEmGcSuAkbBps8UKDdlCu1aipPCQrxaLDsu5265Suct+D4ifLb1tGBBGAfzwjxYs3wElDloTMCOk5ctaA7twx+6PYe COZoyRyf xOwofgyaulevyOG8LkUVo89l947UaLZC+B/3swFPkxYahwZwcodIoVxQOuL6gbFFBIoICGr2Um2YWTzH7/87F09fLRxC5Oiotrq0wcmkxZI3uw3wrw0Y8TNOODc7EZ9R8dwD7P9s1ATp1oFBAcJ4R71uCZ35MtJD2R1q+m0DGnerpIHmguNg7kusHTmq6br4yOGb0TLbj1x92blJO4gJ3p9b+gNh7Cb/ojnT9KXT8/naI+eErHQjN1uK6uEkTT6zDGDTKQ/1UGz4/5luZgDwPdH7LvFyP5LTe7lPwaBAVNv9hwemTS3n26c7ZXsO90g/IVdbTpnSCsN7LdB5vyBQ7OjherckbyjPFentYkzdIwadcIKP9nn3DFMurVDQWKwU//+YbRoQVfAhZ0IgaNsk+UMIREbo+0gpIqX4qwqMMgUOi6iQcv9JvopCDbszuIDBB6R5YCsleht32ooQs+SJOQ8RXCjZlaDhKwToENoZ7ui/yoaQ7vD6gaxbbOoL0m6DcQYrRrvch53PyQ7DMqoUcRanHvAn5AMZnf3WC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 24, 2023 at 11:17:33AM -0700, Lars R. Damerow wrote: > This patch is similar to commit 8e20d4b33266 ("mm/memcontrol: export > memcg->watermark via sysfs for v2 memcg"), but exports the swap counter's > watermark. > > We allocate jobs to our compute farm using heuristics determined by memory > and swap usage from previous jobs. Tracking the peak swap usage for new > jobs is important for determining when jobs are exceeding their expected > bounds, or when our baseline metrics are getting outdated. > > Our toolset was written to use the "memory.memsw.max_usage_in_bytes" file > in cgroups v1, and altering it to poll cgroups v2's "memory.swap.current" > would give less accurate results as well as add complication to the code. > Having this watermark exposed in sysfs is much preferred. > > Signed-off-by: Lars R. Damerow Looks good to me. Acked-by: Johannes Weiner