From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7237CC7EE2D for ; Wed, 24 May 2023 18:47:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E66F6B007B; Wed, 24 May 2023 14:47:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96F8E900003; Wed, 24 May 2023 14:47:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80FDA900002; Wed, 24 May 2023 14:47:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6DB8A6B007B for ; Wed, 24 May 2023 14:47:49 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 35FF4AD88C for ; Wed, 24 May 2023 18:47:49 +0000 (UTC) X-FDA: 80826032658.15.3A8FAA8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 735431C0017 for ; Wed, 24 May 2023 18:47:47 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eDhgWVlh; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684954067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AjkeprW05IZ5lG0a8BBuC8dCuC5yvd0rXiwTMGNYZPE=; b=1JH08L+tC6rvnNaMWGe+Oq9IMaIMgdFfcg5VSm9MjyLE8fOZ3Zg0jQEfY8oTBxcWD+FNYc p7fOEZDQnQ5eKLG8Vg2WV5zPfWsFw3YGaMnYzyORp9KeBeboL9v0hr93/qJONP8Scc/zcd CvvkSG4uD936Dm1GbjxkkpreIitUydE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eDhgWVlh; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684954067; a=rsa-sha256; cv=none; b=Fen6/EaTHfIfUb8SOpuLNHHx5NZ/c/HYkwM//EEeyjBdp4ti/d3eyuk09nRnj9kfrk7eiS uYhP4PJ3732scGzudW3B6Yb5KjqZLy/PR5CsYvfkow7LaA6nksPFJpTmlwVEJ4IlDAiIc1 /B278ByRwBFvIdqoW80YviZKDEIvkcI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C3C3E617A7; Wed, 24 May 2023 18:47:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DA8DC433D2; Wed, 24 May 2023 18:47:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684954064; bh=ktiLabnYKAG3KyFEF2Q6zpiOpHDgr/G8xrLKc5nzBjw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eDhgWVlhdFx2XOrl59CnlL8BCPXIMfC+H/ZrYgxlSTU/cxDxdzw6f8fj2mG+bCQi5 ud56NFMt0XN6a6loUJdqBOFEB+YJH7VJ40kjA+diqLGn7k5idmQDjfU+3Esf2Ul7RK 8nfAe0OIOMTzwV6i7qWZhzy25VOY7PAf8JT/yT2ClShfOX1lP9rc0jsbbAml6Ubvr1 th8Ke5DyOsxggNYqIOKSJdso9ZfdAvIYFa5tk8miCeEEq/iTRcBmTdz3LD3tFNIT7n +o+82EPvJLH+Tn+8B0SJxMuCAlGGSFR0m8ie22YsLO0HSHvucH5AGvLqbsdSM+WMir 9SzqIKKbARrHQ== Date: Wed, 24 May 2023 21:47:21 +0300 From: Mike Rapoport To: Ryan Roberts Cc: Andrew Morton , SeongJae Park , Christoph Hellwig , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Lorenzo Stoakes , Uladzislau Rezki , Zi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, damon@lists.linux.dev, Christoph Hellwig Subject: Re: [PATCH v2 1/5] mm: vmalloc must set pte via arch code Message-ID: <20230524184721.GO4967@kernel.org> References: <20230518110727.2106156-1-ryan.roberts@arm.com> <20230518110727.2106156-2-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230518110727.2106156-2-ryan.roberts@arm.com> X-Rspamd-Queue-Id: 735431C0017 X-Rspam-User: X-Stat-Signature: gdcezd95ah4bamjhqza7jzf4pbjqbhmp X-Rspamd-Server: rspam01 X-HE-Tag: 1684954067-106525 X-HE-Meta: U2FsdGVkX1/O5s56lanKUDv5THLYV6Ld6dS1fdkcYbD7TnSVINY8qCPVyUoAdglXPmbNIHXE4BLqECDv0tK5426EFTF5HyEUzGMZKfVP1ns+Z2+AyF8TUB7w1eGRKD6Be6fq/5mTTxCfGXpS/aB6wlP8QAUhcyMBd7UeZpiY6jdVpNSwke/mlECXtbEwj3MIs8MGr46yyiuPJY+bP2Bp0uG+KDyLNol2vkqObEHrBBFt6Y9AS3JVWdUJfB4Q4H1KzPUN8BMkHNNGLOXV9Zy/Zo9BisdPbuYSOjovhbahSOa2bT1P/S15KqK1/iwTn8ZZ1aWzdsl8h5BEAFa8XMtAlUmCsfQeW/zSgZFTmIP7apDsHSKtL4DlBTq9rTM0M/6+3OoYUgdxrrwb1tPRO7qI6TSCWV16xM0Z3vkh8yxGqRcGedtiNQ6o8I+h+5fyB3+VDmFiisyn0LwlJqUFoz/SL61oCl1xkTAdJy9JS51imhmr6fOLKnzX0JVGwU4ia5LPskA89rlSk7n9efU8Xohful+ixmrfGsNbXFT1tQdceykL1DEQEY9zVfgrZbP2XkWmVnn4y2DPoyHyuBNoi7cgVxmk/Nc/HfIKVqxME7E/OIQ6KfDrDkIjfZKaB8uLbm8AUMlrUk0IcE/FyhEbjeBwPiQDpQcZkmaX+FtQljO0c0qE+iYud7BIWZUirnphLGpPjO2s3QqGGNR5fL04I+2pCZXUzyywHZROLmIG8WDCBM5ipi1qZ2HsEHOI4sz4V2GrdV48cAYsA+UQvNcmEc3moY4SrLpZk91wZK0Fr/yQxMcG+AwNJ7YBEdLT2QZAVLIR9Dq0ERpQ+Edyuqbwfjw91WYt7rvcAz0huhf0+9dLZgRY00ssA1FkmhIbnbv9ynwWKQH+ogNAzckc3BF3J6agg47DeIWgzqYA4tBNZ832X6xdyvwEJNsmh4Y7HN8xZdwl9X72r/SfaVStZtH/u42 zL88X4eE 383XchVXO5lkwWux0E7b4uwidxf5VWA8NfEd1Cm3X+fON11FCssODrQHIGcZKGO2mFR39O8yU7ObmfV0pCzYKFnqJx+qJKnQ0SCl1E86whuQtHiHKOg7X6qajistP/rI6rIy2ApZA/MwzJzQ9eY6J0kzZyfgJgdgZRy2fXsSrZlY3Lp0GULbHTYM3VkqsCnW7GJ5Hdy8/m7B0/WrnxIkarWzOSGGDq1l2eF41DGwqVFcV/y+AmLXYgrdEuqXZ9tJSQO0BgS+uX1RXTHLbjhKJ6afDo4ZrXCroGkasjNk3eFvj+HUU24hJ38ukNWl51mQMjUR1GGIjxlaL8I3SFO4NdS1Azo6/LnLWAoPND2RWpaPz0mXSygvs2G5IrOvNEDokUg61+1ypZ8XxBotrhM2BI0c8VY6fXIPFJ3uFSOJ3QjIewbNglyqcO6j7DsIlpo7v7WKDIU60LWa34kc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 18, 2023 at 12:07:23PM +0100, Ryan Roberts wrote: > It is bad practice to directly set pte entries within a pte table. > Instead all modifications must go through arch-provided helpers such as > set_pte_at() to give the arch code visibility and allow it to check > (and potentially modify) the operation. > > Fixes: 3e9a9e256b1e ("mm: add a vmap_pfn function") > Signed-off-by: Ryan Roberts > Reviewed-by: Zi Yan > Acked-by: Lorenzo Stoakes > Reviewed-by: Christoph Hellwig Reviewed-by: Mike Rapoport (IBM) > --- > mm/vmalloc.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 9683573f1225..48202ec5f79a 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2899,10 +2899,16 @@ struct vmap_pfn_data { > static int vmap_pfn_apply(pte_t *pte, unsigned long addr, void *private) > { > struct vmap_pfn_data *data = private; > + unsigned long pfn = data->pfns[data->idx]; > + pte_t ptent; > > - if (WARN_ON_ONCE(pfn_valid(data->pfns[data->idx]))) > + if (WARN_ON_ONCE(pfn_valid(pfn))) > return -EINVAL; > - *pte = pte_mkspecial(pfn_pte(data->pfns[data->idx++], data->prot)); > + > + ptent = pte_mkspecial(pfn_pte(pfn, data->prot)); > + set_pte_at(&init_mm, addr, pte, ptent); > + > + data->idx++; > return 0; > } > > -- > 2.25.1 > > -- Sincerely yours, Mike.