From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EB23C77B73 for ; Wed, 24 May 2023 15:33:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9F4C90000B; Wed, 24 May 2023 11:33:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4EAB900007; Wed, 24 May 2023 11:33:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC79890000B; Wed, 24 May 2023 11:33:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BB041900007 for ; Wed, 24 May 2023 11:33:00 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 758E0C0A0C for ; Wed, 24 May 2023 15:33:00 +0000 (UTC) X-FDA: 80825541720.03.74ADB88 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf17.hostedemail.com (Postfix) with ESMTP id 8AF3140017 for ; Wed, 24 May 2023 15:32:58 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=fTepg2gL; spf=pass (imf17.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.222.170 as permitted sender) smtp.mailfrom=joel@joelfernandes.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684942378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h61GjzCXvltES23o4poVmjSYAXp4vZcszjGp5xgEGZ8=; b=zgriaPQHFdexHkSrgq0NXITrnwABaeVKSZzpuTHFCrzgzgJi/orGA9IkhcYB6wi5TKVfLR ozOwk5p657Owl0htA9M//vMhIDCy5OVB8YWKYvtA0qD8rvzyD1yttAOmsyXIBQEUHg8wqN gaHdXzDp6yXi8i8o/zApkp/ZvDjWF9c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684942378; a=rsa-sha256; cv=none; b=G27R2RdNAJiQYb9DLiwHKwDGFyL5IxVe0pKg/zSjoAw0gfa6Nz4lln+YeV3s1+zBwbwRfK CEfw54FUbIBbstQeV5O7XguILdEPDabCC/MEVYvWBlFea/4bbD+hKIJC4qM8KkOBv8JFDg 4Y+NSUAYyc0UPp3UcHtFrjMISMvEVPM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=fTepg2gL; spf=pass (imf17.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.222.170 as permitted sender) smtp.mailfrom=joel@joelfernandes.org; dmarc=none Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-75b132ad421so152862585a.1 for ; Wed, 24 May 2023 08:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1684942377; x=1687534377; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h61GjzCXvltES23o4poVmjSYAXp4vZcszjGp5xgEGZ8=; b=fTepg2gLXsKRDSS3n315I2mTd5hD9c2GRRNGC2wT9Pv1umTd8fob7wD+9EmKEHSy1U JFE5UVfGrEPXsXiFMq89EduNO36oib/1iEtT3SWY+v0Hr0/YukGkb/aj1tsd+gq3+KKs qg5EKhyLZjkSGWEFRvLD5HeTCqPaTdbo3r53A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684942377; x=1687534377; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h61GjzCXvltES23o4poVmjSYAXp4vZcszjGp5xgEGZ8=; b=PLz+qp4lo+QzdoM77411/5HXFCNpfEhpjmf9lkPWx4oTDCkYuzEcnyrYs6VgG8diR/ cwERiRTqjhYeWDjUxUGFlGaYmpg4erKxiFQ3KxARznffiq4uS2JTmJ+8liHVEDRkfzNZ 4T3BEBdBn4uBoF4wdTfCQ4VOII8zDCRLTkGZl1OuQ26Cff8y9XuDJg9NbDqJL3U4X3tL c0P1mFzH1HPEuCSFwxAeRtjo64PpIJeZ8/rYpj43/Ac7GPrP9HeGr+yrcowYs3WFdPcN i91menDLRAAVVia3VPjZM8DlhknVBjn4+SS4QgD23ZDutvjwwT7g21FfpHcikXyidhrR TOig== X-Gm-Message-State: AC+VfDwxRy+X19xqOZ4G47si4Ce81YgGm0omsIDhhZT8LrQriuh0eY8i KSt7/pgwTFzIZi7FqGJFTWKDJg== X-Google-Smtp-Source: ACHHUZ6AChzGe8zj3ATmmPA39ZihGAOgH+d2JvfKahlPyGoIVsVd15lvAmevdImu0XtiQQY9/yyQKw== X-Received: by 2002:ad4:5949:0:b0:5ef:46a9:15d2 with SMTP id eo9-20020ad45949000000b005ef46a915d2mr27143817qvb.7.1684942377556; Wed, 24 May 2023 08:32:57 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v18-20020a05620a123200b007590aa4b115sm3296906qkj.87.2023.05.24.08.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 08:32:56 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Lorenzo Stoakes , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" , Suren Baghdasaryan , Kalesh Singh , Lokesh Gidra Subject: [PATCH v3 6/6] selftests: mm: Add a test for remapping within a range Date: Wed, 24 May 2023 15:32:39 +0000 Message-ID: <20230524153239.3036507-7-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.1.698.g37aff9b760-goog In-Reply-To: <20230524153239.3036507-1-joel@joelfernandes.org> References: <20230524153239.3036507-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: w8wegp6barm6asztbkgxhwbm96gq3w5o X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8AF3140017 X-Rspam-User: X-HE-Tag: 1684942378-39804 X-HE-Meta: U2FsdGVkX19SVENnSzlFYqAEd/B5Nm+Yj2MVuxJC82HtknnmjpYcE4zc/1BQR0HFdYA6c/eAD0lkJ9N9dUr1quJwuVCdeLMscouJHiMW2HfbwYZebmJrzMWg1gp45IQ5OTm2G5O0lu0fZ/8t7Le36yJgo0QVkvL/uLup0f06CDVpz4BXB9AZd+pJJQMblrIFZCIdAJpL4CMFiyd8U14HjaqQn0gFlHDbn0br1EYFPQ5JedLSQS5RxxrFtNnu3bghtQEvyDEnaD38A9hA4SBI5hOkRr/KO4QacjgZ9eFC2TKiLVDPBhD3pOcOOpSEUN6cM3YLaBJgRyyDQe0/8hRPMWONVHTcjUlDSaVRkudC7iuSAcT2o90E1aWVeQeeoG7qZrAxaiy99/LxylYjlnEgEaqbGWpgetuFFsvwWT4cE3MSphhJyiYlN0E1/YtVn88pAjir/pFqMxVLHj6yleSEXof8k+DRitWJGogtPtM5idNOdPzz6Rgdz45G3/nKGI3gQbPIeYXlTyBsM6m5UEto+9JeNwYDJBQ8jiK9Cfdlg/fIprjHgWcpIwtDdIsVVV77QYLLT+g2xNX0uPylwm3nkplx6wUEmmYOwE2Q7vqbn+MyWpUy5WNWmNZJBmqG5tu3FOmhOca/Eafdy42lZEq1JM+Cfxamk/jkiPh2MK8kmo4YMUIzPGEYSHp7ZXMTqRj4STX8b+CJi/s8cqjoiJeKodQv1JuXrREy11sA2l7XvILpImcY+t9Jb5en7eWRtI+H+0RZjUktLWji2yY9vEEqUfUgVouSaf+YHqnxpA0hSF0Pw9cA5DrLdOUruA2VAj63NdXFQw8I3h2oJ1xMIAs3AiXjlLLfrU9EDqIEGsyzE1aMxUdCLGIPNR9OfMGnX3DDWN50L2OVrxgrUFSJ1I6et/wiRaWNh4F0ZZobb9QuHMijZHL9Vwk3nHvzeOxkdcNuGcf9ha9AiORg2hgN0g6 Z4DJJQSn kfXueO64nEkl1b7dmNqGRw1e5MbXE6E7sx6dhnApXmIcYsEWbQ3PjGT+xZV+WMIP2+CuO7rRamyUUPz0w+Q6Vj3GCBFzXF9rSDbKmcWCdHp72czIRwBTXddDMzO7FGeicg0AisVC4KlwTwxZ76DTTrqzYpenRx/q9QQMnqGGuOa2+sDvZhmKNHhAbci5rlQT7h9TFoTIkWWdeuBh1zezLGtbVkDrQM9yRt2gtDXYcoxCB00tVn2upnpIQ/BXrA1ddgkwvK7wi/sgQ5MQou2P/hqc0869P+HnkbaUfIV3CZO9Rqn/NfJitsZpvnP/ccvtQj6uj3IJJK7WQPg8WhZsuRjtXSKx9WPMtsQaETXTJmiKOoPcsk5YhgY53VMXllq50Ziu/Z/xmRvp1H0BIG+rwfejNqXfLVOcjV4/JXdB5mcVPSQDYw5tpE0KNgBBRYPR61z0iuV+eEoa26NqWMKZBBSVzgqbp1F5sLsbp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Move a block of memory within a memory range. Any alignment optimization on the source address may cause corruption. Verify using kselftest that it works. I have also verified with tracing that such optimization does not happen due to this check in can_align_down(): if (!for_stack && vma->vm_start <= addr_masked) return false; Signed-off-by: Joel Fernandes (Google) --- tools/testing/selftests/mm/mremap_test.c | 79 +++++++++++++++++++++++- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c index d7366074e2a8..f45d1abedc9c 100644 --- a/tools/testing/selftests/mm/mremap_test.c +++ b/tools/testing/selftests/mm/mremap_test.c @@ -23,6 +23,7 @@ #define VALIDATION_NO_THRESHOLD 0 /* Verify the entire region */ #define MIN(X, Y) ((X) < (Y) ? (X) : (Y)) +#define SIZE_MB(m) ((size_t)m * (1024 * 1024)) struct config { unsigned long long src_alignment; @@ -226,6 +227,79 @@ static void mremap_expand_merge_offset(FILE *maps_fp, unsigned long page_size) ksft_test_result_fail("%s\n", test_name); } +/* + * Verify that an mremap within a range does not cause corruption + * of unrelated part of range. + * + * Consider the following range which is 2MB aligned and is + * a part of a larger 10MB range which is not shown. Each + * character is 256KB below making the source and destination + * 2MB each. The lower case letters are moved (s to d) and the + * upper case letters are not moved. The below test verifies + * that the upper case S letters are not corrupted by the + * adjacent mremap. + * + * |DDDDddddSSSSssss| + */ +static void mremap_move_within_range(char pattern_seed) +{ + char *test_name = "mremap mremap move within range"; + void *src, *dest; + int i, success = 1; + + size_t size = SIZE_MB(20); + void *ptr = mmap(NULL, size, PROT_READ | PROT_WRITE, + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + if (ptr == MAP_FAILED) { + perror("mmap"); + success = 0; + goto out; + } + memset(ptr, 0, size); + + src = ptr + SIZE_MB(6); + src = (void *)((unsigned long)src & ~(SIZE_MB(2) - 1)); + + /* Set byte pattern for source block. */ + srand(pattern_seed); + for (i = 0; i < SIZE_MB(2); i++) { + ((char *)src)[i] = (char) rand(); + } + + dest = src - SIZE_MB(2); + + void *new_ptr = mremap(src + SIZE_MB(1), SIZE_MB(1), SIZE_MB(1), + MREMAP_MAYMOVE | MREMAP_FIXED, dest + SIZE_MB(1)); + if (new_ptr == MAP_FAILED) { + perror("mremap"); + success = 0; + goto out; + } + + /* Verify byte pattern after remapping */ + srand(pattern_seed); + for (i = 0; i < SIZE_MB(1); i++) { + char c = (char) rand(); + + if (((char *)src)[i] != c) { + ksft_print_msg("Data at src at %d got corrupted due to unrelated mremap\n", + i); + ksft_print_msg("Expected: %#x\t Got: %#x\n", c & 0xff, + ((char *) src)[i] & 0xff); + success = 0; + } + } + +out: + if (munmap(ptr, size) == -1) + perror("munmap"); + + if (success) + ksft_test_result_pass("%s\n", test_name); + else + ksft_test_result_fail("%s\n", test_name); +} + /* * Returns the start address of the mapping on success, else returns * NULL on failure. @@ -491,6 +565,7 @@ int main(int argc, char **argv) unsigned int threshold_mb = VALIDATION_DEFAULT_THRESHOLD; unsigned int pattern_seed; int num_expand_tests = 2; + int num_misc_tests = 1; struct test test_cases[MAX_TEST] = {}; struct test perf_test_cases[MAX_PERF_TEST]; int page_size; @@ -572,7 +647,7 @@ int main(int argc, char **argv) (threshold_mb * _1MB >= _1GB); ksft_set_plan(ARRAY_SIZE(test_cases) + (run_perf_tests ? - ARRAY_SIZE(perf_test_cases) : 0) + num_expand_tests); + ARRAY_SIZE(perf_test_cases) : 0) + num_expand_tests + num_misc_tests); for (i = 0; i < ARRAY_SIZE(test_cases); i++) run_mremap_test_case(test_cases[i], &failures, threshold_mb, @@ -590,6 +665,8 @@ int main(int argc, char **argv) fclose(maps_fp); + mremap_move_within_range(pattern_seed); + if (run_perf_tests) { ksft_print_msg("\n%s\n", "mremap HAVE_MOVE_PMD/PUD optimization time comparison for 1GB region:"); -- 2.40.1.698.g37aff9b760-goog