From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC4F2C77B7A for ; Wed, 24 May 2023 15:32:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3798A900004; Wed, 24 May 2023 11:32:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 329BB900002; Wed, 24 May 2023 11:32:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F18A900004; Wed, 24 May 2023 11:32:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 12043900002 for ; Wed, 24 May 2023 11:32:56 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 96D8712082C for ; Wed, 24 May 2023 15:32:55 +0000 (UTC) X-FDA: 80825541510.05.EC3AFD7 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf19.hostedemail.com (Postfix) with ESMTP id BAB1E1A0014 for ; Wed, 24 May 2023 15:32:52 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=MPLMVQxR; dmarc=none; spf=pass (imf19.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.222.169 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684942372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=nQdM6MRoHyYb9DC9yBJL0H8qT9Rd4+LN5oK5C3g/OFE=; b=kWfcSinI576ptK7E6Dhw9q2bc9f47nuvL/1/lmDXilN5pn+j1E43SKgSfuCRSodElP2XXD bOeoSbHmqWtRPOJyk4tqsOAeDYLTPrBJIXKM9UUUakX/1/Ia6VF2Ab2hpPWH6p3ggLNcDh kmthKRJx36ENwePwFc5mw4mz+wsUWnY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=MPLMVQxR; dmarc=none; spf=pass (imf19.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.222.169 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684942372; a=rsa-sha256; cv=none; b=eQmJy7X/nKvr/awriSqWq+YXlPTYeayqciRid4VrOsAg0kjVUQQf4MVelY17eK1Wuopj98 TajlhBaYiX6fn+bQkpCpJqg9lkYLKEC+9ZHeDEWwY00RdoIWDcP/+GHfXLRDFPvFeYKrZZ z2hOr0pdB8Z3URFp8gzFC+cOpO+JDIs= Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-75afeacb5e4so152249885a.3 for ; Wed, 24 May 2023 08:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1684942371; x=1687534371; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nQdM6MRoHyYb9DC9yBJL0H8qT9Rd4+LN5oK5C3g/OFE=; b=MPLMVQxRe96+SScpLaw8sLhMl9jpbVWZCvBa0rCNYDN96vZxeF0ygWtHPUZfTLVFll LZYL98Fz8Ha5Mdlj1XTzG476kwQTbO/JagVHybCAAoCisF44cGs38w6xWO8O/rFwfCUV gRs7TDeLJxTyJdgA0zA6rgObFAv+d7YRK6me0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684942371; x=1687534371; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nQdM6MRoHyYb9DC9yBJL0H8qT9Rd4+LN5oK5C3g/OFE=; b=D3jgnvHC/zNmVkzvyC6T1WBt9ZxnBY8/wHgbBGVdtxjC+tdubYw40QF0WSQktQEjj3 TQ9EXVQrqm5XhDx10m8TdsQQ2sZRnDodMT1KE4KWfrU8SklT6zrkc54REiwv/D1c0ksb VaItwBtwBTV2HKnNebW/3QezoN5f/SwjSlrW7UdfJD3TGtF7tm8eT56+idnlSfL5r0UU 80huSmDFInkfFeivImGbA5ZnQrZcSCJeo6hvnjsFZDPlnFn4U0LnIuEngPvhPpAv2Chv S5RGUWi+5lowW1gAI3TzLoBNrICH1HsnHSHVJB3Fe5GKYwP5CtrZ4umn6x+RYczPnkFE HBJg== X-Gm-Message-State: AC+VfDyPf/yjsI7wkQ2Y2oX7TIJrdpPOTLfPKK/1pqfix5uiUK02NpuF glff7e3ZotK5XKTH9YaGdD7b2Q== X-Google-Smtp-Source: ACHHUZ6SizGJwGcv9Tz+/DPOYdhE0AkVtVTHOSlxAS8WGojoltL4coJB+lXtG6Wg8raxf+U9m8k6dg== X-Received: by 2002:a05:620a:1d4b:b0:75b:23a1:361d with SMTP id dm11-20020a05620a1d4b00b0075b23a1361dmr8178488qkb.46.1684942371650; Wed, 24 May 2023 08:32:51 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v18-20020a05620a123200b007590aa4b115sm3296906qkj.87.2023.05.24.08.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 08:32:51 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Lorenzo Stoakes , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" , Suren Baghdasaryan , Kalesh Singh , Lokesh Gidra Subject: [PATCH v3 0/6] Optimize mremap during mutual alignment within PMD Date: Wed, 24 May 2023 15:32:33 +0000 Message-ID: <20230524153239.3036507-1-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.1.698.g37aff9b760-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BAB1E1A0014 X-Stat-Signature: h8jnrbget9a3bs8dmwhm6ayjbmmy973y X-HE-Tag: 1684942372-596617 X-HE-Meta: U2FsdGVkX1/upa4LvoGhgJmk10nBQXtYq1r212OLbtCwIAkfuR6OZ1HxNz2AcfzgwCmZP20SMZmQoIwycFXmXYWmDH6xw1o9IeKfyvgGtXrPH5D8H/qEQrsSg+yoW+0Q99Je2EwlKEHtYsurGFxT/qk6EZPQne1vvjgqGS6faJ+wd/YV6+F/tOwKjTu7lHPW4X2ChVy90vnYxJ5gtjGgmxr2RqIP9m8NMX+7jQLxfOO7iVCel0NpE7ct/n4OLhdKMxyAIKEmpdyqrvz0w4uLJ9MP4u8SYAXHQGlR97lgLez5jfC3Y3W6qtw6aQJm7v83VzPTMoeLWrCfpGJdZGupmfj5CusXdwEdYCn/28WnJ6J83M2RmFOQG2v8C6vcTmX8qvmxAfpcDA898hEiNHAQN1yw7YtZKfIBt7dlF4Jx7DYMzbHVo4bZ7w5nV7wQXwNVV43GbvpJAeOHcYFlXTm3djZqOhf/0iFMYgjX5w+Y6bSB+UXjJxT4HLexTOBaWvmjvsaNywo796AvOjcYOvbyex3gTxPBTfLZg4uCo8iFLXDplQSLZTY1uYzg+X4S5cro28b4yJLoZdU4O3m5iY10FXQH+hiroFGIzBApOif0Cx77HMbzOIDY2sT+xD80QFu5O/RJ27m7ixihNWPEKkJrI4utG4HfiZGyyAlnFVTyvxQCo4wZbdyzGGr1KIpCgCjyQsTBEdwUnDTKUqPe7dfhjl4MMf6SxFc5qMeobs+WlEAYSK4bMt3eG4jbADbJIDFz409nE4r5jfB6De3shctagOkEak+u+vZkj+vpa92friQmLs29RKz26aSoLTFN+194SJSgxjnK/qTGm//xSev5KD1nUeJbc7Cae2aAvU0936i+dDcU//rWcxWOBNIEybW/u5a8+f57PEMgGq9x7cNxY48BXrqFv8mdCQDG+JI/LE1VSN0wRkMdN1yj/cZBXpbVhMbi0SECN+pVRJ7r/Ov Vaklx4OZ syDWFndnrgmw88IMNvJ1b1pddkHM6lbpearFurCP8rUzTX9MLLABrK/UAtYjOgNdtw+DK27DSyrLflwuWGR5fBjZIjDP1cFq1Kr5JRenYUUyVQ2CW3mM8GZg3M0J6QTf4rWHAJZFmJwQuEQfzF0CsO2GvilR+foZghnbPCnVyOOvO/X4ph4PxEiDgeC85YgWgyJIpkPl3Yt0cx2Cny9kF6Di3UBok+lbZpluN0JC12EmYYT0DFoAvoqeM5vq9uorUdLaYAUsOU8BkmpVcpSUcfbeqLK2/GHsLDjVbgpVzq1XEYo2mxq7k1kV56JeNXh93tuhAqbwVOVPjyrL1a1Jed3A192IyUupRwYZTvUBxr0i4rDLy+4jzMuHfOz0kDYBa1mRgWT4UOtGTKR2kg2hFmVZtxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello! Here is v3 of the mremap start address optimization / fix for exec warning. The main changes are: 1. Care to be taken to move purely within a VMA, in other words this check in call_align_down(): if (vma->vm_start <= addr_masked) return false; As an example of why this is needed: Consider the following range which is 2MB aligned and is a part of a larger 10MB range which is not shown. Each character is 256KB below making the source and destination 2MB each. The lower case letters are moved (s to d) and the upper case letters are not moved. |DDDDddddSSSSssss| If we align down 'ssss' to start from the 'SSSS', we will end up destroying SSSS. The above if statement prevents that and I verified it. I also added a test for this in the last patch. 2. Handle the stack case separately. We do not care about #1 for stack movement because the 'SSSS' does not matter during this move. Further we need to do this to prevent the stack move warning. if (!for_stack && vma->vm_start <= addr_masked) return false; History of patches ================== v2->v3: 1. Masked address was stored in int, fixed it to unsigned long to avoid truncation. 2. We now handle moves happening purely within a VMA, a new test is added to handle this. 3. More code comments. v1->v2: 1. Trigger the optimization for mremaps smaller than a PMD. I tested by tracing that it works correctly. 2. Fix issue with bogus return value found by Linus if we broke out of the above loop for the first PMD itself. v1: Initial RFC. Description of patches ====================== These patches optimizes the start addresses in move_page_tables() and tests the changes. It addresses a warning [1] that occurs due to a downward, overlapping move on a mutually-aligned offset within a PMD during exec. By initiating the copy process at the PMD level when such alignment is present, we can prevent this warning and speed up the copying process at the same time. Linus Torvalds suggested this idea. Please check the individual patches for more details. thanks, - Joel [1] https://lore.kernel.org/all/ZB2GTBD%2FLWTrkOiO@dhcp22.suse.cz/ Joel Fernandes (Google) (6): mm/mremap: Optimize the start addresses in move_page_tables() mm/mremap: Allow moves within the same VMA selftests: mm: Fix failure case when new remap region was not found selftests: mm: Add a test for mutually aligned moves > PMD size selftests: mm: Add a test for remapping to area immediately after existing mapping selftests: mm: Add a test for remapping within a range fs/exec.c | 2 +- include/linux/mm.h | 2 +- mm/mremap.c | 69 ++++++++++- tools/testing/selftests/mm/mremap_test.c | 148 +++++++++++++++++++++-- 4 files changed, 209 insertions(+), 12 deletions(-) -- 2.40.1.698.g37aff9b760-goog