From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB17C77B73 for ; Wed, 24 May 2023 08:58:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 238FC280002; Wed, 24 May 2023 04:58:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E8E2900003; Wed, 24 May 2023 04:58:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B228280002; Wed, 24 May 2023 04:58:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ED850900003 for ; Wed, 24 May 2023 04:58:01 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B8849AE2D2 for ; Wed, 24 May 2023 08:58:01 +0000 (UTC) X-FDA: 80824546362.13.9E77BB9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 043C618000A for ; Wed, 24 May 2023 08:57:59 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CWHLwMNt; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684918680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yA9jCH52+YUaBUzIw9jsGimRD71xh951jWStih5Prn8=; b=cgAby5wlt59kMSchES5WbKaLhQK2+wVwmdSdIZX3NpwdGOAyxbOt6PnuBqVRAmqJuCuNHh jNWkfF+q+IxQr4o+fn3u0DCJVmk22+EnML90cKZON0Ov7RihKtnaJPFpfqMT7PXZzQ0npb LPXiMKNGkeFL4gUfj1vsg6ViRAaDtL4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CWHLwMNt; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684918680; a=rsa-sha256; cv=none; b=6vGrHsGU0fBJCcg3GLJ85TNKLh4TJFOJogaApsLqIykHq70QHmX5xcJkVMOCOhw9POhO1S Zz0U05xQ1XqvC6LujPecKe6INvt/acQTDfPOCvoC70RbV1CYawte5OL2fKFPq48kXM33TK lx0mXcboQW88snr1RkayS8YoXLykfxU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F1A863AE7; Wed, 24 May 2023 08:57:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BAC8C433D2; Wed, 24 May 2023 08:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684918678; bh=1cXXyBgnY1cQrBHLhyhzrkI4CCJ3rb6IDRXTv9L9PM4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CWHLwMNth3W2HD4LxrD97c9KK7zXWh+m3gX4ki59JhZiryYynEhbb7vNIqNlGbLAv qpZc7VDkJ7Snzd7jKXxhCVqALkX/bJmdXn5G0KL8+YktYr4+doesbxfuVhnLBv+zBJ /V/OZxE2PVb3Ht8uXtIbLXxwNsEG1aQHNbdvXOaYBb0OWxW0zUkJ2ldlBb3q6Z/HLA dTG4qg/yBuYSU6CU5U2MmxdJaNPPNfhSp499CbM1Qzn7DAaAtz6BsVqecxLdJSjUaZ S67DLl8IsGLcqK+K5K1JeZNLgyaM+klU6BTKoYcgkQxuSoDSD/AFWDKmC+6mU74Een nXFijfbtV/cJg== Date: Wed, 24 May 2023 11:57:38 +0300 From: Mike Rapoport To: Yuwei Guan Cc: akpm@linux-foundation.org, tsahu@linux.ibm.com, anshuman.khandual@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] memblock: Add flags and nid info in memblock debugfs Message-ID: <20230524085738.GL4967@kernel.org> References: <20230519105321.333-1-ssawgyw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230519105321.333-1-ssawgyw@gmail.com> X-Rspamd-Queue-Id: 043C618000A X-Rspam-User: X-Stat-Signature: 3qyege8fuubnoua9cfmx6wxqr7a5k44d X-Rspamd-Server: rspam01 X-HE-Tag: 1684918679-870930 X-HE-Meta: U2FsdGVkX1/VLupRln8C5nK1+Qj5T4gewTK75S4fuQxaC0WE2QwLj9XC/YjnvlR8TnLJLBYG7pFWJu2EFx3BMPKwva2y958eRQosWyNEWoZWVR+ACOoS3hIfNFVkY9e+S7O69/CO9nf33e/Z11pSbv7088Dcy8HLb5BjCp8vx9Uyikd/UWPx/d6eCzxGnhyjqK6m6WqNjbXEWyOzJ/2cxEvlpMHcaRLttyrcFwevtaVM0BG4niesXEz5Q4VYSMnXnJ0fykV4f75hyFq8CHEjNjY52rS8F5tLIHS/9XTwOezMTdg+4dwapsgwQ/gvGyIsN1Oi3XmVIX3w0VFf9fESe54jg2JtlC56vH3Ho+NLwmCdAOFei/l6oWIP1/lSi1MS79fCHk1IttAO5h+9W7eJfhaActJrWw8LaerJ2fwI5rdR04XVZz3XXiZmPoCFiQEBjdUjR8Er1DNa0b1VLxixh6xq15HzQ0MMjwKBvavliHeZJHOEjErizDbX0ffvlMJSs5yaJWN9rUrxcL7CCATPLJ996KibhnG5+enhLw5/+1u92ujzHwUGbiU7FmqsU89tpmhNWfSsvbXxCzJpbGAgNkeDFjajlFvqQGWgGUn8t4dvM55AoK8gbB6r6zv62Ty+Tq9fNbi22RWkXSneG98jmR2J8CqbylTUdmv07bu8CV0nLWOE8U75bBlgYvlOVPnQuGFxRZEVk+xCifx0SBoblmGh/dq1CEggdcC5vLI2O3z9yFkaQNenj5H4NgMU7NjXCkn3q+LALeY3doHelyRONEZfyDJf1IEp05vpbm/rD62B1F7iW5b45hvEVRxm5kvTxOJwZk+Qrsqpb8HLf5QEnT/shb5a2D+OiQfn6sU5azWIO5TaKwMSgoQ+YnSFjCccjHKXZ/qQQ9wFpxszQK8k94AAP4uy2eESBX+dvYXQJg+2CjIvF7OznCpzk/Z+kLoXr4euoU4JQXR1l7NbKJJ uThMDH3D 03uBy7Q/8CdOwB+CfMe9tGLwp8cLwyCCqXEj/qTCB+qzphNy98+tlsRIg479ROUQapBvgFTX6OPs86thAZ5zn3p0bCkCjBc10MeAMawE7qSU3S2VqV1hKnCxs2oFsbbNyqaubH3q5eo1OwlxKv69QxnRMZHnoHNPC6ZZomfaQkon9Rwfer2h3csZj9oeD1GVNb7d4DxOyG/x6wYp8HctUJ1/kgTAT3xHNDO9KG/kECN6BGA+woYqH6g6Cr91obbYy/tV23hE/hKzIAmcYaHbBLp/GteA2lOfw+1bauWMBhTNfRIfywKuMCkUo0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 19, 2023 at 06:53:21PM +0800, Yuwei Guan wrote: > Currently, the memblock debugfs can display the count of memblock_type and > the base and end of the reg. However, when memblock_mark_*() or > memblock_set_node() is executed on some range, the information in the > existing debugfs cannot make it clear why the address is not consecutive. > > For example, > cat /sys/kernel/debug/memblock/memory > 0: 0x0000000080000000..0x00000000901fffff > 1: 0x0000000090200000..0x00000000905fffff > 2: 0x0000000090600000..0x0000000092ffffff > 3: 0x0000000093000000..0x00000000973fffff > 4: 0x0000000097400000..0x00000000b71fffff > 5: 0x00000000c0000000..0x00000000dfffffff > 6: 0x00000000e2500000..0x00000000f87fffff > 7: 0x00000000f8800000..0x00000000fa7fffff > 8: 0x00000000fa800000..0x00000000fd3effff > 9: 0x00000000fd3f0000..0x00000000fd3fefff > 10: 0x00000000fd3ff000..0x00000000fd7fffff > 11: 0x00000000fd800000..0x00000000fd901fff > 12: 0x00000000fd902000..0x00000000fd909fff > 13: 0x00000000fd90a000..0x00000000fd90bfff > 14: 0x00000000fd90c000..0x00000000ffffffff > 15: 0x0000000880000000..0x0000000affffffff > > So we can add flags and nid to this debugfs. > > For example, > cat /sys/kernel/debug/memblock/memory > 0: 0x0000000080000000..0x00000000901fffff 0 NONE > 1: 0x0000000090200000..0x00000000905fffff 0 NOMAP > 2: 0x0000000090600000..0x0000000092ffffff 0 NONE > 3: 0x0000000093000000..0x00000000973fffff 0 NOMAP > 4: 0x0000000097400000..0x00000000b71fffff 0 NONE > 5: 0x00000000c0000000..0x00000000dfffffff 0 NONE > 6: 0x00000000e2500000..0x00000000f87fffff 0 NONE > 7: 0x00000000f8800000..0x00000000fa7fffff 0 NOMAP > 8: 0x00000000fa800000..0x00000000fd3effff 0 NONE > 9: 0x00000000fd3f0000..0x00000000fd3fefff 0 NOMAP > 10: 0x00000000fd3ff000..0x00000000fd7fffff 0 NONE > 11: 0x00000000fd800000..0x00000000fd901fff 0 NOMAP > 12: 0x00000000fd902000..0x00000000fd909fff 0 NONE > 13: 0x00000000fd90a000..0x00000000fd90bfff 0 NOMAP > 14: 0x00000000fd90c000..0x00000000ffffffff 0 NONE > 15: 0x0000000880000000..0x0000000affffffff 0 NONE > > Signed-off-by: Yuwei Guan Applied, thanks! > --- > v4: > - show string value for each memblock flag > --- > mm/memblock.c | 24 ++++++++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 511d4783dcf1..10d0ddbeebc1 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2136,12 +2136,19 @@ void __init memblock_free_all(void) > } > > #if defined(CONFIG_DEBUG_FS) && defined(CONFIG_ARCH_KEEP_MEMBLOCK) > +static const char * const flagname[] = { > + [ilog2(MEMBLOCK_HOTPLUG)] = "HOTPLUG", > + [ilog2(MEMBLOCK_MIRROR)] = "MIRROR", > + [ilog2(MEMBLOCK_NOMAP)] = "NOMAP", > + [ilog2(MEMBLOCK_DRIVER_MANAGED)] = "DRV_MNG", > +}; > > static int memblock_debug_show(struct seq_file *m, void *private) > { > struct memblock_type *type = m->private; > struct memblock_region *reg; > - int i; > + int i, j; > + unsigned int count = ARRAY_SIZE(flagname); > phys_addr_t end; > > for (i = 0; i < type->cnt; i++) { > @@ -2149,7 +2156,20 @@ static int memblock_debug_show(struct seq_file *m, void *private) > end = reg->base + reg->size - 1; > > seq_printf(m, "%4d: ", i); > - seq_printf(m, "%pa..%pa\n", ®->base, &end); > + seq_printf(m, "%pa..%pa ", ®->base, &end); > + seq_printf(m, "%4d ", memblock_get_region_node(reg)); > + if (reg->flags) { > + for (j = 0; j < count; j++) { > + if (reg->flags & (1U << j)) { > + seq_printf(m, "%s\n", flagname[j]); > + break; > + } > + } > + if (j == count) > + seq_printf(m, "%s\n", "UNKNOWN"); > + } else { > + seq_printf(m, "%s\n", "NONE"); > + } > } > return 0; > } > -- > 2.34.1 > -- Sincerely yours, Mike.