From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B9F6C77B7A for ; Wed, 24 May 2023 07:55:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFB1B900003; Wed, 24 May 2023 03:55:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAB3B900002; Wed, 24 May 2023 03:55:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D730B900003; Wed, 24 May 2023 03:55:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C7149900002 for ; Wed, 24 May 2023 03:55:48 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9266C1A08A6 for ; Wed, 24 May 2023 07:55:48 +0000 (UTC) X-FDA: 80824389576.02.CACB906 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf25.hostedemail.com (Postfix) with ESMTP id B40F8A0004 for ; Wed, 24 May 2023 07:55:45 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=jYfZnFBw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of xu.xin.sc@gmail.com designates 209.85.210.195 as permitted sender) smtp.mailfrom=xu.xin.sc@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684914945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QX2B4bEaAlSoT9esPLaj9XAKt9Dpa0mkiSapMFXuv3Q=; b=bModM5BtWZDOSFGDvqns4FXAIc5sLiJ2aIh7w00oU0n9h/Ja3ppdSD7r8+mboRZ06Ij5FI 9cbVTi/Q0tsuL69J3mb34x8cgcx7IIbYeMJQp4tJD/ySp6N5D3voA955h5uzx2uAw25ZMK CdtjhzGH79/1TQBcEQS/Tlp1yKsXIlc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=jYfZnFBw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of xu.xin.sc@gmail.com designates 209.85.210.195 as permitted sender) smtp.mailfrom=xu.xin.sc@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684914945; a=rsa-sha256; cv=none; b=YM+a1U4WnxzeDyaIc5ERYX9NeAUUO+wzAV8nm+f+TtbjAcKnVZ7b2uN15apvKDv1p6k9le Y+JPCielLc+UqpowmgJxhEiszyVaTbwgJ/GQMuYyU8lyXXgG+AuEABX/0XLVajHRqnz/zD rgObt5MXbl+gW5gZ6eAQq8r/A62ONRQ= Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-64d5b4c3ffeso434391b3a.2 for ; Wed, 24 May 2023 00:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684914944; x=1687506944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QX2B4bEaAlSoT9esPLaj9XAKt9Dpa0mkiSapMFXuv3Q=; b=jYfZnFBwdllj3lBbr3grVPfUGpXtIHW92GZJk2eMyDCCdcMmI7G2Y9NzVjk394UHix tR7Q+Hg/9HQXg8ryTeq/LrGqw5Odezuc1XcqBkMBmv72h9lZZrpEkY31BFSAlhwYVuaS tV3K2u9eqnCQwlqik3mf2ZqdRBFlWGDUoTWAeY5MAS1FOvCu47pcgqZgymIgnJIn74r4 gEi7E+AopJjq6fnelrQMs1ayE6A+ayYh+JcaUWxIoVulH4EEmDNCAK6QOloSrwqVho43 nF3lFTQtuJpU8zT0oAOdisRygOFnNR424kcQM+hGrCDQAa74XicyFLb0t5F0SKPe/Ped zzoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684914944; x=1687506944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QX2B4bEaAlSoT9esPLaj9XAKt9Dpa0mkiSapMFXuv3Q=; b=l2HCQXKOkoNMxrSAbulgDMV2iL9MV8uaLLQcy3XSIS2P4vGZYfOJg/auaOVYsMRbxA RL7qGSsl/tme1ADx94EZLOKgqbM8gg2NVlvyhnUaqGrCj84L1JNHXIE7KoHnaqP5NKWW sBVElhs1+tZsmk7u5Vd538mgRcBmZ+E+ww2Ln5rcfYG+SPGW5LcnDxM+TME4447DlTM4 jILF5aQoJNiDhKUO0q+b0NuIJuizIscoxe2v7kIszaLBmrs/ur7UcFbVeKH3gG8Vrw6+ pku2Aj1AlDH8r2x5xLRgs6U7G+dCjk48e40P9YwXy69sZVBkmfnVP6B0OtqWvjPsXf/v 0ipg== X-Gm-Message-State: AC+VfDxnPghQUiPmAOAq83PwOfbKgcTLpbmX0hkDLMGbj5MIbmYFKYtF heZuCHgWbfSrKZCYNwOQEMs= X-Google-Smtp-Source: ACHHUZ6hxr9Dc2l7EB8ReE5uo5Xxjw4BVr7ZeJFh1NwVMnCm4hCjcqqkAmaB/O3V6K8qzPHZrE3CGQ== X-Received: by 2002:a05:6a00:b50:b0:640:defd:a6d5 with SMTP id p16-20020a056a000b5000b00640defda6d5mr2357697pfo.12.1684914944196; Wed, 24 May 2023 00:55:44 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id k4-20020aa78204000000b0063b6fb4522esm6885034pfi.20.2023.05.24.00.55.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 00:55:43 -0700 (PDT) From: xu xin X-Google-Original-From: xu xin To: david@redhat.com Cc: akpm@linux-foundation.org, imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn, yang.yang29@zte.com.cn Subject: Re: [PATCH v9 2/5] ksm: count all zero pages placed by KSM Date: Wed, 24 May 2023 15:55:39 +0800 Message-Id: <20230524075539.20844-1-xu.xin16@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <52bfd744-3086-a22a-e2e7-8b64d5fccfcc@redhat.com> References: <52bfd744-3086-a22a-e2e7-8b64d5fccfcc@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: i8kjtaeixoar65tfwp1fib1wsuobhphq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B40F8A0004 X-HE-Tag: 1684914945-689497 X-HE-Meta: U2FsdGVkX1/NGh+e0XY9/AqkcCkY9Ox2WNVMkGPgC62ypdQeSCWO5z4xv5asrO+E43oFmT/m2pbByBixMBrVpTF523ZvtL5FNXBuFG3OYCec2oXUGjJsJ9AEexCw2ukxk/X1t5qfIQhcWJtOiN/Nc3tkRWg57opAk8PnWW/IkfDZ4RmF/QKi1YqaAgjwJJz1YbTuJE5CV6JKFOpHcgaLbLk3QxpYDUUD9kALLHT9VkxHut8ZTjcjx6ywjzvhaLiElEcTqe3ve9T+w+TDW2dWAKkcDJk3kIacOkYTKXErkj8Q5Vt4sAhOwLDRl9axsXzeHbDxVw1KSJS/nRaK1DIY03CeauLWQnartfx4+5zLCaWcAL4lZeLizp7A7Y32sBf8aSe26qzAblGzg5S4a38yGUgF2ZhsRcV5bUQlZEl3XM5Pxcx0C/qVC3gtGYsUHa+Jtaameb6MzUrUV1wjwzOe0hdjzwrTkkH851Bk64WMLFl8s42Ofhme7DT04ZrTNUJK5kh6X2we7uwkaJ1O2hUAbywaK9hHl2mOBNPRo0YglEH9CyGkr5gz81fSeb3+G0rQ7G6e4893ZBXgR+gEYI4FQDaxDyJFODBgUjithMfDGH1XRF5VsHS/rQmVvtSlIOQmtLtSEw9mC4Kvysy/n6hnsBAyDKgNcCkPsQDEucqZag6dkkrSdsmcH419XcGqam8ECa6NjPT/kEBwLyp2XpHfVQsENxpl75f2sKJPWsuTukpRIO5/ce4VBr67CwDgJf+l4a2gail/RVfarkkox1qvtH3CTUiA+ytPV+Jpf6pMHGpkDP7n9xBHlIiz6+VgpiQzQ9C46dkAhSuBrvDhEmXFJQH16xUtaxOwIqMYGJC1Gsx4w3A4htzRPIZcZYha1tiVoczvm0DfmyrdthNBUYCZObUDAyOrYLIBk1F4dKor94s7GoIs8EYBATg9RiM7LA9ZPuQ5i1NIYbGXhmGqER1 H5b0MVlD g3Yk5jA/ye4DPCT9909Hcshrqg5Ikk2RKiR15/wxzbcJoR/KPC4vWsfxbeOl5PZoKuiGK+SUH2p3KORe7CAJ+j/gnluIY+4nlno43r3HeIcWjXV28FHlhr+AhFekxEXowQHpNG93ZdM9EFs9mQRiaw8ZuDjI1so8GaRl5PCBFXZgUVVu5viqoMJvXe8oZM/jR5pUo/1lgC7Qie1o9lu3sEsmo333cHquYRvSw1U+ZSE7I8e0pGlfi9V/67FolWoACOKKxKlnnWDzOhUNMx9HUTIqnA2+QSMVEJNrJcGWCkIGXnAjvm1ww0T7E6S8WQr/sPqOYCEScWV5MfP7M2UB5R4pd2PlopVvBj1Ig6xn0bpFPejvxWOkX5T+ohrNP4fKq5se0phUJHesmZMrzMG8NGsWgM4iPc3T3sJ+EnKJFHdZUfWMSFd5AbqWzt3KdtqlHxEqam0uMNUh5FtftgTBRGNpzvLawJ8OeuQaJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.009744, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> +extern unsigned long ksm_zero_pages; >> + >> +static inline void ksm_notify_unmap_zero_page(pte_t pte) >> +{ >> + if (is_ksm_zero_pte(pte)) >> + ksm_zero_pages--; >> +} >> + >> static inline int ksm_fork(struct mm_struct *mm, struct mm_struct *oldmm) >> { >> int ret; >> @@ -103,6 +111,10 @@ static inline void ksm_exit(struct mm_struct *mm) >> >> #define is_ksm_zero_pte(pte) 0 >> >> +static inline void ksm_notify_unmap_zero_page(pte_t pte) >> +{ >> +} >> + > >Having proposed that name ... I realize that we call this function >whenever there might be a zeropage mapped (when we have !page after >vm_normal_page()) -- but it could also not be the zeropage. > >Not really able to come up with a better name :) > >ksm_notify_maybe_unmap_zero_page ? > >ksm_maybe_unmap_zero_page ? > Analogous to the existing name of ksm_might_need_to_copy, so maybe we can use 'ksm_might_unmap_zero_page', > >Maybe someone else reading along has a better idea. In any case, the >logic itself LGTM