From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Peng Zhang <zhangpeng.00@bytedance.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Subject: Re: [PATCH v3 10/10] maple_tree: Relocate the declaration of mas_empty_area_rev().
Date: Tue, 23 May 2023 13:59:22 -0400 [thread overview]
Message-ID: <20230523175922.7jf2yfwt7h7xagwp@revolver> (raw)
In-Reply-To: <20230522050656.96215-11-zhangpeng.00@bytedance.com>
* Peng Zhang <zhangpeng.00@bytedance.com> [230522 01:07]:
> Relocate the declaration of mas_empty_area_rev() so that
> mas_empty_area() and mas_empty_area_rev() are together.
>
> Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> include/linux/maple_tree.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h
> index 85559a34a098..c4681cb8414f 100644
> --- a/include/linux/maple_tree.h
> +++ b/include/linux/maple_tree.h
> @@ -474,6 +474,12 @@ void *mas_next_range(struct ma_state *mas, unsigned long max);
>
> int mas_empty_area(struct ma_state *mas, unsigned long min, unsigned long max,
> unsigned long size);
> +/*
> + * This finds an empty area from the highest address to the lowest.
> + * AKA "Topdown" version,
> + */
> +int mas_empty_area_rev(struct ma_state *mas, unsigned long min,
> + unsigned long max, unsigned long size);
>
> static inline void mas_init(struct ma_state *mas, struct maple_tree *tree,
> unsigned long addr)
> @@ -497,12 +503,6 @@ static inline bool mas_is_paused(const struct ma_state *mas)
> return mas->node == MAS_PAUSE;
> }
>
> -/*
> - * This finds an empty area from the highest address to the lowest.
> - * AKA "Topdown" version,
> - */
> -int mas_empty_area_rev(struct ma_state *mas, unsigned long min,
> - unsigned long max, unsigned long size);
> /**
> * mas_reset() - Reset a Maple Tree operation state.
> * @mas: Maple Tree operation state.
> --
> 2.20.1
>
prev parent reply other threads:[~2023-05-23 17:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 5:06 [PATCH v3 00/10] Clean ups for maple tree Peng Zhang
2023-05-22 5:06 ` [PATCH v3 01/10] maple_tree: Rework mtree_alloc_{range,rrange}() Peng Zhang
2023-05-23 17:52 ` Liam R. Howlett
2023-05-22 5:06 ` [PATCH v3 02/10] maple_tree: Drop mas_{rev_}alloc() and mas_fill_gap() Peng Zhang
2023-05-23 17:53 ` Liam R. Howlett
2023-05-22 5:06 ` [PATCH v3 03/10] maple_tree: Fix the arguments to __must_hold() Peng Zhang
2023-05-23 17:54 ` Liam R. Howlett
2023-05-22 5:06 ` [PATCH v3 04/10] maple_tree: Simplify mas_is_span_wr() Peng Zhang
2023-05-23 17:53 ` Liam R. Howlett
2023-05-22 5:06 ` [PATCH v3 05/10] maple_tree: Make the code symmetrical in mas_wr_extend_null() Peng Zhang
2023-05-22 5:06 ` [PATCH v3 06/10] maple_tree: Add mas_wr_new_end() to calculate new_end accurately Peng Zhang
2023-05-23 17:54 ` Liam R. Howlett
2023-05-22 5:06 ` [PATCH v3 07/10] maple_tree: Add comments and some minor cleanups to mas_wr_append() Peng Zhang
2023-05-23 17:55 ` Liam R. Howlett
2023-05-22 5:06 ` [PATCH v3 08/10] maple_tree: Rework mas_wr_slot_store() to be cleaner and more efficient Peng Zhang
2023-05-23 17:59 ` Liam R. Howlett
2023-05-22 5:06 ` [PATCH v3 09/10] maple_tree: Simplify and clean up mas_wr_node_store() Peng Zhang
2023-05-23 18:00 ` Liam R. Howlett
2023-05-22 5:06 ` [PATCH v3 10/10] maple_tree: Relocate the declaration of mas_empty_area_rev() Peng Zhang
2023-05-23 17:59 ` Liam R. Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523175922.7jf2yfwt7h7xagwp@revolver \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=zhangpeng.00@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox