From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86936C7EE23 for ; Tue, 23 May 2023 16:05:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27BA0900006; Tue, 23 May 2023 12:05:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22BC0900002; Tue, 23 May 2023 12:05:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1412A900006; Tue, 23 May 2023 12:05:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 002B2900002 for ; Tue, 23 May 2023 12:05:42 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9E7DE160713 for ; Tue, 23 May 2023 16:05:41 +0000 (UTC) X-FDA: 80821995282.22.D8F778A Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf14.hostedemail.com (Postfix) with ESMTP id BA44E10002B for ; Tue, 23 May 2023 16:03:10 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=none (imf14.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684857792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kv7Tagaecnp/1Em/b5N4c64AlXSthZhnvtN576YCdi4=; b=e0wepjdVrSD/6y/PQVDwomnT7lACOGR/ym2eWsFm2qawuOFYOLrYJI/tsHTCKdSWYkLgKc cY0C23RzmEVC3XWRf0CY3Q99aDwavywaVzZ/AigwVv9sf1uMFbFzD+OYOJDWH4I0wL5oR+ yoJUII7gM97gt4pETFMaEwGOk591dQY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684857792; a=rsa-sha256; cv=none; b=7kXU3jO5wD4W4yBqiIiJUx8MohhugGVdnB1y/9/bwM7Ea1dW/e4NfvzpuEKLKACfAqQ0An yWq8OYaIzfKT2PfXVrFADKIAi3Q11etV8hlc1L43SgBHhUhYvoiHwRYMJAiKpLUEKjfIPB lIlt5ZycMTJJg6DAYip5VLW/Hjd5Gr4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=none (imf14.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id D315C6732D; Tue, 23 May 2023 18:03:07 +0200 (CEST) Date: Tue, 23 May 2023 18:03:07 +0200 From: Christoph Hellwig To: Miklos Szeredi Cc: Christoph Hellwig , Matthew Wilcox , Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Damien Le Moal , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, "open list:F2FS FILE SYSTEM" , cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 10/13] fs: factor out a direct_write_fallback helper Message-ID: <20230523160307.GD15391@lst.de> References: <20230519093521.133226-1-hch@lst.de> <20230519093521.133226-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: omsrkoyyfwa4sc5maty8ci67b6ukknds X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BA44E10002B X-Rspam-User: X-HE-Tag: 1684857790-909842 X-HE-Meta: U2FsdGVkX18vGTvnh5oQnVxhkQnix3GY8X2I7R40uvF6qHSKTwOl/m8mGeB79/zt3aTPErAUYBvDt4RF7/x/LZz6WmtAvQYvd7W12u9krK4qHFELd0jglEyN+exvhodvvSBLZlyFGJnpFZnA49tlXGLxH3PEXe2wEV2C5SApnQzavdrumlKxXMi5zy/nIyRCpmtbFr7wfvp6kvCTXOkHcJt88RNEBA8PpYF19MNiF67aV4ZhgEyP+iXTki9sj/v6hjXqygo6G4mhSYRIgJsorQ3oXivzk7qm1eu2YfP7sRPQYGzGmZ8aAZEQHprNc3+phEuEG4o+yQZn2FVBc0FN+7Gmx9kCIUPs3nINTylvr/DPdfv0OmxWgRZb3tfQ6I/MIiuOQOEuke7DyYipg2uGohbEixKLLYiSN1iqJgzpNCzrqSG8Gmqo+sukK5K6q7yyHlZQ09veciP1w+I3TFtVoq3NRkjzscTW4hMnBozJGaV4XkK2UYmv4PJdXgyY5giWLloExhBrhf3/K/yfqp6j8YFJ4WY/W6TyzIin3cFc6W0n78bwgdFJ2d2t3tPQg1o+UTCyGKoM20Tf93X4tqKwrEoG1SsBxVYyuT13G8rRYPxYRT99Ydz0F+t2hvGZoi0tkseI2hS7wWGZSlmlF5tWAr4+cdOBYDMjfSE1FedH9Jd4OwTejj7Q9YH6WeTZa4c4YoJsD7qXesUjuIWJKFNhwYwUuAReBVd3z9WDZGbbfCEwWy9oD1XoavOyEtG55Dl1iF2g4zuOiSXGzdaLxxATZYRq9g/lpGvhCD6xtzuUQBJOYCyA90Vus/VuezdJsOt+QhwHzlBdDBT2tuD1i6Y4zP+cRaWOJpOGyl92KgyY7FkSqRrQs6rQBMW8elivOtOz7tG0S/iZBG7IuqoHwMA5ANE/hd13nHpOsC/GXeYFDiwQ/rnx9KaXL4r3G6lOa9eLNz468Z5ftAKRStSycRY 9iYN7/K4 L5TUGyBGI03y3oJZkJ8Q3W7ip731oGUDuyIPCjT3g4EiGWMhtGFrncGieyPPSy3UoO6xSDfq5wgksQ2JP+DLwO5X+zszE61G8ESI2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 04:19:38PM +0200, Miklos Szeredi wrote: > > + ssize_t direct_written, ssize_t buffered_written) > > +{ > > + struct address_space *mapping = iocb->ki_filp->f_mapping; > > + loff_t pos = iocb->ki_pos, end; > > At this point pos will point after the end of the buffered write (as > per earlier patches), yes? Yes. I'll fix the pos and end calculation.