From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E48C7EE23 for ; Tue, 23 May 2023 16:04:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D2E4900003; Tue, 23 May 2023 12:04:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 782DA900002; Tue, 23 May 2023 12:04:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69914900003; Tue, 23 May 2023 12:04:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5AEAA900002 for ; Tue, 23 May 2023 12:04:04 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DD247A0567 for ; Tue, 23 May 2023 16:04:03 +0000 (UTC) X-FDA: 80821991166.03.E75BCAB Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf24.hostedemail.com (Postfix) with ESMTP id D6837180193 for ; Tue, 23 May 2023 16:02:20 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=none; spf=none (imf24.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684857742; a=rsa-sha256; cv=none; b=WFA1xIgbDVQD0ncdHzzX/JeQNRUZSTdFUYZeuOcJMmftcvodoE3UIfQP4tAppS8sm7Op8J euiNpMQWPqqj/qPZmCpjUZb1uPUB7Htyz/r/gGhzAISNGYiSij56Gmo6L7icJ6crHZQYRf XLXsKoqQotb7vV9ko7UA7yBNo59HlrY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=none; spf=none (imf24.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684857742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SXa2kFfyTN09HX23wlss7wg+NteNNThYne6pkQeZJRE=; b=y0ycYm3lt7oYab6v54HDHhKfJr1ezLbcuyrERVyTq7Pn1XG/faBDzfCO3H2BR8qgDHGdlF ytK/eDIixZkKyFScqqkRs0ZUAQZO+Aq60WFIiT4ZyzAnQS8r7dllJ1bsYjE05/zx5Uhd8m q+6/FpwBOzcXTB0ljC+jXRZ17c4DKOk= Received: by verein.lst.de (Postfix, from userid 2407) id 8A4516732D; Tue, 23 May 2023 18:02:17 +0200 (CEST) Date: Tue, 23 May 2023 18:02:17 +0200 From: Christoph Hellwig To: Damien Le Moal Cc: Christoph Hellwig , Matthew Wilcox , Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, "open list:F2FS FILE SYSTEM" , cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 07/13] iomap: update ki_pos in iomap_file_buffered_write Message-ID: <20230523160217.GB15391@lst.de> References: <20230519093521.133226-1-hch@lst.de> <20230519093521.133226-8-hch@lst.de> <5c66fe46-13eb-d9d2-e107-cc48eb50688f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c66fe46-13eb-d9d2-e107-cc48eb50688f@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D6837180193 X-Stat-Signature: o4jygo1bargoxa6pq7qu74np64mcuh9o X-Rspam-User: X-HE-Tag: 1684857740-986141 X-HE-Meta: U2FsdGVkX19JRzOGV3TpgLlndZLvaC6TY7Iw1vomX8w/nnvUoSLT+glRkn1OBVROkrJPp//xM21SAzfa4sFthGDH+8/gmFu8WwNwBRK6OIqOleaZcHzWE9aiqIpLOFSPrNDuOxRF6DsqXs4xlUw1zL/Y7MW34aEVfo4EfWBXTV1IarfeI2J3eBDLL4re5+S4To9o1AsBJgU0Y3aLGgZfHCdIU5/GDoxZ3dEDenhILYoimH+r9rkgfYlDCemXvDydhWmhjI9kBIiy4MibqGCBYVVxHTPEVjynhaDvnOwoUR+Q74u1c/7M1t33sAwyRJOGat9QwzHjQsPUnTylZS5umta0L/1Iqh5Fj9wl5K2yjujw1v9uwQH9apED8Kuq2qbcusn33FZMtFrbfteS9LBeflN5QXBAlViR2TpO08qAVGmQgqORZEYcsHofLsU2I1srBBFj7wafqZk6EMv1f95cseoucz6Zc0175d7HOJln2VeNNYEhEAbITu3HeWrF2quXrMgTJs/xx3f9J1/JnI0Ey6UAB06gIn5vxmGb105zuabbWIVE26y3c6RB6IL8yg8tlIyyRZpIh34mFfCt/N9Fy90ncCtmj6Xe2e1vNyOj4oszcExBu3MXK3bN1oydy7WQTcIYaQ/KnTj023mrGXjkrsxdmBJksHdEefGkba9Ic5tuNGKH5iagfZSMwMcVXHUm8g1Sw68yX+DQSTNYHUCoriSdzxNx3Bndw5kKv7jL/ua1I2/6QU3YCNdIeT1AtihiqrMxzu7KWdQ6HI/b4N4Nf81IH72dZC2tDFtqcQETwI/auRu8gLJJrAL+YU4SBxpqOaeE+chmtpLt2j1P5vDxjQ7K7+Q6Yc8LMPUtHPnHU523hVCInx+wrGITrjULEj4GmVwcmKEf7WuqGEmYet4z8e0wPPJzABjjHcmMd2zwn6B42wTcTbZOkKP0kBw+oTWwPaVT7Vqzjcg3y9IQwMA Ot6/cbEe Zw2itjRw2CqBM4FWyIvQfosu8kn9KS4+IUW/u2ovySaHBguMfptLI3cZvDHt2xoY4Qdjwf7eQMjOmDivxjhmTzNwzof49tPT+Nh0j X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 09:01:05AM +0900, Damien Le Moal wrote: > > - int ret; > > + ssize_t ret; > > > > if (iocb->ki_flags & IOCB_NOWAIT) > > iter.flags |= IOMAP_NOWAIT; > > > > while ((ret = iomap_iter(&iter, ops)) > 0) > > iter.processed = iomap_write_iter(&iter, i); > > - if (iter.pos == iocb->ki_pos) > > + > > + if (unlikely(ret < 0)) > > Nit: This could be if (unlikely(ret <= 0)), no ? No. iomap_iter does not return te amount of bytes written.