From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CCC6C7EE23 for ; Tue, 23 May 2023 14:12:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FD72900003; Tue, 23 May 2023 10:12:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98379900002; Tue, 23 May 2023 10:12:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FD8B900003; Tue, 23 May 2023 10:12:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6CDC0900002 for ; Tue, 23 May 2023 10:12:53 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 26D41A0606 for ; Tue, 23 May 2023 14:12:53 +0000 (UTC) X-FDA: 80821711026.14.DD7A0E7 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by imf20.hostedemail.com (Postfix) with ESMTP id 703971C031B for ; Tue, 23 May 2023 14:11:15 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=hm0QvYO2; spf=pass (imf20.hostedemail.com: domain of xu.xin.sc@gmail.com designates 209.85.214.193 as permitted sender) smtp.mailfrom=xu.xin.sc@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684851075; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1H4Y9LOWc0olNcXTJ1OgzMgJyqMLn68QmxQ5MJNIIbk=; b=0Aml+hcxtDy4x5/AUHRS1NMfxlVZQXD6GalcQNSf76v18ijTHX7Bb2mGplzoPuyjk6Zuys A4ioIaPOgB0mdMDv6s2Ifk6FXYmVD3nK+lHKUFJcetXC20K4z0RfksjDB8dQo2xT5fh12o yXyhoNvfUjhY4tZWVY0PO2zfcsBwsCc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684851075; a=rsa-sha256; cv=none; b=gpYdeVDykRlxVG92f99HCLOtn0eCcQxdapTZxi8aGaOS6pRFRdvynJ3fZFAldITxNGClaf UfEc1CK86FZZX5BZYR/bF0KDqy+OMBZpsEXB/3FMoSyoXm0+zsVoyohDTJJKcCqJdTh+tZ EQvhmFpqEE4r/dPhnQ1VPd9ftLzEfOA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=hm0QvYO2; spf=pass (imf20.hostedemail.com: domain of xu.xin.sc@gmail.com designates 209.85.214.193 as permitted sender) smtp.mailfrom=xu.xin.sc@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f193.google.com with SMTP id d9443c01a7336-1ae507af2e5so35635245ad.1 for ; Tue, 23 May 2023 07:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684851074; x=1687443074; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1H4Y9LOWc0olNcXTJ1OgzMgJyqMLn68QmxQ5MJNIIbk=; b=hm0QvYO2s07hmkORFZZR4aVyZ/jqwyle0dMvFSk5q15ngH4GxUS3LLxTamXa5eElWb IOeM/maPPtabDfU38GwHjIrtz342LMcUoGsDWCVgOWhU9XSyQ/I0NY/k85ptEnu/KgVN BHRGywKBmdEkHTGKKm4f8ndGWoqzUi9TJL+6nftZkBXFAXyXmVqmsQXAX0auRKSPjz56 Q9l/vZTG9ApPNNZY4IECfKDjWpMw6liB4F3zHjtfICmFbRzWJHb0JH6qH12Q7AgJlGDZ CuqEJQS/9sM+JX18ywoGohtrVQiMB4qVj//D43zfO8X1/+FWPQOcPqRCnOrPpHVU2p+R +jvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684851074; x=1687443074; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1H4Y9LOWc0olNcXTJ1OgzMgJyqMLn68QmxQ5MJNIIbk=; b=LahtGvVHBi2eoBOuSbbwNyhJ6KaUzuhZ5ot0rwldD9vxgXG9iWAQKnPlGDyFm3xqAj t9ZEIJYCZlbJHfE+kQj8uSXOqtEQTNdMcG6VjfU7o551qEiAiXLJVEiUyGcxoX3+WNao remMBcT4HbbZzBu+ces7+u1BNX31QdWUGCHLE0gxUHcCddZjx4upUvtqQJoIuY7BSed8 h1ijb6aL0C5p5hlnE6uFZWFrBYJirEdUTFv8OprZlzx3g9a77fLO9la98H1RC1bujc/h 4FJbIeGrmQGnbk2LtqPd0fLKsZyHmYFhQF8kfuf+C1lkxcXxHmmq+ev8Rz/B/GApbcMJ 2SpA== X-Gm-Message-State: AC+VfDyUp2CvnIyOa+Bt+ZgT4jeZIA9sw40TSa9gJHgLTlmA8kG0fttJ pLtvsG4mRZwRfpk4+4IOdNI= X-Google-Smtp-Source: ACHHUZ4ycx9P+8OCyOMv6MFBgubqypR+yajC3BrfXalqIHe3gYxh3BEODb7MOEU+664j5MNHZkU9iw== X-Received: by 2002:a17:902:e5ce:b0:1a2:a904:c42e with SMTP id u14-20020a170902e5ce00b001a2a904c42emr16753653plf.24.1684851074083; Tue, 23 May 2023 07:11:14 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id u13-20020a170902e5cd00b001ac937171e4sm6834511plf.254.2023.05.23.07.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 07:11:13 -0700 (PDT) From: xu xin X-Google-Original-From: xu xin To: david@redhat.com Cc: akpm@linux-foundation.org, imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn, yang.yang29@zte.com.cn Subject: Re: [PATCH v8 1/6] ksm: support unsharing KSM-placed zero pages Date: Tue, 23 May 2023 22:11:04 +0800 Message-Id: <20230523141104.7029-1-xu.xin16@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <4b7e4d48-f0f9-c0b0-e8e1-2678d0306252@redhat.com> References: <4b7e4d48-f0f9-c0b0-e8e1-2678d0306252@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: ogsyka1btphqhhznrrmq9ygdu6xxtwn3 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 703971C031B X-Rspam-User: X-HE-Tag: 1684851075-865930 X-HE-Meta: U2FsdGVkX1/tZ/9JaqkMK9/ItId+tF6bMI8genkNbOPBThpI+CyswkkLL20yFwjeYodNfmILMWlohSuQ8y2+Gnp/wz87NW+GDwdzbSvoDpvocD1P3fYVLTkrFy+iovD3n0jdrS2oaNYRIh4BVrTiceCR3/+SYV6r+PPqwhd56ByfdVnOiatSHzSpfHl7xXDxq686CG5tVsumjIBeiMX2f+qt7okZfxo+HJSmPwajtqwuFzRjwWqgQrqCs4n23TREIjrDUietdhNQmI77xpBlBG+k2eQ4cK7YSzax0OS9cyzKR+2S/SI23FwDVAbIqtoz4LYW87CYSe57sCwkft/9OuLM2DjgpunQ6P8SZnuNbzU+v7zROqgAmzCg/7AOJlmMZBK8MDZ4QS4UL+3OKbdigTu00UrsOMUX8SzQ5VAxmb2GALzjD3BHrKfSmxpHGdH1Cg3Tk5g8eJwrSovVcNl09AxpKrjwNjwleC7qQSxuHmU9xTVwtEXR1+186iYFRw+KsIkf9vaylH2NR/YmEXW+qf9/CxIV1+1VDZkk82JFBufkrS2UGbcFg8Pg36QNvmSH5Du06q1Y5zis+SdzHHrmm2juu9CL1h4ss2K5cCaFjQExGAw/LqW/wIni5wD49iXfUL1hMihAFuvQFNY2se0FLBJbUYz28O/YOFSLV4zhYETyEqXHO2i7Ptpk7e7yzAmTBBQjf4/cQPgFV3/o5D5Rybq6gzcZB0LEF1E1lLkbpx31YDJ0g7HjwSy1/aFf+tOl45JOSpyHSHNDq25MJnT76dROaTIX1u8Gk/cIXNRzXqwlrqXW2EKnD2PwKgBTjDtdrP9JsguhjRxIiXUweT/BabciryxYk4oL7lhB/BAazXfRwjpWsW9spGuAIOrHjvUuio0xCtNhnSImQHjlbzEZ7NKah/2JPXR4cep7fZ3qBykvABwpmQ3UxKhxMPiL3k5ncfRVfPtGz4PP3toJfa3 pVBRQ/yT g3dqMA6B3oV+pCuiq0IBYwXbI0TCqqKt+UG+9ScxSSdMCn4ZO/NReV+ty8NYQF5RbeqUqSeGI+0UD6CV42kQVRoToWJsxfwQtuTWY/HnKJg7kqBD3G4TWOBLugOUOMMU6p3R6S0MzH5U3MMz3JF/sHixEJLyiD/ChvyBDEJGAFYdnMVycmkNE46c2JS0YjixZJfsVttno8a4M/v9ahcHqZyZXy1r0DNdiJt8iiiOpmJ9nGsu8nonEXIb0yOJ4Hr8R8ZS0Se8LG5VOgX9E0I/+B0ZcBAv78DXyl3sfXOGaglareVD5KGFDy00VDdN9ZUFakJexpbnzOQPul/vYeYE5YnahOLJItWi2ccnPSav+Rzxd6HBE8zqM+13fN4s/lq61iJXYOZgaNNhioe/iREhszAlT6FAk0XzFVyhQQ5oPGRk/5Ma7kcQ125N01Un9TH3v1AeEEyPvdliZcfTGAKNFrPuToY7o9UeQYk5tSAkMXPaAgTw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >>>> --- >>>> include/linux/ksm.h | 6 ++++++ >>>> mm/ksm.c | 5 +++-- >>>> 2 files changed, 9 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/include/linux/ksm.h b/include/linux/ksm.h >>>> index 899a314bc487..7989200cdbb7 100644 >>>> --- a/include/linux/ksm.h >>>> +++ b/include/linux/ksm.h >>>> @@ -26,6 +26,9 @@ int ksm_disable(struct mm_struct *mm); >>>> >>>> int __ksm_enter(struct mm_struct *mm); >>>> void __ksm_exit(struct mm_struct *mm); >>>> +/* use pte_mkdirty to track a KSM-placed zero page */ >>>> +#define set_pte_ksm_zero(pte) pte_mkdirty(pte_mkspecial(pte)) >>> >>> If there is only a single user (which I assume), please inline it instead. >> >> Excuse me, I'm wondering why using inline here instead of macro is better. >> Thanks! :) > >Just to clarify: not an inline function but removing the macro >completely and just place that code directly into the single caller. > >Single user, no need to put that into ksm.h -- and I'm not super happy >about the set_pte_ksm_zero() name ;) because we get the zero-pte already >passed in from the caller ... Oh, I see. Thanks