From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A476AC7EE23 for ; Tue, 23 May 2023 14:04:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40A7F900007; Tue, 23 May 2023 10:04:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BA8A900002; Tue, 23 May 2023 10:04:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AA57900007; Tue, 23 May 2023 10:04:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1B368900002 for ; Tue, 23 May 2023 10:04:49 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9508914057C for ; Tue, 23 May 2023 14:04:48 +0000 (UTC) X-FDA: 80821690656.28.A481624 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf08.hostedemail.com (Postfix) with ESMTP id 59CA4160157 for ; Tue, 23 May 2023 14:02:15 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=eSaM0SKE; dkim=pass header.d=linutronix.de header.s=2020e header.b=dmb7T4Qo; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf08.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684850536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=AhYn3hs5NO1EoRmwAp1yAaGKnTBrw9UeYsFRRTOeg+E=; b=mzFzR09L9T66Jm93xtaZvQVN8YFBOM/yRifg3dGFE/DziwETRPgGkwuipadhkGty7MZzvr 84YzPovRLME4vLyQSi+6ztXumIMtg/J6R6/f9OKhTgbBPolqzhGXicmwy1187pcr6sw+b1 gvDnM8x7DNIUcV+KSRE+e+bVVsAvd8I= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=eSaM0SKE; dkim=pass header.d=linutronix.de header.s=2020e header.b=dmb7T4Qo; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf08.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684850536; a=rsa-sha256; cv=none; b=QuKK1AaVUNCCjblOuBp6QTlQxF8lB1ldjuI2BLprAAAPJn2bu7Jgttsol9wNUDseQ9fw9w 0TNXq6beyMak5RGZBlCpV19D+MD0kErxjH8F6iQbrLhHc2Nr92L6+vrxtnP8Yd9kCiBMjU nrfSroKb1E/NCEJlJCzg5R/UTz8QEdk= Message-ID: <20230523140002.690874212@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684850533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=AhYn3hs5NO1EoRmwAp1yAaGKnTBrw9UeYsFRRTOeg+E=; b=eSaM0SKEPbzU7WfQgZ1kFUheSi1XWpqxu3GnG2f7talcZ7lD2U1TLcLrKpIKUxMQgK0gGD Ras3fqy3JziFztZQAaxtJV5vQybLRsM7f1L83y9pNO1CxDRYnMh//cLyZGkt5CWuz6oDxL fJiTQQIdmZq2/lYkPBoeOw4w8wXbVT5ztoXB4FDx9B+eziVq8TA42fuCGEY4AdPFrtHDoZ Fqp4AvcpnX5QnfRblTedSlYJNeHIGCLgAU1ceZZ4mmR2lGyX6ZnfQ3/lHZgpvNLE0k5PWF S1CafBGrPrAymO1TpQ0bX3bX+aD5su95FMnzYRxIC7s+XR9jtOMmSmFHtbtD8w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684850533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=AhYn3hs5NO1EoRmwAp1yAaGKnTBrw9UeYsFRRTOeg+E=; b=dmb7T4QogLctYltN4z60XH4rQQmI71XS4LQWBnII8prowgFgpZb7Ev4l+kojwUETlpZuwF hD06DLfW+ZD7CXCQ== From: Thomas Gleixner To: linux-mm@kvack.org Cc: Andrew Morton , Christoph Hellwig , Uladzislau Rezki , Lorenzo Stoakes , Peter Zijlstra , Baoquan He Subject: [patch 3/6] mm/vmalloc: Prevent flushing dirty space over and over References: <20230523135902.517032811@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Tue, 23 May 2023 16:02:13 +0200 (CEST) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 59CA4160157 X-Stat-Signature: kygr7zh1ptz7bzyg3gf6mrfhum1eqq9z X-Rspam-User: X-HE-Tag: 1684850535-488379 X-HE-Meta: U2FsdGVkX18ZtuBzMbV4NInyFr2DbhnHT6Zt4H3fRda3uOEGg+t38FNqSelZlEOd8BjgcJl695KL2L3F3egN6jb/8v1carhU/Y0Ek3K1Ym0hdVE15bLbNAxnQwkDexUuf4ZKXfk0cti1ZYFb306NLL82pIsTNgdt3aijQ+KHnkeUzp4dm+MnhHqyWIXnxHlsAiWfYxIHZv0PRZrjSuJCm3VWZLsYc63qU4Hmc8LYSwCYqd+JoUqZDDjkAo1RrfJdsiI3b/l76bCoCjaGjL2azLWShbrJLgchroh4zJL5r1BVC5v5Cl0B337C0eWwtHJGKpScTA/3hmSLSMm1u28HaeoSKPJBSlminHjPTjsns0lt2v6uQtzFDkK0J8lyjbrr2khlA9UCoDhMsxkWVqZurzRr27og1OeAdb1Vn3LLs2AL2ZwD9uq4IcxKJUV5a6cQlVBFEcFD/IJxTfK51E3/XA+3e9TzWo+jPMGOdjM9ZA1iL5kpDBfpmNP/jLdSTd3UUISzO8X2jWWi/UUZxE2kjtEsgPuBFGDFraKEbZgOko/8zBTo6b5lCFleJXa5lfj7YFtIxD4TSYeiw09V9HPWKEJmn/TFonn6RTcI5iD2vxzZMHRaxJp64XR9GARKC+S9p6fWA1ZKU3waEz9JP1q3L+YJlAjuz+3qtfgkFfiCY35IqwY191bO/MI1cz9YX28tIGcPvoFO26IVraMasiukEv+AU8JDxeLSbUy+ZkHAicChcWnKhqLis3MkO9PfdSvjxkCJ4UiDD5PXm7WwsNP3VAnJ2DdHriOLwVveoKtyV3+2rvu0UfssLkY6ZlbcskQilxt8hhe2go5NFoeMza/R9dzKz9tTJ3NkIhqVbZg6zOWSm7Mghj8xBfwWDHstbkqIdBn/11UcuzaHXB7EUDw2Y8wtRD68wu0alGKyGkT0waUHEADZvUAD4ZrbVFd9PTp59DeyVWTKnT5v9hmuMFM lOY7xCUB Yt8lF0NVeNZG1PpE1U/7Zu2Km1CwuPgmiM0KMlWHvbfGT50N/uzGG301O1PBPdMa/eGylhJBWWdoWBHhJg53fk7aMB12YPj8PJ7x7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: vmap blocks which have active mappings cannot be purged. Allocations which have been freed are accounted for in vmap_block::dirty_min/max, so that they can be detected in _vm_unmap_aliases() as potentially stale TLBs. If there are several invocations of _vm_unmap_aliases() then each of them will flush the dirty range. That's pointless and just increases the probability of full TLB flushes. Avoid that by resetting the flush range after accounting for it. That's safe versus other invocations of _vm_unmap_aliases() because this is all serialized with vmap_purge_lock. Signed-off-by: Thomas Gleixner --- mm/vmalloc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2224,7 +2224,7 @@ static void vb_free(unsigned long addr, spin_lock(&vb->lock); - /* Expand dirty range */ + /* Expand the not yet TLB flushed dirty range */ vb->dirty_min = min(vb->dirty_min, offset); vb->dirty_max = max(vb->dirty_max, offset + (1UL << order)); @@ -2262,7 +2262,7 @@ static void _vm_unmap_aliases(unsigned l * space to be flushed. */ if (!purge_fragmented_block(vb, vbq, &purge_list) && - vb->dirty && vb->dirty != VMAP_BBMAP_BITS) { + vb->dirty_max && vb->dirty != VMAP_BBMAP_BITS) { unsigned long va_start = vb->va->va_start; unsigned long s, e; @@ -2272,6 +2272,10 @@ static void _vm_unmap_aliases(unsigned l start = min(s, start); end = max(e, end); + /* Prevent that this is flushed more than once */ + vb->dirty_min = VMAP_BBMAP_BITS; + vb->dirty_max = 0; + flush = 1; } spin_unlock(&vb->lock);