From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F72EC77B75 for ; Tue, 23 May 2023 13:57:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EA5D280001; Tue, 23 May 2023 09:57:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19A7C900002; Tue, 23 May 2023 09:57:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06271280001; Tue, 23 May 2023 09:57:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E8D2F900002 for ; Tue, 23 May 2023 09:57:16 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B0BCF404FE for ; Tue, 23 May 2023 13:57:16 +0000 (UTC) X-FDA: 80821671672.29.B3E0D30 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf04.hostedemail.com (Postfix) with ESMTP id AD8A740005 for ; Tue, 23 May 2023 13:57:14 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=naCmkZ+g; spf=pass (imf04.hostedemail.com: domain of xu.xin.sc@gmail.com designates 209.85.216.65 as permitted sender) smtp.mailfrom=xu.xin.sc@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684850234; a=rsa-sha256; cv=none; b=EdMSJJHJBXHBdjZm79jHVat0E/tf+p5VFQQ2YJbFCKRDo4PI5oMC0AZTp68Cpfd6j9kQjd /Pei7+LMj4wm3E4nVMskIvhkvWT6wP7Rb/EKnt45lU1bgA85499AgKxzNi+GE0pcee+I6Y tFdxzutl7xB4+/zhcRdf7/kxafajIsk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=naCmkZ+g; spf=pass (imf04.hostedemail.com: domain of xu.xin.sc@gmail.com designates 209.85.216.65 as permitted sender) smtp.mailfrom=xu.xin.sc@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684850234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RE5pljgoQG181tjwuhg4W/JZgWLsjKIcNLZqb+B2pwg=; b=rj0ZTpwWjzhFpbi5qaftHGEVWSwnV4z10MPIezfBaPuiujaMDS8J7Dtjkz8irAMb1vEtbY 0ysIPej0/jQ1GLbylJKQqN52LIN2BV1tBdLGIsEesaOlEBkvuQXvXgiMYgsYHHcgZd1+6p WjFkNJFjWymxHZHMPB7yZtQ+1y5gPVc= Received: by mail-pj1-f65.google.com with SMTP id 98e67ed59e1d1-25374c9be49so4806058a91.3 for ; Tue, 23 May 2023 06:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684850233; x=1687442233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RE5pljgoQG181tjwuhg4W/JZgWLsjKIcNLZqb+B2pwg=; b=naCmkZ+ge6/s2VO38wiDl4LMWZA24oDqNGbSyjWkqLEEpsSrL2UZfnEbbWaQwyahab djCRmY33ZnhyT4jLZLEdTnPT4HN1BqKmpG5k9BYhUbHqfHj5+jMEvv4jtxX1C1w4b2tW 26ufViFYncJYmgNOqcaB8+wh+SlPc5JJlA9PldXPXmaDE5GcogmwOWirr/1Tl2sd/qOT W2g9NUZFJN1hjZqqe9q3iOps0XxyY4T3xAtZk9+T8wr12wn4KptpmrAVBNVaOaUSz4Lu vE+CT3YvLckAixfu21WF+eve7jxbwYOsKeI3eDd7dtO+thGK3Au3oVGzTxB23gcnAAi2 gbew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684850233; x=1687442233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RE5pljgoQG181tjwuhg4W/JZgWLsjKIcNLZqb+B2pwg=; b=ZiZyqIJNIXew5nSy48pp0k4lPXI5K8tknQimWzb52a2r3vJmDFzzdQ/nkFXI2u9Pmq kZRTKwkVovaxqZy/zXWa+b4aLA3NM6xoF5BgpxHx0nWlkp0Lx0fy7rg+2+4+K3P414Z2 Zjcgf02oqRbVXjdIRHZQGErGOikv1FJtK/BnrFOYWcutnjeNNi9f+Ycsn++tVQ/LkM4X 5n08xzgDRw5b74tmuQzDircSL0wrUgqfsJRguOAvRkND7qyVD1prs+uL+ZPvDCiWEAzF M2xuJp/5RBfGcfMQTC30uLDheimxdjCpYJ+pVjJK4fRN/paLlRcYlfoo8l8Ftqxq1sWL lpVg== X-Gm-Message-State: AC+VfDzFRdRWZVPNH/AG5mioxKwEkAN+dDpIHIzZHM2fe37mHSSm+mGi vXW4/2wnQRE3uCJhcSdeQdqb9mRM3cf7Hw== X-Google-Smtp-Source: ACHHUZ6Id+zBNB8WNjEYqXttPKy16f58rmZEC2yONMtyCsgnTTKt4TcgKh5kBq0/CauftKSKxHUivQ== X-Received: by 2002:a17:90a:71c2:b0:255:70e1:e41 with SMTP id m2-20020a17090a71c200b0025570e10e41mr6031679pjs.19.1684850233201; Tue, 23 May 2023 06:57:13 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id s31-20020a17090a69a200b0023a9564763bsm8226319pjj.29.2023.05.23.06.57.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 06:57:12 -0700 (PDT) From: xu xin X-Google-Original-From: xu xin To: david@redhat.com Cc: akpm@linux-foundation.org, imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn, yang.yang29@zte.com.cn Subject: Re: [PATCH v8 1/6] ksm: support unsharing KSM-placed zero pages Date: Tue, 23 May 2023 21:57:09 +0800 Message-Id: <20230523135709.6902-1-xu.xin16@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1925d301-462d-6b33-8867-4e1646b2dbd6@redhat.com> References: <1925d301-462d-6b33-8867-4e1646b2dbd6@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: AD8A740005 X-Stat-Signature: j5idd9tristnic3qe9wfs7opr3jxoygb X-Rspam-User: X-HE-Tag: 1684850234-675511 X-HE-Meta: U2FsdGVkX1/nFsoQFyT3C6K4dNHYUjfrAjJJUoiWUNgjNlXDv6P+zMR3ZL/4DD0Xv+F7kSiLF47TH/K/xhu863AUHz74rF7ZLr9xr6GP4lG5hq2rfBsOB1pe/82oxDreApLH6e+IgrNtEDD8hlIuPwNtbVxOyPmN/fwSLJG35IdQLO4MvfhnlGXHXV1q0OVeMpRootuQEPQGQ4Mx6nSlbtZwQ08EvJLYGMTI/wPPcoLFaea6XlKWpNqLXRRhYbygT6KZTgePn09XkcV7H56MUVyjxf5xgHsXGUDH8Woo/n4cYnRgu6vZUkQiXl0c/TRqAFplxQnSPdDb5nOJ0taJ+Zctwy50n8cRICR8BMKR510digWHQARUsgikgCIhREsYHzDg+JP3KPW0RNdbJMIPdMyoyAmX5z8sVnBFAD8gxLs9dBqOy58TIf7M8Dz1SFitBm6iTGsLOnCe5UyW85OIiwmfw9+qnFrC7QIdjpNjrMszkjEjdGEGUpwX0RA0KOvJ1XuutyFG9i31HqWNWKz5DCSMqM2vfwkfBBGesc2hzLn5lzyChT0Mxf1+VuBJFGmwBK3LkI9z+1veO99ZGgf9Rk/oXBfiQNgr6lErSDkFwi7P3MmejyGome1dv438JU6PZln7428dlmvhJFiJkhhMvJqTDtalOohY2fEFfSi9FxyvBtSAbdEPCQj0UMTcc5HRvCKt28rIrvfq2WjA49SdQFiMcaWtiWB/C/G1cr9GVuHTs3VLiZDbm6iozy1UFp2lmadkiFJd/FLR9DhFZKKpnbc0DWTI+L2zzmiK0IcZO0gJDM3Q/DkdXXbVK/hhjq6ya+2JfzeRXB7Nu6kyV+cJjf7W82VMq3lRaMqdjOeRC5yWoHT/FnSHqOZyvNrMV40fcV7XyzobnSdbwk/HTPyIEFskjgrZqaBBgJp5cEPz31Sfv69+q1yfc1fpRv3I8YihJL0aPJKa38mdL6eBjXR ZFqLHdAt aNW/JDO1OAimuRlnWrjBkmPhvZJTHhFjxbU4I4B9LuXzPSMFXH7bQHkudD0WtfFRIsMXb/YITRhGHRSh9A7T94YKHG2XvpS1C7BvIeaWo6O3QaPxJEsamfy0jZPmzmtKRzFZpkuKrYkvixU/UYt85rmps1+mn3k8CcNpCO5UjHUB3B+xhUwuycMX67XItGnFF+0rh3yEzI/Hzkyva1yXZkZ4FxQVFQk6VY+02p9Vs/wvGa3DI19jxshSyNL5sMoSJD6Xdp47Gvk+y7fkktDfIH4pf30L2HA/eB3zhEK9BACXk2fS3mOZwbRrDceUkntanM1vpv1OLyxDNPg9JOjMVlt98xKyuZ0v9fwA39N+WjeHEuWox7S1PEkHTNprLZ8xY2HVc8+Knx38+3ceP57eG0TNlcOrWGvKTY3ePhOk8ykHmjZeb4fR1bpen8URRKEl4KxB7yLHQ4HJbTOMTdxieD3A6vlFkqr0aAbaYKrXgC/0oqTM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> --- >> include/linux/ksm.h | 6 ++++++ >> mm/ksm.c | 5 +++-- >> 2 files changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/ksm.h b/include/linux/ksm.h >> index 899a314bc487..7989200cdbb7 100644 >> --- a/include/linux/ksm.h >> +++ b/include/linux/ksm.h >> @@ -26,6 +26,9 @@ int ksm_disable(struct mm_struct *mm); >> >> int __ksm_enter(struct mm_struct *mm); >> void __ksm_exit(struct mm_struct *mm); >> +/* use pte_mkdirty to track a KSM-placed zero page */ >> +#define set_pte_ksm_zero(pte) pte_mkdirty(pte_mkspecial(pte)) > >If there is only a single user (which I assume), please inline it instead. Excuse me, I'm wondering why using inline here instead of macro is better. Thanks! :) Thanks for reviews.