From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F0BCC7EE29 for ; Tue, 23 May 2023 14:27:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA37B900003; Tue, 23 May 2023 10:27:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5273900002; Tue, 23 May 2023 10:27:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4180900003; Tue, 23 May 2023 10:27:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8B12E900002 for ; Tue, 23 May 2023 10:27:38 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4725D801C3 for ; Tue, 23 May 2023 14:27:38 +0000 (UTC) X-FDA: 80821748196.11.BACE19C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 9B3EF2000F for ; Tue, 23 May 2023 14:27:35 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of "SRS0=q/om=BM=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=q/om=BM=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684852055; a=rsa-sha256; cv=none; b=l39cyougJA6e27ZLBHsicC2i2FV8hzTIqlpWx68Y/OwvWvXVtPSEBrKlxsE5mWjS02dyu2 TgcYz+dE90HCFLF3es3xxVrbFTABfkO7u7DnulX7xVmYbyNlzQyxBi0W/IpXAe84wXnrdk KEiK4B8M+aLqIJStKKlZlHajUZHO7XE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of "SRS0=q/om=BM=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=q/om=BM=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684852055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sF85EQt9LGfwLlGQXrHHpM3wJe4mjcfGe+QqxQuvKgY=; b=TSOlBk92JkC0SaGGD1l7SUrQnXeEkXS6FBHu8ddq1Tpk1KlDHeRCHZziW+nUKZR9mqfeZz Cg5RDY2HDPkjWYBjqguRjaATx4w8460/UAUiIwb9yi6XWQc3cPRvuUR4DEgerYs65Qn/zU wIqil3gBgJPN+iCOoqcIAFI71rdIcAk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A8302632FD; Tue, 23 May 2023 14:27:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A79D9C433EF; Tue, 23 May 2023 14:27:32 +0000 (UTC) Date: Tue, 23 May 2023 10:27:30 -0400 From: Steven Rostedt To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v21 26/30] splice: Convert trace/seq to use copy_splice_read() Message-ID: <20230523102730.6deaca47@rorschach.local.home> In-Reply-To: <20230520000049.2226926-27-dhowells@redhat.com> References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-27-dhowells@redhat.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9B3EF2000F X-Stat-Signature: 4fea9t8xqxrcmm6u7mf98d6cctx9uoba X-Rspam-User: X-HE-Tag: 1684852055-123774 X-HE-Meta: U2FsdGVkX1/y6i0jqf9DW6CX+hAZS3ifR6UmJnAvXOlIlkff0xDpzVMWygtPyuxBpiExLC7bKwg99mjGikdCjrSLyaTXg5cy00xSE6YZ5dtHQFHhcEPCi3PPgXlURKDsU6zrb70rRjYC53gV17We36jTDh6ME/13buMUB/Q546gNXVfa//EaElX6E4HE+SI8f/gJIJSDH76CT1YcoxX91HvgD715YD0fOCpAPb3/GiUKVPuqPJhsedux42xwf+MN8zXhqz4CDeMDo74WdH/ncjT4iM8Nr1bUYwHHqlpslMmOj0OA0YYaCBMID3NFJlaJqN6f5u9KWZSI6ECJf1R0KK/jHWWrp91fyoDOiX+SeJW6SJQK4ncHlzw+4043o1Hm+Je2mB0kvnedaMJmj3XaNFn28VPziA4SfG8PEOmEWjUpjExO/NMxa0D+fh7BpKpQ9FyzgKeidd/0ZIgajnfyJCSneDbJmYZEp7hCNV3IWUV5tHML1CGL4tW5lzU1DtiWsblTS2PLa7N7uOOr85bWUsxkkh/kmo0fCRRd4a4xOGXqZTWBVUH1nilSkWBKV4NMCpuiLNNhQrVrRzGn9rpRQh4vEi5dCKiUssdIEiezksIlyPaLUHHk7dmDhzrh5Ic50g+k9PrIDhH3slBRi45wWrzP4ZjjlmeXiykGW7uGjwe2/lkq1G097UI2Q+lmOmX0lfHI7PStCNfqJr6FFkuvJ/lyh0LVeJewF2uUnUeYo5I6Z3G55ySZccuzT+qgqay1pbNZpEzNk0UqKSMPHTDaac/4l6goQ3Wd/kGgmL/q/1ckZGotY9qjXn9qZbWESJvA/bzWqM1+sw7a3kCbmabcsUdBMO8EO8ZhPP1+BcyIl6CIFQRxZvx6rXYWDUKQIQVULPLW7LDD8z3C9DC+K3pIJxykqB+nUg16ahWWg766fHcmDOi9oNrk6SqiEdqEzz+czdvrV3xvEiJuBJ7NpEY K1Zm0Bv/ POrGxRWizIk6oAJJqg5BmcZV96DMxIzxFmko6RZjYcnmMsxtAb0FHBVf7h/ZNVIvbwLWrYNbZIIR+VI50s6p+ksN78/IyEGmwFFuY1RkaBQ8PxtRiHHSnRDSZauRXPfKB4Jx19XuJ7zZeIh45ih/dT+/YAEyJ6q9eLO1zXjNJ7TeG+2YMFKB7fdkzsc6cWoY1mTs7RpfVFr55IjtCpm0ntybJ+qIk3rBbBdcPs/PhnOf5MNSX7TIVE44kD2QKrG7Hnwa2Js8BL5ZxuxbXBH0sLDa6d1KF0CJh/S5RXU+PDO5EyTTStxiz84qDI73OyPFtLCBpGiROsDszK9si9BH6SgpbMMyOvwrXj9tcasF+MY4PcIwXkEsTP8wMjvJA3Dae9NDoXKte2GV3fXlZ8EfSpCZoQ8YAQEZOkYUjbtTaVXmXW1sEX0RsrwIPkkaStEoayvzgG/jyarHbfVk55ku5mv9iKHDPLBd+Cr1MLgB0llksY/cWnWQmQS6Qj2Tn/TF+jZJROJjkcxEN+Gffgh94Qv1Fi4ELw63HJHs6kpaENSjVsLTq2EtyWJDbXwt7TOFWgRhLQMYng3PwFLY+tsnH1MkHvVOZ4lYx3yjJN5OfzwPUPTiXcxd6nSb/bhGGJsqHh9qQm0tjdU3+wqVLapeanfmm4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 20 May 2023 01:00:45 +0100 David Howells wrote: > For the splice from the trace seq buffer, just use copy_splice_read(). > > In the future, something better can probably be done by gifting pages from > seq->buf into the pipe, but that would require changing seq->buf into a > vmap over an array of pages. > > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Al Viro > cc: Jens Axboe > cc: Steven Rostedt > cc: Masami Hiramatsu > cc: linux-kernel@vger.kernel.org > cc: linux-trace-kernel@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > cc: linux-block@vger.kernel.org > cc: linux-mm@kvack.org > --- > kernel/trace/trace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index ebc59781456a..c210d02fac97 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -5171,7 +5171,7 @@ static const struct file_operations tracing_fops = { > .open = tracing_open, > .read = seq_read, > .read_iter = seq_read_iter, > - .splice_read = generic_file_splice_read, > + .splice_read = copy_splice_read, Anyway, for this change: Acked-by: Steven Rostedt (Google) -- Steve > .write = tracing_write_stub, > .llseek = tracing_lseek, > .release = tracing_release,