From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39638C77B75 for ; Tue, 23 May 2023 08:07:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 973FC6B0078; Tue, 23 May 2023 04:07:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 923B1280001; Tue, 23 May 2023 04:07:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7ECB1900003; Tue, 23 May 2023 04:07:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7297F6B0078 for ; Tue, 23 May 2023 04:07:45 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4598540682 for ; Tue, 23 May 2023 08:07:45 +0000 (UTC) X-FDA: 80820790890.24.99A1D3A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf30.hostedemail.com (Postfix) with ESMTP id 4550D80002 for ; Tue, 23 May 2023 08:07:42 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pdiqQbjb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Kr8JgWOT; dmarc=none; spf=pass (imf30.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684829262; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0wGcfOfd6nV+e+2j2HmOyRi8LKJabDurCag/9oAnpHY=; b=kuFBj8z/M1roSdS8LcFYILeYiq7P46wWjldoJT4Gj6Z9jPgwh1/pEjVLHaBjVLcFCj/O4s tSe035DkDvuwhmjMhi+c7tkbJScK50cEM4eSgyzFDCF2b7i+6UXOwfGI4FnaaUG0OkLIZZ AQy3w1nQYOQi1KE83XkLhRmmAnY2kWI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pdiqQbjb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Kr8JgWOT; dmarc=none; spf=pass (imf30.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684829262; a=rsa-sha256; cv=none; b=J5/S2v64L+WxUNSVsN/pRPskjOBligY1PoGYn6IqtEyHmdvPv61fP3cPMUXZqwSGZfpLtG 0A6xdRNi8qrhqNNQRpnBhO4FbMa6pRuOv+OxGFCJz4UbbCwtM/WDcDvy13rqb7ZYpA7t6g nFFt4xQVCxNw8e5OvGZeiTOlMiERW4A= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 073F82041E; Tue, 23 May 2023 08:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1684829261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0wGcfOfd6nV+e+2j2HmOyRi8LKJabDurCag/9oAnpHY=; b=pdiqQbjbdtVFLjV3mMYN3Qeq5kEgiIPjwHzwb2kOnVWmLwNcmjK4cOD0YieNyXCWfaqxP5 /1Wbqs56VvW0hy2hULLaG3zygcEv7lcJ+JTxxLrOK8A+zJ744fbMkYOIymb6A9PungE5EA nM4AAaVppuRFgCLifJ4I/0EahxnKyrY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1684829261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0wGcfOfd6nV+e+2j2HmOyRi8LKJabDurCag/9oAnpHY=; b=Kr8JgWOTkrVNdprb7S17RGPXtiah7P5e/k8F3TmqZRph5c4IYYPrhsIZMd2OWlpTY9LXs2 nlBh4bPk9CTMvODA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC26A13A10; Tue, 23 May 2023 08:07:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9z+gOUx0bGRgMQAAMHmgww (envelope-from ); Tue, 23 May 2023 08:07:40 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 8E579A075D; Tue, 23 May 2023 10:07:40 +0200 (CEST) Date: Tue, 23 May 2023 10:07:40 +0200 From: Jan Kara To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v21 3/6] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic Message-ID: <20230523080740.jpqdcwyzws3drwyr@quack3> References: <20230522205744.2825689-1-dhowells@redhat.com> <20230522205744.2825689-4-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522205744.2825689-4-dhowells@redhat.com> X-Rspam-User: X-Stat-Signature: uawcucmgqoed5y1p9xtsjp1tkindg55g X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4550D80002 X-HE-Tag: 1684829262-667722 X-HE-Meta: U2FsdGVkX18eMD+0mJMjK3wxnUYJDzGYbIL2CW1jn8IIzpOrBs8GBKgaS1EzhwLbJeZoSUGE/yX3V9ggOwj+0UuwwO+ZTu0frr6JI2Em4C2EYV2M6YkbpMvqhYbQDOtW4LJKUgE/nrpHWfzbC6PxLQt9JxrJv9KxNGVYmTsfBANPesuRjFwBYqxUcFBY006Dw3zPXvsdk7kwhZcUzsQIa0JVQeSftym2tIZrL2G7hFgnsfWyuvXQ0KSFaVL1BY1zTyiKBsTZ2h9YQZMMXlQEyrjch9QvFCwMkBpuSk5STB9atXgJo5Su40Eh2K4LXBS7r39SZekkmjIjKXHVwVn5p0DYd62cYV051ha5KPx5qsLHL/V01nWhjDS7bocYuY2f1T7mXA9FV60xSvb59m/CWhi/kutJNNBpALUUJFs/OuWrA4tDhXo8yoNIs1XdiGI4Ifp0HsDLKWRznVYmzl8QutQFHja4c2nftQfk1oQ/JXizvmRMHaZYKmM3RbK/QVx94ghwPgi7Z73pbVY7sUEHU3FHzXP+XjRec9JfcddFIBAhHNo22FIGLTPIS8tLrEFJSrzgapMBPbI/vD2cUU6yxUhDISwleXdOJ/YasQmDdCdq3SvyCGF56fDFKn4+wXCTPz3+AQra1tOhkOCddoi5xdNZ5njldt/gh5CAO76WxNygi+cJwJd7Wmgm1RCQq/xtY/RbjicwHrqrysnpa8xFPyb0hqowgXk0I6GyKR4vEzBkeaA6JhGE3BVNETaeslakZ6/0GCtghyfZzBIERwWALlbHfLwEIVWDqMp3DyO0jbBJU1/f2vLEi3x8LA3df5KgWJr58ves4HjIWv+SJgKyC/Q4JF7d7hYenTbPxj64s258YdQ3JpR1Ehe5VYoLv3YRRTdb+F+FWQZSc+BQGGr3pASh8JEHTFa5ZbFeCPLoYRhebYJCdOJl2GrwhGniJq9X5K3/LFNH0pnYwg5ziid RECf39Ib DNYoiWAGpthd9MpuJDheApMTLlt8J7oJF3joEozlkF/T49+E6VrJCf6ytRitm+RfrJPj4B4vm4QIHgBp3nMHQyRsZwkYOu5gUl5mk6Sf8fRiDBzCjJOvHYXueL/bTFdqTnaDORGC57VT8bAbpvpQH8F7zmzI/4DS074mmDqkhMwJrnH5dKFiO0IDvdeTFeGUWfwh1OHd8Ue3eG0uXgvBWSIHFzEaQmg6sBATs8AIhMavj61QiK3PGec5YNYqc30NJ5sEDV6gwzVIJTeoptSkMfcsBNhpKoCoaiA5BguuR78QlAuVM7h/55ZRiZKH6iAkWFK/lnSc3OIv6WWzdQamhPmAJqBINCCwkUviJ+hX0Ld2oAAOD66GbihyZIAcv7TJJwdFxp472ILQNwjfiM0LEYVqVIMIRZYJ6+PvOsYSuOdRQ+I/S04xcqXPIRgTXUz6yvs/qyEyIee4mvt260tauAf6P/onWF990K3Jj5WEfvj9DEK/rzsMKK9E7Y70XZ3opQY9Dy6kJGngGSrpDr6DUpYV5uBtz8qeAtTrFDHvZOerDKOmNU9RyKKH4rLybpb3ihQ4sPaJ5YpJaQnCyvuArXCGfkQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 22-05-23 21:57:41, David Howells wrote: > From: Christoph Hellwig > > Replace BIO_NO_PAGE_REF with a BIO_PAGE_REFFED flag that has the inverted > meaning is only set when a page reference has been acquired that needs to > be released by bio_release_pages(). > > Signed-off-by: Christoph Hellwig > Signed-off-by: David Howells > Reviewed-by: John Hubbard > cc: Al Viro > cc: Jens Axboe > cc: Jan Kara > cc: Matthew Wilcox > cc: Logan Gunthorpe > cc: linux-block@vger.kernel.org Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > --- > > Notes: > ver #8) > - Split out from another patch [hch]. > - Don't default to BIO_PAGE_REFFED [hch]. > > ver #5) > - Split from patch that uses iov_iter_extract_pages(). > > block/bio.c | 2 +- > block/blk-map.c | 1 + > fs/direct-io.c | 2 ++ > fs/iomap/direct-io.c | 1 - > include/linux/bio.h | 2 +- > include/linux/blk_types.h | 2 +- > 6 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/block/bio.c b/block/bio.c > index 043944fd46eb..8516adeaea26 100644 > --- a/block/bio.c > +++ b/block/bio.c > @@ -1191,7 +1191,6 @@ void bio_iov_bvec_set(struct bio *bio, struct iov_iter *iter) > bio->bi_io_vec = (struct bio_vec *)iter->bvec; > bio->bi_iter.bi_bvec_done = iter->iov_offset; > bio->bi_iter.bi_size = size; > - bio_set_flag(bio, BIO_NO_PAGE_REF); > bio_set_flag(bio, BIO_CLONED); > } > > @@ -1336,6 +1335,7 @@ int bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter) > return 0; > } > > + bio_set_flag(bio, BIO_PAGE_REFFED); > do { > ret = __bio_iov_iter_get_pages(bio, iter); > } while (!ret && iov_iter_count(iter) && !bio_full(bio, 0)); > diff --git a/block/blk-map.c b/block/blk-map.c > index 04c55f1c492e..33d9f6e89ba6 100644 > --- a/block/blk-map.c > +++ b/block/blk-map.c > @@ -282,6 +282,7 @@ static int bio_map_user_iov(struct request *rq, struct iov_iter *iter, > if (blk_queue_pci_p2pdma(rq->q)) > extraction_flags |= ITER_ALLOW_P2PDMA; > > + bio_set_flag(bio, BIO_PAGE_REFFED); > while (iov_iter_count(iter)) { > struct page **pages, *stack_pages[UIO_FASTIOV]; > ssize_t bytes; > diff --git a/fs/direct-io.c b/fs/direct-io.c > index 0b380bb8a81e..ad20f3428bab 100644 > --- a/fs/direct-io.c > +++ b/fs/direct-io.c > @@ -402,6 +402,8 @@ dio_bio_alloc(struct dio *dio, struct dio_submit *sdio, > bio->bi_end_io = dio_bio_end_aio; > else > bio->bi_end_io = dio_bio_end_io; > + /* for now require references for all pages */ > + bio_set_flag(bio, BIO_PAGE_REFFED); > sdio->bio = bio; > sdio->logical_offset_in_bio = sdio->cur_page_fs_offset; > } > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index 66a9f10e3207..08873f0627dd 100644 > --- a/fs/iomap/direct-io.c > +++ b/fs/iomap/direct-io.c > @@ -203,7 +203,6 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, > bio->bi_private = dio; > bio->bi_end_io = iomap_dio_bio_end_io; > > - bio_set_flag(bio, BIO_NO_PAGE_REF); > __bio_add_page(bio, page, len, 0); > iomap_dio_submit_bio(iter, dio, bio, pos); > } > diff --git a/include/linux/bio.h b/include/linux/bio.h > index 7f53be035cf0..0922729acd26 100644 > --- a/include/linux/bio.h > +++ b/include/linux/bio.h > @@ -488,7 +488,7 @@ void zero_fill_bio(struct bio *bio); > > static inline void bio_release_pages(struct bio *bio, bool mark_dirty) > { > - if (!bio_flagged(bio, BIO_NO_PAGE_REF)) > + if (bio_flagged(bio, BIO_PAGE_REFFED)) > __bio_release_pages(bio, mark_dirty); > } > > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h > index 740afe80f297..dfd2c2cb909d 100644 > --- a/include/linux/blk_types.h > +++ b/include/linux/blk_types.h > @@ -323,7 +323,7 @@ struct bio { > * bio flags > */ > enum { > - BIO_NO_PAGE_REF, /* don't put release vec pages */ > + BIO_PAGE_REFFED, /* put pages in bio_release_pages() */ > BIO_CLONED, /* doesn't own data */ > BIO_BOUNCED, /* bio is a bounce bio */ > BIO_QUIET, /* Make BIO Quiet */ > -- Jan Kara SUSE Labs, CR