From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB3EC7EE23 for ; Tue, 23 May 2023 08:07:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2159900002; Tue, 23 May 2023 04:07:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD1EC6B007B; Tue, 23 May 2023 04:07:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99911900002; Tue, 23 May 2023 04:07:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 89D3E6B0078 for ; Tue, 23 May 2023 04:07:06 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 45AD81C72AD for ; Tue, 23 May 2023 08:07:06 +0000 (UTC) X-FDA: 80820789252.12.6B3268B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf14.hostedemail.com (Postfix) with ESMTP id 4294E100012 for ; Tue, 23 May 2023 08:07:03 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=r1KUvnNO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Aev85Fbg; spf=pass (imf14.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684829224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sO7kzFwmptuNxnDGut8ORslGVd/fsxgDQH0NmJ023YI=; b=UBargZVeYiMmB6tzF8nBBDRXJcMbhRz3AaxnfvfXqvTKMGHO3BFZKhOqm/bAxlrra10KIT 7YZocIxyGHHDGYjekB61Vqy0MyM7j+0hH7cH6d2VgPVfSK47EE2R+I2UF7YH0oVaiZoRbz dIOFiE2zEuk7karyRbYB+6fBjREnqAg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684829224; a=rsa-sha256; cv=none; b=GtADUm+94Kfp8KugwWQX2tk5slMppWrD4Tgmn4hnyIWiBzVR5UuOuBCy058et8nezuWtG3 2XAFB2PMW3TwlqCmVuhj6qGdFgcPYeiHZCCVFAwiULglpr1H3yfIEoTQp5yegGD3et3qCf 0DpOog+fGMZ3EC8LhEfIh75QoZLk5u0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=r1KUvnNO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Aev85Fbg; spf=pass (imf14.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B6C852041A; Tue, 23 May 2023 08:07:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1684829222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sO7kzFwmptuNxnDGut8ORslGVd/fsxgDQH0NmJ023YI=; b=r1KUvnNOrg4jCn2j2nvm3IGqQZdkSp91G7kLEGLkmgGJxcV8LFfdWxsw3jH1pqVU0QACXc sg/cbM6M6BTU0IyAfyUvgrVCJvEYSkQ9JsPC5/+DWNStD9q/zy8r5eIfeQCFYeGmvV+g2F uYa+9vaGVp8XTheLDDOw7szQBHtG8yk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1684829222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sO7kzFwmptuNxnDGut8ORslGVd/fsxgDQH0NmJ023YI=; b=Aev85FbgF9zoffR/wHco7E5dzx62A6HSGGXEjWrm9VODge+o7OMOQ5BCtrVNDzXW1XNCcY OdpS27+W46HrysDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9ADE113A10; Tue, 23 May 2023 08:07:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pZfHJSZ0bGQgMQAAMHmgww (envelope-from ); Tue, 23 May 2023 08:07:02 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 16D74A075D; Tue, 23 May 2023 10:07:02 +0200 (CEST) Date: Tue, 23 May 2023 10:07:02 +0200 From: Jan Kara To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , Dave Chinner , Christoph Hellwig Subject: Re: [PATCH v21 1/6] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Message-ID: <20230523080702.vo5n3vanhc5kxcen@quack3> References: <20230522205744.2825689-1-dhowells@redhat.com> <20230522205744.2825689-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522205744.2825689-2-dhowells@redhat.com> X-Stat-Signature: fdezacuk5rq8b3papjn3q1ttqkci1hze X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4294E100012 X-Rspam-User: X-HE-Tag: 1684829223-619931 X-HE-Meta: U2FsdGVkX1+YsY3AcdZrUuC7eN1+kDAhYGD/HpQzFhACGNisFyQWj/Hodeb6fYT+YkPg+jmdtk0Xdkn2YFFkp2yUdeO5X5V1j1yYpkTu7eX9KacJAwkpTf1A0NQonhDh29iROr6V6n9nhi4MmVHuMunLsiWOzFp2ogNOjkoniUUz1Bjll0A08vPYsSzzQx827lw0sGDCIski3qVa58lx9CyzfGb5xv/iQG2DZiVjY9PKHzf2NtNWc4EIuDPjnKcmne3QU+SOlFps0MDHPvRQSQNFrafldBiikZ8DGpjTvsxsAMFWp5Ruzcdiy7f4/rmAIGcMn/81oquBVWQvrtJAFSiBt/04hDBiqyPTiucFa/mtiBmGRSWhJuYyt1U6oh746sBIrrTVsKzWJo61gVImLhEqfF+j6khUU5dARfvVsPrKtfIV3LsAzFzzNGtLjwzBQ8vKTRFx7ISBTnCsqlnIHiA2EXs93c+/SsJSQLj2l46ynRlqs35NvNM25G/KhZKELZfW2fqiDQRu4UnndiYsQu2Kve+NBkldMXNRHnp0H2ca1E9cNQLbedcZEztiK1DN5G7oR1u82UfuUs6gmQ1oaygp/X6PqQEHaioopk29En6eCMTfUqh+H2CmovOSQJDEKxydL297dQeDtTe1FYlTJgHDDPdExdOiDv0Tt7ptjJOmzk+wxbV+P8rEAmQpbFQzzrWozE0CwsffNqEpMtJYEcfZHNOdU8gwzWXuj3gW3dPHnATJ2qkIttirnV43VUbhvsGpgMK4FMIro6V6x88CB/badHfikfy9QAfWMmwbfo0Ny7Qjmr4RqUYcXdNGT8QXHAdlFaZq1+NYTBSLmM/KAUj/yUqpUCcdIYatJpNijn16ZxU7tT3jKf3/eLaf3QPfCai0ZJ6sXow9kcGHXQEFASFupcoeJXR1CaJghXwx3f7/g/+LdW9pzUeqUkkHeQK2Bp8B5SXuUqk6gqIDMAM ImBSevX5 sDL6E90meiuxMvW49Dg7tLBdlQgw3+EVz1cfZydOscyqpEtHVDfwYVkeO4QWBejXKoXpFoKAh3MtXoAtykvDkwBvEBPrBaBRZq5c6VlPYSQhRuS2JRGoWwVT1ckKbkxRI6q1IeGPM5XTsoyAd3QyjJQkT+nlzuNzTBU0cVL6k/mbWld7ZMYowOGrfQPZlUpE1UeZyf0YhZY0RqvSgUvp1sFItY3hoCqpbLm67EFxbx8Qx4wjqY1Wsd5zbK2lGhS2r8DAlgKoPCpoXhYsgRYdeg4yMAzotVA+fOs5FRAGpvVe5PVXTAXG+u3u8vodnDSBQIOxRaYGWEa6efHiyjdj4HeBFtC3J+wHAhjb+lM8Bich7qhTtTggTNtUgx56atUrzYda8c1f7bMkb8doX6NOUzFDY3UDhauEVdd77Cm5zTNgdliIMEDIbVzpTuT3nHjT1uzeKZw0GY5lXRH/3S8PqLqluGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 22-05-23 21:57:39, David Howells wrote: > ZERO_PAGE can't go away, no need to hold an extra reference. > > Signed-off-by: David Howells > Reviewed-by: David Hildenbrand > Reviewed-by: John Hubbard > Reviewed-by: Dave Chinner > Reviewed-by: Christoph Hellwig > cc: Al Viro > cc: linux-fsdevel@vger.kernel.org Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/iomap/direct-io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index 019cc87d0fb3..66a9f10e3207 100644 > --- a/fs/iomap/direct-io.c > +++ b/fs/iomap/direct-io.c > @@ -203,7 +203,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, > bio->bi_private = dio; > bio->bi_end_io = iomap_dio_bio_end_io; > > - get_page(page); > + bio_set_flag(bio, BIO_NO_PAGE_REF); > __bio_add_page(bio, page, len, 0); > iomap_dio_submit_bio(iter, dio, bio, pos); > } > -- Jan Kara SUSE Labs, CR