From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EE2BC77B75 for ; Mon, 22 May 2023 21:44:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BE036B0074; Mon, 22 May 2023 17:44:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9701C6B0075; Mon, 22 May 2023 17:44:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85CAB900002; Mon, 22 May 2023 17:44:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 728A36B0074 for ; Mon, 22 May 2023 17:44:28 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 379EC14035A for ; Mon, 22 May 2023 21:44:28 +0000 (UTC) X-FDA: 80819220216.09.948E076 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf08.hostedemail.com (Postfix) with ESMTP id C539F160017 for ; Mon, 22 May 2023 21:44:24 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Z2wxEYHn; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf08.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684791865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=YRt5149eZiZCbou+EpXhRNt/+dRxcwyqywhZBkriVWo=; b=f88L/NL5G7vl4SIEfWhCSCXA9HHdguR9VB/CQsZYR5QcHN49ZyZQKaqNffi+XqVfdR7O2K 8A5Cj5tAfyEawM6j3wNhrjQZ7ZGV++FppaFjr5JsAXiaoYqKlfAZiMNFwuELCjncCsyBpI T2KJNoHQi7IBPuk6brqgn5gryAW/vhY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Z2wxEYHn; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf08.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684791865; a=rsa-sha256; cv=none; b=6xhAhK68aFsPI4dI6vuCpIJ4yIrinaCUT6LZ52/bppjI/HZe+C+gKMYkFdNZYkwylt4dyh pXxw6VJc/lijxp5dDLwZBMQIxSHrk1bSjiCzYeTAVjyELsB4k0fzZZ2V7v1yr31JSH5H17 usPlRdHvQdzrkO1geczbTDYh2MT+6D0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684791864; x=1716327864; h=date:from:to:cc:subject:message-id:mime-version; bh=cN05v2CZLEnqCYMvXA+sHIrrmEdlBXrBbGAojJW2Fes=; b=Z2wxEYHnJvEh53lB0BU2S7BEQOAre/iEbgM4KAMUmwR2APeoDzGjO6e3 2LCcq0t9QUvD3h0mNeoCjkIp2a8V29cUeVHm4IPaPCkeaH1sSHBOpDQjX In7TR4nNg7gGD1xp7jhworYegiB8yhZJT+9uJMHF7mIl1q7FsXWSW6dCJ nzUuPpFTUg+PLs17dDHJFq+oRqrrYBhW7rbx5Ycusa7foffJhF9n7sWe/ i444BSRSXN+dcGOWBE8drRL2orp8DvRN3uch+KWHJ761cmBO7oYTA41Y2 HEcIKN1zLjfRoXuc6ZIRBGmu91zeMbmSnMnvHnn0+dAOeZq3iLtxg9pPL g==; X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="355400891" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="355400891" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 14:44:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="950264145" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="950264145" Received: from lkp-server01.sh.intel.com (HELO dea6d5a4f140) ([10.239.97.150]) by fmsmga006.fm.intel.com with ESMTP; 22 May 2023 14:44:21 -0700 Received: from kbuild by dea6d5a4f140 with local (Exim 4.96) (envelope-from ) id 1q1DKG-000DDB-1L; Mon, 22 May 2023 21:44:20 +0000 Date: Tue, 23 May 2023 05:44:00 +0800 From: kernel test robot To: Shiwu Zhang Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alex Deucher , Le Ma Subject: [linux-next:master 2819/3918] drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:614 amdgpu_gfx_enable_kcq() warn: inconsistent indenting Message-ID: <202305230552.WOByQyYa-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C539F160017 X-Stat-Signature: ka9ux3655am1gjub7bnya86smxdsaczm X-Rspam-User: X-HE-Tag: 1684791864-36318 X-HE-Meta: U2FsdGVkX19qt4LeIffO+1NEI7uhuSywguQ+vjv+hiz+USwEyKp5RJLPJquHxjRFNtE6wKOAtwwKJEgmCXKvbHnGKuKf9/bT8c8xEe01qSmE3krYqZ6jrkrffUY6by1HhCvlVQzqySe4yIfeMslqDcsZ2E6oXmVsYUjmO+1WJRWkCNEIs1hDPbTY+einB0k77iS4dtymR2e6D/pmVH48s0YjzSPkob1qraB8OUb0M5q5QfCKYu9/Ojrwz+U1IaTWcPpS/gRiTUcooaZd/4CD7F3bjO86KHvuCbTOG6TVQ+NNQFWOnVwGSV1eSQFGp8jT5Im6vQBNtNeJtvv7RrGhIBHkA8e5ruCcFsE/Rv0N8VyOCno30bnfJ5+wlVX5JFWHASI5wFuyHHXGDmK13SRcG4HSXatbXkJsCw2FBP75JWDSGsuoPyJ/jwkl0j3akeDWK8x+XZiSagInuTSDUI0QlgbGCMx5Xx/RQTW9uRu8tzFfwKZMNg8dQ0yvjgLhf4t6IOEFFrFrCeJcEjdOxGkKv04BnjE8Og77RPAqmIoPnoqnjd4ZY0fby3v3IOQWEBiPH4kiw1yK1jxVDj9vBdjelTX6bjyTUG70ppfpKxYYi01gJR0GMahTyNZo+GS+KTsuBlgbohdq7zqX0CstU8/PjTXqUheDfckbzzgY9k/Wsil4ghkjrLZXgjlhhwS0oJbhD+1BxPhNobhk8kp/Ip251IDO5PyVnDBA7rJViFjKkqq9K1sS27EzG3xtCAZchmrGyhHbXbOBMr9TZmQs89TbQGfpR9ej1wRAA5vCeg20r/t99bvAv7ioOP+p2WRC3RHbsL57dsmxXBcq1aqvBczSyKR7F0fwrs4kCy3hIZqfItw9ohkajiGydFzj92Ucgjg5B92+HiVSwq3hovvGM6b6rbmkTbUslHP1KKwlRU+yA7vYDnJwWO/5WU8G7Ty8453UAbyP5PrVYohWesyajxD FxMcKdt/ 9oMCNReCJ/WAHEmpyle4ZP9zosYSTsUhUnXrTWMFSzyjfJeAo3f8no38ayG1/arjjRnMLb/HfC0oJpZn15C0uAjYzrlsNaB3r/sKXi0gHGcigb+BqePnKCI78pawkTg+2EvPLuj88q52GVJJ2Pi1sFlzu06o2i2tfTOJdXtB35SWkXwIYh7FVSvr34iq+VGAxC3evmZy7DqA3YyAHvy4XG3Qcvwt7sNXNCwulr8AQ/nvD/AtAyABR+/yT/LROx/RW4jwD2C43sQwwTL2ZyvEgakovMpGARX73LHr9DnBaAWl18p/SKYEGIEFsz5VztIa+yblZxTdtKW+XHYQzlhPPiTXNPQBm64icRP3Gc8hJVdaRMkNFUa39RXbZTw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 9f258af06b6268be8e960f63c3f66e88bdbbbdb0 commit: 96c998bc80bee7d6dd0cf001e33f4ccbd82723f8 [2819/3918] drm/amdgpu: enable the ring and IB test for slave kcq config: s390-randconfig-m031-20230522 (https://download.01.org/0day-ci/archive/20230523/202305230552.WOByQyYa-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202305230552.WOByQyYa-lkp@intel.com/ New smatch warnings: drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:614 amdgpu_gfx_enable_kcq() warn: inconsistent indenting Old smatch warnings: drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:133 amdgpu_gfx_parse_disable_cu() warn: potential spectre issue 'mask' [w] drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:1223 amdgpu_gfx_set_compute_partition() warn: was && intended here instead of ||? vim +614 drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c 3ab6fe4b28a661 Likun Gao 2019-10-24 570 def799c6596d07 Le Ma 2022-05-24 571 int amdgpu_gfx_enable_kcq(struct amdgpu_device *adev, int xcc_id) 849aca9f9c033a Hawking Zhang 2019-03-05 572 { def799c6596d07 Le Ma 2022-05-24 573 struct amdgpu_kiq *kiq = &adev->gfx.kiq[xcc_id]; def799c6596d07 Le Ma 2022-05-24 574 struct amdgpu_ring *kiq_ring = &kiq->ring; 849aca9f9c033a Hawking Zhang 2019-03-05 575 uint64_t queue_mask = 0; def799c6596d07 Le Ma 2022-05-24 576 int r, i, j; 849aca9f9c033a Hawking Zhang 2019-03-05 577 849aca9f9c033a Hawking Zhang 2019-03-05 578 if (!kiq->pmf || !kiq->pmf->kiq_map_queues || !kiq->pmf->kiq_set_resources) 849aca9f9c033a Hawking Zhang 2019-03-05 579 return -EINVAL; 849aca9f9c033a Hawking Zhang 2019-03-05 580 849aca9f9c033a Hawking Zhang 2019-03-05 581 for (i = 0; i < AMDGPU_MAX_COMPUTE_QUEUES; ++i) { def799c6596d07 Le Ma 2022-05-24 582 if (!test_bit(i, adev->gfx.mec_bitmap[xcc_id].queue_bitmap)) 849aca9f9c033a Hawking Zhang 2019-03-05 583 continue; 849aca9f9c033a Hawking Zhang 2019-03-05 584 849aca9f9c033a Hawking Zhang 2019-03-05 585 /* This situation may be hit in the future if a new HW 849aca9f9c033a Hawking Zhang 2019-03-05 586 * generation exposes more than 64 queues. If so, the 849aca9f9c033a Hawking Zhang 2019-03-05 587 * definition of queue_mask needs updating */ 849aca9f9c033a Hawking Zhang 2019-03-05 588 if (WARN_ON(i > (sizeof(queue_mask)*8))) { 849aca9f9c033a Hawking Zhang 2019-03-05 589 DRM_ERROR("Invalid KCQ enabled: %d\n", i); 849aca9f9c033a Hawking Zhang 2019-03-05 590 break; 849aca9f9c033a Hawking Zhang 2019-03-05 591 } 849aca9f9c033a Hawking Zhang 2019-03-05 592 5c180eb910df3c Yong Zhao 2020-03-04 593 queue_mask |= (1ull << amdgpu_queue_mask_bit_to_set_resource_bit(adev, i)); 849aca9f9c033a Hawking Zhang 2019-03-05 594 } 849aca9f9c033a Hawking Zhang 2019-03-05 595 849aca9f9c033a Hawking Zhang 2019-03-05 596 DRM_INFO("kiq ring mec %d pipe %d q %d\n", kiq_ring->me, kiq_ring->pipe, 849aca9f9c033a Hawking Zhang 2019-03-05 597 kiq_ring->queue); def799c6596d07 Le Ma 2022-05-24 598 spin_lock(&kiq->ring_lock); 849aca9f9c033a Hawking Zhang 2019-03-05 599 r = amdgpu_ring_alloc(kiq_ring, kiq->pmf->map_queues_size * 849aca9f9c033a Hawking Zhang 2019-03-05 600 adev->gfx.num_compute_rings + 849aca9f9c033a Hawking Zhang 2019-03-05 601 kiq->pmf->set_resources_size); 849aca9f9c033a Hawking Zhang 2019-03-05 602 if (r) { 849aca9f9c033a Hawking Zhang 2019-03-05 603 DRM_ERROR("Failed to lock KIQ (%d).\n", r); 506fe17d2c25a5 Dan Carpenter 2023-05-03 604 spin_unlock(&kiq->ring_lock); 849aca9f9c033a Hawking Zhang 2019-03-05 605 return r; 849aca9f9c033a Hawking Zhang 2019-03-05 606 } 849aca9f9c033a Hawking Zhang 2019-03-05 607 712ce872213c1d Jack Xiao 2020-06-16 608 if (adev->enable_mes) 712ce872213c1d Jack Xiao 2020-06-16 609 queue_mask = ~0ULL; 712ce872213c1d Jack Xiao 2020-06-16 610 849aca9f9c033a Hawking Zhang 2019-03-05 611 kiq->pmf->kiq_set_resources(kiq_ring, queue_mask); def799c6596d07 Le Ma 2022-05-24 612 for (i = 0; i < adev->gfx.num_compute_rings; i++) { def799c6596d07 Le Ma 2022-05-24 613 j = i + xcc_id * adev->gfx.num_compute_rings; 66daccde429611 Le Ma 2021-12-01 @614 kiq->pmf->kiq_map_queues(kiq_ring, 96c998bc80bee7 Shiwu Zhang 2022-06-03 615 &adev->gfx.compute_ring[j]); def799c6596d07 Le Ma 2022-05-24 616 } 849aca9f9c033a Hawking Zhang 2019-03-05 617 849aca9f9c033a Hawking Zhang 2019-03-05 618 r = amdgpu_ring_test_helper(kiq_ring); def799c6596d07 Le Ma 2022-05-24 619 spin_unlock(&kiq->ring_lock); 849aca9f9c033a Hawking Zhang 2019-03-05 620 if (r) 849aca9f9c033a Hawking Zhang 2019-03-05 621 DRM_ERROR("KCQ enable failed\n"); 849aca9f9c033a Hawking Zhang 2019-03-05 622 849aca9f9c033a Hawking Zhang 2019-03-05 623 return r; 849aca9f9c033a Hawking Zhang 2019-03-05 624 } 849aca9f9c033a Hawking Zhang 2019-03-05 625 :::::: The code at line 614 was first introduced by commit :::::: 66daccde429611530db82605c197be01adadb389 drm/amdgpu: add master/slave check in init phase :::::: TO: Le Ma :::::: CC: Alex Deucher -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki