From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27DECC77B75 for ; Tue, 23 May 2023 01:12:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6B5A900005; Mon, 22 May 2023 21:12:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF4A8900003; Mon, 22 May 2023 21:12:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 995F1900005; Mon, 22 May 2023 21:12:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 85D8B900003 for ; Mon, 22 May 2023 21:12:30 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 43DD4A05BD for ; Tue, 23 May 2023 01:12:30 +0000 (UTC) X-FDA: 80819744460.01.BEA246B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 89B7F4000D for ; Tue, 23 May 2023 01:12:28 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XA9zKICM; spf=pass (imf04.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684804348; a=rsa-sha256; cv=none; b=M0Jnx+9UXphufp5NZuYMdHZXMhFdLN/QvBZ/fpUp4amQzM+6Ts0LJKBtp9oaIxWeBZh2p6 tE05DfQ5nwH2Mid7mknXKa/AQ4jcJ5IknT7aBxMadlrEJjkzUpwq3QmGKFLxAD4XKN6L0f 8T4kxXj3yw680xvJnqGDkCZ+GrJggVE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XA9zKICM; spf=pass (imf04.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684804348; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S9kEBlrM2mXZCJZviNHwocMuJjhBpx9Jd+tPaUpbpJo=; b=qnim7GXGdPHrrmc+Ck+sW5IF5gS+y3H249WJ/RMs0VXUFNrtDmyY6bTAYleaAJjNBMVCRP /A/ixUG0ewBGbVdeqxj+4ouMbA/mrZ9ih3O1ec6XAF1MuMJC5bMU1oKepV2SPAzq+13YZe StL8m6PMTLmD0ScYdfO3ELgOu/b5ZzY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6254462D5C; Tue, 23 May 2023 01:12:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4572C433EF; Tue, 23 May 2023 01:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684804346; bh=ZAzh2JNRCsiTX6v9YnyrLbWHKhYqrabrMaOhNbQDKt0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XA9zKICML07FeJjfGnwZEsKdRfAesSdvaaHFlpSZu8WKwtPS/f0ia/t7cGRGTyNg8 rT47MwwEolWaHM51ZumONutB3+Qf5F12m8Z1kVmc2gMNJAka7ZrHhQv+ohAfxmjULN /2aDsxU2KzjD+vNRj/AiuZQD9F5M3i7Ev7sTWBz1AKeTf5KddszyQ6/YCnwWe/h4U7 jrL//iKf2/JOVhxfT/Blv1VumtTkmowtNzBwA7CUgcLjxweF6oJXfG2AyYi9pNXgqH jP3o/0cJLs+Dt54A0XsaAGrmEVutP7KfJXFX8dB/TIRPNdcNKc2IgCreYwgPmGaNnn TdjhaErmpweVA== Date: Mon, 22 May 2023 18:12:26 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Matthew Wilcox , Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , Trond Myklebust , Anna Schumaker , Damien Le Moal , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, "open list:F2FS FILE SYSTEM" , cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: cleanup the filemap / direct I/O interaction Message-ID: <20230523011226.GF11642@frogsfrogsfrogs> References: <20230519093521.133226-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230519093521.133226-1-hch@lst.de> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 89B7F4000D X-Stat-Signature: i788zfxyiqwh7hatdn1gibeyjjr5x58y X-Rspam-User: X-HE-Tag: 1684804348-435708 X-HE-Meta: U2FsdGVkX1878AlbftqNUeT7dapVUDcRhOn6uGvyC1LjJErg3SBjoD6RUkyxTD90JE9m/kp9Pnf2hAShqFkqHSUBoFEoUgnXdsfKpMGWYVyL+18Lf3BjUpnGEdzBMPcGexMZfoQrpCY4Uor5QvTefRixDlDWK/PB1Q9KeuqlmjczGYEOFlftROJxv5BHkH+KD/XUtjdra/4q5RRkWDgPzBfwIXRsGyFk3kcQBqFyQgDLrhl8pL/nmFQxaiexdVDXg+sSw5tjVq/yQOOFGUTPWJIutFoK8lvXo+0seIrBg5kVRO/uc0GLfwfWZ9kDV9obkbC0N+H43+A1Ht9vvRh8p65i4BWtQWhm7yqbnIn00vhlxb/DkRwwksmUIs6lbe2tQyurYW2OtoZlpuGATwqmF1kyOjVgeORcZRmZmKrA3W5hVd1B2pULlD5F/2NCgsZxLLTZZGXF866Z66sK+BSLpZx0UL+9aYbJQ22mqvlqQsc24VPkt92Djpra5c7ywVpF0G3uuGSNvwj/w7jD1gNBVVMvwGlGsNVSQtN+LPf9yehonujTiQ8CVlI0t1oMa/Q/0Z4qr46hqrTSZTTfW903+1XfFv8yvOs0VaeleK6qiqrO1MyTWE0zOUuN2xbTqKQ0rjxsuahC4I3luqv116z3PZSXUZi7fCyRVL2dYFFk2mwSPM0kz9QrIMj8zpMcumhK/Qe4McpoPLPLMkAbTbVIfjSnIPdSCFxxaOPE97ENLa7oCpYw8aihCgLVWCMJE62xfSlYRMJwB+jmBGZ9ABOyjI9RdYP6pp4YZhjnCu4Xp4TGW4WWPPVZIjCRhHiNgYSZraqvR82Vr0JJT6tOw9GFs5PeyRloFs6s7k/jjbepu80H6Y7MVIrLSXUzdYiDtXvxOmk3CO73ysnM8hGMcKSV5dIQcjeNoa3APN09IOT9eqkbN2ydjirfUrp15TyGHUVlsLB/w1DC4n1/htTDtpJ Cb+5EIqf pWCVcJhlbOJLeQDlwAEz1KjsA9EKiohM49PCLTycHnggMyW8UNmYUn+62D6nLcBHvq26xM5eK4LEEzEvQK6F7Bv/JaZ/qRAjymPF1pa5/xezZIwX6DDSwAiI1N5UU/zVsb9HYrj9zpwqCuEZPzWd/UGLS6j81WkRi15p1n/amR0+ZUSDY1jreCluwCFz+HVQcKsMJTrcj9m5ZfDQGWTVWHMDUbnfMHnbT/ZLUk4golp8tUgkbzc7q0ozovE665tyTO92CJ86vhFwfGrVs+xPDGIuJWgcXRi5/1zEXA9sdadVY+kM1CzDZMxRAgNVtRSDyFP9DLtbGhJeQM4Ud/VncwOv6Ik2nNQbtDnh0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 19, 2023 at 11:35:08AM +0200, Christoph Hellwig wrote: > Hi all, > > this series cleans up some of the generic write helper calling > conventions and the page cache writeback / invalidation for > direct I/O. This is a spinoff from the no-bufferhead kernel > project, for while we'll want to an use iomap based buffered > write path in the block layer. Heh. For patches 3 and 8, I wonder if you could just get rid of current->backing_dev_info? For patches 2, 4-6, and 10: Acked-by: Darrick J. Wong For patches 1, 7, and 9: Reviewed-by: Darrick J. Wong The fuse patches I have no idea about. :/ --D > diffstat: > block/fops.c | 18 ---- > fs/ceph/file.c | 6 - > fs/direct-io.c | 10 -- > fs/ext4/file.c | 12 --- > fs/f2fs/file.c | 3 > fs/fuse/file.c | 47 ++---------- > fs/gfs2/file.c | 7 - > fs/iomap/buffered-io.c | 12 ++- > fs/iomap/direct-io.c | 88 ++++++++-------------- > fs/libfs.c | 36 +++++++++ > fs/nfs/file.c | 6 - > fs/xfs/xfs_file.c | 7 - > fs/zonefs/file.c | 4 - > include/linux/fs.h | 7 - > include/linux/pagemap.h | 4 + > mm/filemap.c | 184 +++++++++++++++++++++--------------------------- > 16 files changed, 190 insertions(+), 261 deletions(-)