From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 180E2C77B73 for ; Tue, 23 May 2023 00:25:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 871026B0072; Mon, 22 May 2023 20:25:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8215D6B0074; Mon, 22 May 2023 20:25:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E961900002; Mon, 22 May 2023 20:25:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5AF426B0072 for ; Mon, 22 May 2023 20:25:28 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F2CDAA0577 for ; Tue, 23 May 2023 00:25:27 +0000 (UTC) X-FDA: 80819625894.28.511853C Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf27.hostedemail.com (Postfix) with ESMTP id 4027440002 for ; Tue, 23 May 2023 00:25:26 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=mquAyoja; spf=pass (imf27.hostedemail.com: domain of 39QdsZAMKCN4PCCGOOGLE.COMLINUX-MMKVACK.ORG@flex--pcc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=39QdsZAMKCN4PCCGOOGLE.COMLINUX-MMKVACK.ORG@flex--pcc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684801526; a=rsa-sha256; cv=none; b=sfqj/LXzGIMZYVoMZOqFTBOFDMeStKafP2JcXNS/WufiRae0/64Qg2wwHabqYrwb+qQ5Wk s4pyO9/7QIb76+aDw0ECwWd9nR+EwtGbrebQ7Cr59b5PsHBtn2Es7ta2S2ShFD7MmcuG2+ KTOG4ncQVWAI3EeELmzKJL60OhS4Rqc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=mquAyoja; spf=pass (imf27.hostedemail.com: domain of 39QdsZAMKCN4PCCGOOGLE.COMLINUX-MMKVACK.ORG@flex--pcc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=39QdsZAMKCN4PCCGOOGLE.COMLINUX-MMKVACK.ORG@flex--pcc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684801526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=SK35moxCE6AhlCZl4FimQ53XrewZjdQKUPUW9jfTNhI=; b=YXVL4FXhmh2ufgMfuC6Iy8HUGYBmlT7mcX9DLT8+z+a5vEnRB/palE+bTEtECxIsWjXKTP B69WWbBqHb3+8pTBx2NmDqpFmie/0kcJiM70LWZ/MCk8UtF/170wRRHmswOKWVZQX6OgJS IjoSNLFiAmLREleEq8mUXwZ18oLgej0= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-ba83fed50e1so9020032276.1 for ; Mon, 22 May 2023 17:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684801525; x=1687393525; h=cc:to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=SK35moxCE6AhlCZl4FimQ53XrewZjdQKUPUW9jfTNhI=; b=mquAyojadKZpounQOGCyO7aFy35Kd3gvWi/UH5BXhIZkz7tVHOTirDJcDjYG/+Pe0k PwLyo+tt3Lcs8Wt+IbcvNqnR95+2QVcsjtU2z20V1u6zihM0vSHu11VGWJe8iqXhoGRd zXt6V/zFvWazT8SskHdOr3yYcVdhnbScknjPGsxuuM5tCLYnemBLeotCSSZUK/NfGkui Y6O5KmQyVmMpmurc15Kk6+FQa6XGpSluc8K9btxF+G2ADQ8v1cr+z3KhX4nFsNxh2DBR J6j+yljeE33xePrLQmQMDd01yNnZxKWlEaAWc9ta0x6f7M0C7h+CizkiyY2F7w4LZzGN uuWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684801525; x=1687393525; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=SK35moxCE6AhlCZl4FimQ53XrewZjdQKUPUW9jfTNhI=; b=Egk9pXRhr/f+hTf7NFM12WhzEMxd1gWYT7XiJJMFWvcGDmtweJV0O2gThP6Y1rf3iO 767fFf+59tNa1ynoF9FSbY+I9S1eB/LQvFZmWPznjANAVpJXdIOJN6gb2GDhHK3XBDew mcTaKzDurglr5fX+ufssz244S1isYchEwffHCBuTlwmbmLzEV3qijWbmH4+cD0bKrflX vUzXgxCBHRlqu0e/a5XAlI9yC0SKDM9FNlU13UEOWdgWGmrT5Lr/mz3bHsJ9HNzJgzkX YQ5+8Rj+knufbnl8ONlMlSWpuvJnv/rqJprqbcEX+grPTukM/Ok3KfLLOJfB6KlayxXf 0NQg== X-Gm-Message-State: AC+VfDzjuGyRWKF4lhRjirlA5XQlPS1mQC/fdsIhpGOdduTZFni0BjXG dgzIIIUJcT0S8KrR9DCG2wqYhZs= X-Google-Smtp-Source: ACHHUZ5H1E69i+pDVlI8FzT7yTexZ632QETLJQDEPko82BDdVWvZPB6vWKrwPvJAgrPOdHAAIQr4Vxw= X-Received: from pcc-desktop.svl.corp.google.com ([2620:15c:2d3:205:3d33:90fe:6f02:afdd]) (user=pcc job=sendgmr) by 2002:a05:6902:1343:b0:ba8:4d1c:dd04 with SMTP id g3-20020a056902134300b00ba84d1cdd04mr7758275ybu.1.1684801525229; Mon, 22 May 2023 17:25:25 -0700 (PDT) Date: Mon, 22 May 2023 17:25:14 -0700 Message-Id: <20230523002518.1799481-1-pcc@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.40.1.698.g37aff9b760-goog Subject: [PATCH v4 0/3] mm: Fix bug affecting swapping in MTE tagged pages From: Peter Collingbourne To: Catalin Marinas Cc: Peter Collingbourne , "=?UTF-8?q?Qun-wei=20Lin=20=28=E6=9E=97=E7=BE=A4=E5=B4=B4=29?=" , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "surenb@google.com" , "david@redhat.com" , "=?UTF-8?q?Chinwen=20Chang=20=28=E5=BC=B5=E9=8C=A6=E6=96=87=29?=" , "kasan-dev@googlegroups.com" , "=?UTF-8?q?Kuan-Ying=20Lee=20=28=E6=9D=8E=E5=86=A0=E7=A9=8E=29?=" , "=?UTF-8?q?Casper=20Li=20=28=E6=9D=8E=E4=B8=AD=E6=A6=AE=29?=" , "gregkh@linuxfoundation.org" , vincenzo.frascino@arm.com, Alexandru Elisei , will@kernel.org, eugenis@google.com, Steven Price Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4027440002 X-Stat-Signature: b8dss5kyi4zm7kopbgbe17c5c4d6zwj1 X-Rspam-User: X-HE-Tag: 1684801526-512947 X-HE-Meta: U2FsdGVkX1/aDJtdzw+TCPKLmYY+ZcrCYDUufXQFEjLeUL+m0XrRzFgjidBIA85iQBfwWE/aSaE2dMFFejkbJWZ90Xx7CxTLRlAUB79JYswoKo6wmKcGiOjvUVJFOIOV7Rnv3s6YAPAyBN7712aFfm6z8MLB8YboVTfaU/6SfFFgqPDfgJR80XhDLwplU/jFADb2JBkRs69QrJ0BW8hMh8w4sd6bCcPwRU/HLvG2lbFtYO9+Pf6FUykzNDDHwdM8AqjW+HV++zH2NZVtKonxhQ8xV1KlYstCbitx97zzEfPveNM3yZN5UBSWYCBon4mjO38bPffQs16YTfBrPdJ1MehF31Y1D2XVUpZ1zlwVxBY35DvFoI6Lj5Mzgvnn1Go01izxg/wxhUNXI0xLzhwiaWnDHLGeg/AKtC5Ewv+hzCg0cG3+LzoRBbARbUqFgO/TIQZUFj+EefCaBgkRDWCFmPkwJRHQTRbCbtIVRck2G3SdHdXJlxpXyr7G8DBVjxXA/BR7jGv/xVanTO+q6nZwEzQ3qobfrBvU2LiKxeubGgd/RId5lH1f5a2Dl1ayyeIceTBH/4ig7drXAT1MYkkShJp08U/egcDQRGnyD9efIsSP8Lk5gEFHWnFsMw0NvbvNOd2BAcKAOF4eTBZrPDsrDnQ9yklqacbEtw1D4c9zduMPXEV+y+5Z7rEULZbyuOVt8arkGsL9/xKPhjIPlqvLNycZOnwQ8t0DS+nLUmOoQYzOVIjEEsNXF2AAxjxnXuw/t8bt54SJmj0W0CVVcqvOYDeCJwceSOhSZLWCpuI2UTt9LJk1LxADnMZFNAAJKwrrUdDJBskzFA3Zm6CZbj8NhrzuSvPzyP+Z7DIjgNV2sEVPh91jVZkTpByeh4YmM+mxYlm+2pJhGdPn8ipnadF5PxRBDXITlq+D7P40RMSMtxJKIXSMg25ik+wa8/lCsPBqZGeSTBsrFqCbEpsIV1f iHieuSfy fEuSIHkpszapxjJK4vqLFz9y49s3urFLTR8G5q1OB442GzJOXRggJn4h04vaDCyWfbTnZUTiCHOlboenavWxgWPzWg2g1VusWWHHw2IshYgXM1M4yHVVutwEU/2Qe4yE4uJztBZBZ1jGmhZD25JZz1aVehE/p2YvBkDG5NVVRmDSDPhAOiDRs+uCF9P9Kl+NQJ+65qzXeL3Vc2/Qg0H8KRhkqc8sLipabcx9a9EpvZEYAPcAI6ZOmJxle7bGi8jcYhx/G9Uu0qWTopNkDiXo4PlvuFNytbDLpEGYwroYs42w/Asbhns/luLv22tGGLCZRWF2zWaIUHfkXoZlKkpFqAtxp5bJATyclePciEk2PvXazT++B0rlUllA7te2Eh68CXVm+WK700rdzQQT5pcFAhZY3MKlUj83wcE091iS5P3NR4KEM3P4UJKU8Fv5ZurVRNGHfT9C5oBw2dQj/f8qiWNm3iYFpEWXVdYJwoeTGieaHTj3NOviTLCUZoa+I/YkguouiiLSlialjpsDP38Gyt0ROTUPiXno4HLYrJMC2iJ9IvsejyNZLeYMe0LQsY455FTfjygxZlaml7BOPzWWnfbhaQVcxgCMMnm6ww23j2uf5f8COmOuXUWHssvCHk/R4lMSJzs/XMwc0lDlNErox9MKmYhCmVKKWDy46ziYe0dHmBe90Ce7M/aTGS5DrLzoUMtUhfrQnkgFps2YZUFUp2pzk/4wg7g/HjQ/H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch series reworks the logic that handles swapping in page metadata to fix a reported bug [1] where metadata can sometimes not be swapped in correctly after commit c145e0b47c77 ("mm: streamline COW logic in do_swap_page()"). - Patch 1 fixes the bug itself, but still requires architectures to restore metadata in both arch_swap_restore() and set_pte_at(). - Patch 2 makes it so that architectures only need to restore metadata in arch_swap_restore(). - Patch 3 changes arm64 to remove support for restoring metadata in set_pte_at(). [1] https://lore.kernel.org/all/5050805753ac469e8d727c797c2218a9d780d434.camel@mediatek.com/ v4: - Rebased onto v6.4-rc3 - Reverted change to arch/arm64/mm/mteswap.c; this change was not valid because swapcache pages can have arch_swap_restore() called on them multiple times v3: - Added patch to call arch_swap_restore() from unuse_pte() - Rebased onto arm64/for-next/fixes v2: - Call arch_swap_restore() directly instead of via arch_do_swap_page() Peter Collingbourne (3): mm: Call arch_swap_restore() from do_swap_page() mm: Call arch_swap_restore() from unuse_pte() arm64: mte: Simplify swap tag restoration logic arch/arm64/include/asm/mte.h | 4 ++-- arch/arm64/include/asm/pgtable.h | 14 ++---------- arch/arm64/kernel/mte.c | 37 ++++++-------------------------- mm/memory.c | 7 ++++++ mm/swapfile.c | 7 ++++++ 5 files changed, 25 insertions(+), 44 deletions(-) -- 2.40.1.698.g37aff9b760-goog