From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9586C7EE23 for ; Tue, 23 May 2023 12:35:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B6D96B0074; Tue, 23 May 2023 08:35:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3667B6B0075; Tue, 23 May 2023 08:35:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27CA26B0078; Tue, 23 May 2023 08:35:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1845E6B0074 for ; Tue, 23 May 2023 08:35:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 871BC1C72D2 for ; Tue, 23 May 2023 12:35:42 +0000 (UTC) X-FDA: 80821466124.21.0D0219A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id B4F884000A for ; Tue, 23 May 2023 12:35:40 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tsJt2ZMG; spf=pass (imf17.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684845340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S9Zd2magyachyLa76nXi6SNVfb4lbnmMLO9aj50gs8U=; b=5fOhpYgC+kXH2ZEeKsa+ek/Pbmgg7K2cu0K1hXF7jDTyoX91f4Q/MZxyNPOlBKWEPo9JL0 d0oAWFw5Yae+3x18yiOPMYfWqfROSbxYpIzt8o9Y3oJbZEahZK5ytE4kClLX+bk9edMIlC OQW1d8PVYohz4v0N6qFkQFzS6WWwIhg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tsJt2ZMG; spf=pass (imf17.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684845340; a=rsa-sha256; cv=none; b=S8JE0jYbC9wfCBLaZr7F15AjzcRVAglFjlWEYVmuWC7fo79U+R43YbiUzMbe/oAsevcTUF Spld8jbWLXLJpVnt63FGg8NiWZucT2b3Kt/8IYaWK1OdjGddMZ8uf20hgRY2jVEw3oDjGy RBzEsZs5dqv8VO6AIfrrUOV/sI/b0ek= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 965B9631E0; Tue, 23 May 2023 12:35:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B897CC433D2; Tue, 23 May 2023 12:35:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684845339; bh=u5mv3oHXC56HjI2PT+W2P28h07N+KAV9oli2njljAUQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tsJt2ZMGlEFFghj3Uk2r2mtJQ27DlaXhKf/RUJonBOkx0K8nP6Wrpcy+FtTmqI0RS lI87w/XrmQ1hEaK4B3nsUQqXfPz7E+ZDsUM9TtjEW0RGIU2kjLanDYtAxFH+G5x5MZ Rs8fB4bfJSadDYzTM/IkeJ16LcXs2C3SveGeLllZ4E3hDk1Hm+AfwTObpj8VtWNRO+ PeLKCq6+8WSeuHz7XoTvdCsx4FEsvdJHokEVnS3x/K1h1TDcmuVijh2s1a8LJlCowo 8qvUhGAyJ/k6spJX3i+sNA+dlkPSFVPpwb0RFIqIElPXdaHL9+1vQK/xZ8spbDPv/S hj99yo81V7Dvw== Date: Tue, 23 May 2023 14:35:26 +0200 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , Dave Chinner , Christoph Hellwig Subject: Re: [PATCH v21 1/6] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Message-ID: <20230523-taschen-erfinden-3bd7c39beeda@brauner> References: <20230522205744.2825689-1-dhowells@redhat.com> <20230522205744.2825689-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230522205744.2825689-2-dhowells@redhat.com> X-Rspamd-Queue-Id: B4F884000A X-Rspam-User: X-Stat-Signature: jjetiycdw34wdnfqthw8o9bt7qwjua56 X-Rspamd-Server: rspam01 X-HE-Tag: 1684845340-413210 X-HE-Meta: U2FsdGVkX197IwVx3U1Huy68XYzihWOMMfal+ofgFyO3STcE40gdGOfMqvCxWGTISce382xF+dEkonRi4uhAQv/xzoQ28q2K/a5SADaX8emTb/fAqPRi4U2JFqqM3RFzM6tarMsS9gIesiMl317uHUOdSzbwsmwjJp2f7hFIGHqR3x1i7DiCN0RbS66VEEd+Fh4FPil1oFwo8MK6HSBfOVmMmpyc9treDphCEr0XOJZObXwUrlp4ySpMn0xtSCyfrqR2WI+D0dhW/Ra4iNSr4LKzGCKVQaFZS8dGfN/3C1q9FqxVGBbZBcBANeaDR+97d+MTd+uBUQLxprycdGcn16NJutCCHpiLKuZy5voBmE2b4/WvE8pB14y1SBw3UT+h2qUS6So7L9Q1DcxXVYkM8EgXyxT6F4c0wkJaWxfL0ABsoVJB4vJ6EXNG8voE0qiy36Z9eAbPSM2gYFVxxW9ArjQN8j4OkVzfTpTuijFSbdZgZAiaZyVyu70CBkNkjKcDN/ifcf/C88riUtzspp3sK0oU2oYGXWu6agE2fiRCoeqju64sZRmFy2inW25UPrUxjCWI/vKCUkRgw8E3WFfUbkQI7R1zofiaTJQO7jrveVHcM2Y6faq7QK2bTrAn9/fp1vfOvx+8Dq2V/vJ6fYMXpgU+7EkxBYtJMzmALIWgNScHfGBSpQblMwbgYFApsnvbAYBBezhaqM+vfMCrKuotO+d4iktCB2bPnH6zoGaugm8c3Ev2xroGL6xkNfCgmSWyEVO1fcaihdkmTkcs4XX5ao+ik229mf+0h8rB90WpkVyQawV1TPxyOyNTZrZOUbeyu+MkeyOWr6cJMyXnYtFwoV1fEHngrUlWu5+1MKryAyyJ1fJYeWhCuns6sUwuV/uxcBf7AeZIQBoAPCtkpshQQ1qa19VZl6lXfOlWYwt7jfJCEf6alEQ9tIQXSQX/5QIH6SjImOA521iNJwrmovi S2K5aChq NZpUV25D26kTwaIA7OJq4htrO6KG8E/drznVcxwgfjCElK+wm8mJmEteAOJrI3E+/daJZD0uGhfSA96m8cKWZogsgOLx0m9yVYA/UPv6fDL7tUxOa/VOrRuzzz/wpyEalGEMudpMyWYHV4VI2B5b2HO51GXFkHEx3gYjp8n+7EBJcF/C9B21sTD/JHHoC81rWXC+TrKnaUBGSkeQK6O3PYDTWfvNFdl9Cp1OMt3z8T229GfypuNyy9ac9OamLd46PUMMgOGNp2i7H2phw4L5n7LJKGYCe4QZ430l6pqVD/lv6Gw6ecDeMFWQcSGkZup9Yz2OETwz5cVQib2P0ZH6kVaEi8PBq0tb38VuUeGIowkDG8pva5KYIXug1GMZw8JNer320l88jQEtb2P/js32Oi6V01fTgN6dimEsPrUUuv1WBjOjAt7kJ5X40fLY7UiR8yBtsejhXrDm92qvJbP0toKBI/o3k2qBI9u5AOSZElWaJ4lOKc+cpXxR5xEDeB9Kt7PnqLyM7saqYOwHpvlbUEJ8HYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 09:57:39PM +0100, David Howells wrote: > ZERO_PAGE can't go away, no need to hold an extra reference. > > Signed-off-by: David Howells > Reviewed-by: David Hildenbrand > Reviewed-by: John Hubbard > Reviewed-by: Dave Chinner > Reviewed-by: Christoph Hellwig > cc: Al Viro > cc: linux-fsdevel@vger.kernel.org > --- Reviewed-by: Christian Brauner