From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C09C7EE23 for ; Mon, 22 May 2023 14:58:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72388900003; Mon, 22 May 2023 10:58:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D432900002; Mon, 22 May 2023 10:58:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C26B900003; Mon, 22 May 2023 10:58:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4D7FB900002 for ; Mon, 22 May 2023 10:58:44 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 152421C70BD for ; Mon, 22 May 2023 14:58:44 +0000 (UTC) X-FDA: 80818197768.15.3B71BA1 Received: from outbound-smtp02.blacknight.com (outbound-smtp02.blacknight.com [81.17.249.8]) by imf14.hostedemail.com (Postfix) with ESMTP id 237D7100024 for ; Mon, 22 May 2023 14:58:40 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.8 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684767521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vpBFnP70TrOUcnc5MYOOqca4aLyRLJJ9/clTsj0xr6g=; b=pBtTRYQ60IBetf/hNcp6nk048Ln7drvT6TB5o1QNfh+E3x/izkvogL4w+v8ZvQeMEfNWHI K8kQvCfprnb8mlaHFjR8mkj6hg+YNRtlrEcgKzNZB/KveQTpuguYCigrLBBX9BC5jrkCSf VKGDtoTm4i5YlkOM1IqjiaqTOT7o768= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.8 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684767521; a=rsa-sha256; cv=none; b=f9JtTIUElg1oHH3tU+LhFrnVLhnIwKC6QA1k8ai1EhRD7t/JQ3GdgGAKKFJB0OVhO3MBuj jtHbBnH9JCdD1bmQVwbhnQ2Sxg1IQg962DguhFUM9i4MzfQO6otklzPR6tZiqbzmqLXRKl TkcBPNOhhwTA/QQ5x5y0wT/YDIHd+y0= Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp02.blacknight.com (Postfix) with ESMTPS id 4437ABAE53 for ; Mon, 22 May 2023 15:58:39 +0100 (IST) Received: (qmail 21036 invoked from network); 22 May 2023 14:58:39 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[93.89.247.161]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 22 May 2023 14:58:39 -0000 Date: Mon, 22 May 2023 15:58:33 +0100 From: Mel Gorman To: Tetsuo Handa Cc: "Huang, Ying" , Andrew Morton , Vlastimil Babka , linux-mm Subject: Re: [PATCH v2] mm/page_alloc: don't wake kswapd from rmqueue() unless __GFP_KSWAPD_RECLAIM is specified Message-ID: <20230522145833.6nyrtz4u2k6ftbb4@techsingularity.net> References: <6d6fb601-6100-92b9-cea3-e7ebacc7693a@I-love.SAKURA.ne.jp> <20230513102314.md5ugj22xnv6mxob@techsingularity.net> <20230515073840.6yos3cisg2rlyw6i@techsingularity.net> <87wn196oew.fsf@yhuang6-desk2.ccr.corp.intel.com> <65c99fe7-c6b8-aca9-e74a-754d882e64ba@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <65c99fe7-c6b8-aca9-e74a-754d882e64ba@I-love.SAKURA.ne.jp> X-Rspamd-Queue-Id: 237D7100024 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: wcp8k4dpc8e6ysmtom5g4ofgwpx4aoh9 X-HE-Tag: 1684767520-625663 X-HE-Meta: U2FsdGVkX19Z6ojLjvUGkMDucSUszDVU1E3u3vAGbI2lguLsC7uc/JkvyOQlbPhG8JiAlvZHpzc6j8ZiB4+o6VYH8CPrVkBYY20nCawOBplTIr/gOG+soNDXlDmhVFg12CBr1XnWXFLpxHmrUj+lcemdER8M/FzE56uCIUzRQQw5R8EDkUMZ+hUvyVVEo7kW7NoREjeF5rhzCW0DZEqynaEIdn2P3AuFjfMYFRBqoop5O6jvEBTs+9vNR5a2hsxAboVH5SO4CshUTCdTBp7Y6+4KUvNFk27sOnMrC15rPwNrCYhCB7l60ZxJVgRrVlPXIlaXVreQn816YrALcINYlFiaHq/576sJKGrDqkmLJMoLchZCB0mmuYCZy4+3C+v5K7Z72OF4W0a+mjd2CyDBya0HFb6SXO18vpEao4lgZlNJr6xpfkmaX7JYxJukM9kmqy2DC/bK2sy6/x4psoAx842gR7E4y2+5DANedrbgrGS3NrChPQjv81ePqwsRuA0zg1ob03TGOY16/PPOSw4QXz2LuBBVzTy/sTC2cd3rtJ0BTbg3fqRBZrUmK0dxI0y5P7Nh5vZPcseYvmKCBAObBpxzBFqyTopH2nnZjrszeHjdeTAAOE9ckv06OUtOiC9Y9GT81tJBTXPD/Qt4sdHgCwOm+zKavJvEhKjGsqHCWsNfhpdFF197AtIDdWfwQEvo3lMySsZbTmH+qcR2tyuuuPg9kEI+oN0g+B08vWEL9Yq9BFe56jAAwkU6BRDqtjqLvjxr0smOGUji6kt+872UCwO0UwvrrBfpTNn5Z5QhYHlMTtUiJc6Ck9x6uY4EEZo+dShjnql3P4+adTmH+XnBbLyHu8d+C7s7mv5P5+8JSArc5uF4YDlu3LfctL0+Bc18rZEeIkjxXvDl5T0fR7gckU6PgX9HdDj9AuNnTr2gusyi/cQuTkorxkSPa665wM8sbMtkDRg+KOIsI0cIdTj a9rfNEmh IGrEeMu4Q7lbAoUfQDZMsQPQvQaVrQZCJnTrXjm9+BE5XJxYiTJQLZ56lXfIn/VB6yLHDzr++oSho87U3yQWL4fQFDBUkxkPbVDSGZbScSYm/pRrMF2IeLQMzt5TOOS8jq+oFCXvABO9hh/yUopqJC96bGqxKvkjOmgznhixoF9qMaFyBjxQK5riBCs6T8lwA4INmRf0VY9dDmMSRUeauhnsHwyX4VnHPT9bdvQiT3ELdipHh8iHB82chv2ZA9P9efE5nDO6gOcf9YW59ynjSCv+CzSovSCBNfsU6e+2y8wrS7TqKQspXLgrJ6HBDnrpTx0SdsH3UlzK4EVWesWSE0wiBAEVCdzugx6kfmjgJ8cCFFsfWRZ5fSRDGyRbEkIKrbWgKk38ZAfaaEDE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 10:57:03PM +0900, Tetsuo Handa wrote: > On 2023/05/16 10:44, Huang, Ying wrote: > > Tetsuo Handa writes: > > > > > > > The above is based on analysis in > > > > https://lore.kernel.org/all/20190107204627.GA25526@cmpxchg.org/ > > https://lore.kernel.org/linux-mm/d642e597-cf7d-b410-16ce-22dff483fd8e@I-love.SAKURA.ne.jp/ > > > > Tetsuo's patch avoids to take pgdat->kswapd_wait.lock when timer base > > lock is held via adding check for __GFP_KSWAPD_RECLAIM, so breaks the > > circular dependency chain. > > Yes. Mel, any questions on this patch? > No, I do not, the deadlock issue is more clear now. > Thomas Gleixner described this lock as kswapd_wait::lock at > https://lkml.kernel.org/r/168476016890.404.6911447269153588182.tip-bot2@tip-bot2 . > Should I resubmit this patch with s/pgdat->kswapd_wait/pgdat->kswapd_wait.lock/ or > s/pgdat->kswapd_wait/kswapd_wait::lock/ ? > I don't think a revision of what's in Andrew's tree is necessary. It could be improved by outlining the exact deadlock similar based on this thread but it's somewhat overkill as the fix has other obvious justifications on its own. Acked-by: Mel Gorman Thanks. -- Mel Gorman SUSE Labs