From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE210C7EE26 for ; Sun, 21 May 2023 21:33:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F4FE900004; Sun, 21 May 2023 17:33:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A3CF900003; Sun, 21 May 2023 17:33:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 092FC900004; Sun, 21 May 2023 17:33:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EF03B900003 for ; Sun, 21 May 2023 17:33:39 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 84BB7C02A5 for ; Sun, 21 May 2023 21:33:39 +0000 (UTC) X-FDA: 80815564158.08.98E01FD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id C686B4000C for ; Sun, 21 May 2023 21:33:37 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KO5gheQt; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of ebiggers@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ebiggers@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684704817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w41u6rYy58c8T3DEerKtCbhdtBUh4GbCLVj3XyoaOT0=; b=f78zHZPv6E2lDXxScVgheFCwCD5eDTYXUfOXAG0fpVO1NqcjH9J6KyKUUpcBuvUWC64JYf yatPIrn3DdP8Dep4hnbOaF5iwAZTuexNZraX7WDAfpj3ojT6PB0xVyuqlesQ2weyMwt86M OS2TnszHxqa2EA16QhSHNM1htulO1y0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KO5gheQt; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of ebiggers@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ebiggers@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684704817; a=rsa-sha256; cv=none; b=pTKomXEK0JyEgEMwjCQO/YMErIzu3EvL9mC1Ms1XYUkU15rWreXnAFquyA/GZPX52i8v3a DqdM6ZcsTksrY7Z+Dbln+WZRThFysNfYcBLc7O56VjHjiQ7LZM7XlOVJskHWClWq9putKK E4ckFQeDA8lTe+chHRI49o48l2Mw080= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A39BD60F03; Sun, 21 May 2023 21:33:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFC70C433D2; Sun, 21 May 2023 21:33:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684704816; bh=ImWTr7+FEz7G2UQwBZSuCeiA4GdQb8LvzHpdtatDkNE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KO5gheQtibjJybbzamwH89UnyFKfq7zeKADXvoSFgiCqxbSPU6/lkOYsX+fiKkeTi LgQfBghYJA+ploSYPsr6NOcf0MR+cw1jXNJZsr3nNRwX3c7yieSMjWAAMjTWpKFsCL cye65LB4fT0Hb2hF917VKqPVQKeNc70onO3Grmqrr34lYdMNZEQyCrOonOutj2/Udz c2twa3EUXfs2ciG+vcf4YLg+2vVVCtTE1ECWCwAd3RUmmI6d1zk3PGeGsWwcCMnYy3 /aufTNKVNvXXa9OnRvLUrcPbkeHudYZ3pU0aK6Cd7sGro/2Kv1MEk/BHm9VUfz4FJB fx8o2Zgd3TmAw== Date: Sun, 21 May 2023 14:33:34 -0700 From: Eric Biggers To: Kent Overstreet Cc: Lorenzo Stoakes , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Kent Overstreet , Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Message-ID: <20230521213334.GA32557@sol.localdomain> References: <20230510064849.GC1851@quark.localdomain> <20230513015752.GC3033@quark.localdomain> <20230514184325.GB9528@sol.localdomain> <20230515061346.GB15871@sol.localdomain> <20230515071343.GD15871@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: C686B4000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: dxb5wyqpg7eifh1k9xaaiby8tgjufk9b X-HE-Tag: 1684704817-903804 X-HE-Meta: U2FsdGVkX18k4vMiwm590w0S2XenWDdf/gi6xE+QIUoxb8Mi9COVtgw7g8NCot8CImgXg3jj7a/Dzbi0AUutjrzjq2DlLkTp57Pqht5OfrVYL4APOoY711N84BjAERxMt4wXwlweLsZ/QGsqLj1K7X9D61b4C/sPvuByNFE0i2d+9DolHzRhcf1oEDtZSw7M9uy2jL9QYQZX/XVg08rcghrgsRmvoTceIPX4v3Pi5L9/yT/uXfAFEy9raGG6XNIs4S1idJxU7KddoMyjMBDMf/XOIAd9JRdTtwGqIrHUTBUP9FX0mSTI1N962Zzh0o3RPOf1ZbTcCkcox9OA7asL3MwhauyvnoOXVCE7TOJXSqSodIOhAbjCdhaJm7+dqYhOegImXfIms4fiB1jWebKvN1NoEVWNIdTr+g15ezDSLz8+Fv7pHTPh21JMidc5mbdxpVS07grv3w7UHtQuBl57H+06v//7BG/HMQNf2/QstePA5AOH96HleDJsn3C0dJJTHACwL7rB1eR3PxQIvt9+0jeK8Psh9+CA8Ok859uKsVQ35YFaOvw97yfKCNEc+ETfObCtr4cnCcGoFHLpiBPr9xC2OXexIrDNPv5I9iWhgxuYmVe0qrQl58fq6YntiQn9TBTl83bAq72xk2EZu59EqELC1jRwAc6lnrgZ4PtPu8IzezsHErt+ES4LSRxpkycssbyytShaDR3eNW/coYM6AZ5iL047eXIPVcSq0ZHx/mEQaHeB/awXDWEZsffKP5YFpHhS6zhuQ+JaIIyu27dLJW6/QKmfPD+cuZYYJwYaUsPoD2zvvpDlvuts/Q2Uie92IXizmM3or58IO83wfNG8A82F98UDXW6jko+MoyrhorN7vRl8epuWx2ec8RGUsmBw/ZNQjsCOBtoUJQ3BeuedZG0qMbzimdn2ohnmyUBK2ec6pbZnTkmfQh+BgpPj+e6RlZFZFJhojgOmUTaGrcu 04I2TO/E GmMmeIyUZUnqYDOf5lV8JOlafpAy09iv1BmZWjXmxYKd2N4MYIx5OOvdUIzvfk/85cjKKEfdrHyFvTzPR6Q+HbKEpiaylC4TFKUaxE4398oIjUtdkfeH6laTk/U4Ljt5XpbeCFBh66C4CKYo6/Es8TZmGhKFa85VBU2NiL+O8v99g70Ii0sff93rSV/HuQ0es4n33QWVM0mbm+UEpSkA8ukaYeFh9u8HZ4swvffAC9TeMeCJUeHS6XeELDIoa2GYkieG2aQ/2XR8o2R7B0Lk79OxZ0is0wfdEQtGC+yi6eaWQwsd5m7uaZd0fITGvO2mOXGQSQFylYN14iVrOX8L5wJXlOYuTaotUnNnwgldyGheCy23ManLQs+LFHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 03:26:43AM -0400, Kent Overstreet wrote: > On Mon, May 15, 2023 at 12:13:43AM -0700, Eric Biggers wrote: > > Sure, given that this is an optimization problem with a very small scope > > (decoding 6 fields from a bitstream), I was hoping for something easier and > > faster to iterate on than setting up a full kernel + bcachefs test environment > > and reverse engineering 500 lines of shell script. But sure, I can look into > > that when I have a chance. > > If you were actually wanting to help, that repository is the tool I use > for kernel development and testing - it's got documentation. > > It builds a kernel, boots a VM and runs a test in about 15 seconds, no > need for lifting that code out to userspace. > FYI, I had a go with your test framework today, but I ran into too many problems to really bother with it. In case you want to improve it, these are the problems I ran into (so far). The command I was trying to run, after having run './root_image create' as root as the README says to do, was 'build-test-kernel run -I ~/src/ktest/tests/bcachefs/perf.ktest': - Error due to ~/src/ktest/tests/bcachefs/bcachefs-tools not existing. Worked around by cloning the bcachefs-tools repo to this location. (Note, it's not a git submodule, so updating the git submodules didn't help.) - Error due to "Root image not found". Worked around by recursively chown'ing /var/lib/ktest from root to my user. (Note, the README says to run 'root_image create' as root, which results in root ownership.) - Error due to "cannot set up guest memory 'pc.ram': Cannot allocate memory". Worked around by editing tests/bcachefs/perf.ktest to change config-mem from 32G to 16G. (I have 32G memory total on this computer.) - Error due to "failed to open /dev/vfio/10: No such file or directory". Enabling CONFIG_VFIO and CONFIG_VFIO_PCI in my host kernel didn't help. It seems the test is hardcoded to expect PCI passthrough to be set up with a specific device. I'd have expected it to just set up a standard virtual disk.