From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 228AAC7EE23 for ; Sun, 21 May 2023 00:28:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A35E5900004; Sat, 20 May 2023 20:28:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BF3C900003; Sat, 20 May 2023 20:28:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8619B900004; Sat, 20 May 2023 20:28:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 786F3900003 for ; Sat, 20 May 2023 20:28:46 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 39A73C0C1C for ; Sun, 21 May 2023 00:28:46 +0000 (UTC) X-FDA: 80812376652.13.207C179 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf24.hostedemail.com (Postfix) with ESMTP id 860A318000D for ; Sun, 21 May 2023 00:28:44 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=fail ("headers rsa verify failed") header.d=mit.edu header.s=outgoing header.b="oMMqD/ZU"; dmarc=pass (policy=none) header.from=mit.edu; spf=pass (imf24.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684628924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3U2jQyV+om6cEvowDzLHU8bBjtTNByfdH+e84cJttjQ=; b=Cf8z/updEcVCqsRadHlwgx2IxcMRwnRRsXbX2GrYA5tZ2Rj0gItnPBC/V32K8bYpTuP8XU sSORAv+4dfyynPtNVeg3xnCn7eUlF0hEbmHsk7ue5gaLhv9VD5cJRap0OzK8+0lX34E1qv QCaWTOO8OeDcx4G0dvK9zdcH1DF2PE4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=fail ("headers rsa verify failed") header.d=mit.edu header.s=outgoing header.b="oMMqD/ZU"; dmarc=pass (policy=none) header.from=mit.edu; spf=pass (imf24.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684628924; a=rsa-sha256; cv=none; b=hxVTDVuovJZ/gm8XRdYnrkNNImldpfVDosTE0Q1ocMAZYHh/XaaIPCPhibtu30hkZIBBiB bSL9DAVYuXItnSJcDK7P+UwO7tuQuEa4il972pSKHs1/qAx+/FEryEdw7BtEmki0A+sy9q gYwQHGFj6l5Fy/ns5z8KK2y6zWD1/sg= Received: from cwcc.thunk.org (pool-173-48-120-46.bstnma.fios.verizon.net [173.48.120.46]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 34L0SRVZ026415 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 20 May 2023 20:28:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1684628911; bh=3U2jQyV+om6cEvowDzLHU8bBjtTNByfdH+e84cJttjQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=oMMqD/ZUppgCgzKDvbbwVAi5CEoovEfF1QtZ0mMBKR4RhXidI3B7fc+NW3u/9nKyc LsQi19iJKHdVv0GmPowknFWlPn3BB27TwXP13cbb8op9sxdbezrXTtDoP0ZdAbz0BE ZvyOAOVBRXH4mAhrpeCpv7rLzbYliRhgbSAItfajtlSjs4Nq9Dj9fES2JT7BSn8LM+ irK4TekIClw7dLE/9zsnl+F7IjdK6A/BnHZgbgWHlOTPbYuLEtl5RRB/esBBW9F82E 5k16hXvFnB1AWJrjYnz2FM/QeLmDTL4agwbJWTjVLQR3bEQyJRAn00rb7NHMMsZP+w O9VIZ6uLT9EQg== Received: by cwcc.thunk.org (Postfix, from userid 15806) id C696C15C02EE; Sat, 20 May 2023 20:28:27 -0400 (EDT) Date: Sat, 20 May 2023 20:28:27 -0400 From: "Theodore Ts'o" To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v21 08/30] splice: Make splice from a DAX file use copy_splice_read() Message-ID: <20230521002827.GB207046@mit.edu> References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-9-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520000049.2226926-9-dhowells@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 860A318000D X-Stat-Signature: m486jrgdb8y85rr4okrc4nhuqi95xub1 X-HE-Tag: 1684628924-961711 X-HE-Meta: U2FsdGVkX1+485QxY/yG2GIS8pAsZY8uIEEGpKc0fVYX4VxDZdiRvo+Ppl77cXyaWQC0HWkuxggQPggRsnYzHmaSDnUUAzBRzyghYsjYruaIypvgjLdVp1RV4NSonFoGxWOU/8nakROqtWKDJbfrQnMEBvk4G3at2QXZD8gbLA6MMmWWfjNoBXnlvo3ACrN9UjcKemnEaCCPq/EAZc2JBUb0ow3WUC/h+TlJwDO7IZN8TR7Lvn+773oEqo8SZyOYEl2j2qIFeJlwowz/hYxe+IgbMoEEhFe5hJdS+QBWnDttj0qa1Qv0EaUTUyUuhs5FaCEu5xrud3aWCULPFJ/i+tiQge3mfyaAD4Yrgb8VuO75GgZGbqa2q7tO0Mv66U0WyruHrfptoG7mSoOE9PneRc9NyfRk08zteVjf3oOs77Xiuk5gCHxl4xdr2iCnKAwls2VpckGzrJaj6Nk/WpQgqt46865PsYb08D4wbSs5NRdd98Ru1YOXCs0YQt5q5OB9wJqXprvJh7rrsUpTniesshoulPwrJehNHPxZi+o04JYu5kbZCaggf51qYzQMR9S6VYnscEXrKVst2ZqgpVkKUOrYCui5ZgCXVTML04tiQYtUurOnXNLBN8xXlERB9k/XUE36sey/g/G61sKx/FIMC20SCtFE3ay4yG4WU+riDguMwnMhK2mocJo+Nwsy1PIbHzePtY2oY92HT/8ATTrTaizoUo8taBFg7RmFdsZJa1jIp4t9gM5W2XfMX/m7kao8JXcqKpy3jhW4TGpZYpZ7NxX4/RjSkLWVVPWndC0Ng5Q0m3MeDPNVI8QkFNNxVSG3aH0ribrgxhI0V8jpGOtvWwxWsuP+GqjNmWEOglkdrv2vO5XLaF1KHwuKjQTBzaqnPTMBDudBKDrGWk+e5FeHYgfqERIgRTR5SCXEGH2Z1SPBUHNaztNayAKkebxhNxtk+FjH0499UJy2nRJ3J19 Lgg+V2mO 3TGgpbYwiVfAEAhQvvGCR5n6Ne+xt+kJMMr+E+4FgcEWg7QuEytMAGKM09/LXweUy5QolVW+LVjOzhQbaMHnu6JZO7A460nN2DnvoxCY890bHIr9H77ttrnOmX4Bao9hHrMAUQOxSd8w4b0kSXPKbnr72cL6bQ6FMk8zNuG2ToVQyzEpVmt3fHTyN52T/2NggnqzHKciC1uO/cAh+754G02cKKkXwdoAQXX2S0zZ/SMusHFT/yXuhPpA/jbGiyeSDgicrgcwcdY8ZlfO9DUZlyAiHqOzag6oMIl/jthRSvqGuf3KCH0Xci8ctDs7jaXmfFMG4ufin1JIt6A7M3BFkDTyQ/auvNIL6HLSd+svaIXi87s+WjQodeZcEehpZZQnrIFCuD/8pfyzQux52CwgZA/g6IAnlbGaB53FgA/fYXWkB9LfpQHNtipJxLkPI9PYvkpbk2dLvi+Yi9cfbesQCM7oyYA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 20, 2023 at 01:00:27AM +0100, David Howells wrote: > Make a read splice from a DAX file go directly to copy_splice_read() to do > the reading as filemap_splice_read() is unlikely to find any pagecache to > splice. > > I think this affects only erofs, Ext2, Ext4, fuse and XFS. > > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Al Viro > cc: Jens Axboe > cc: linux-erofs@lists.ozlabs.org > cc: linux-ext4@vger.kernel.org Reviewed-by: Theodore Ts'o