From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C3B2C77B7A for ; Sat, 20 May 2023 09:41:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 827EE900004; Sat, 20 May 2023 05:41:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B21F900003; Sat, 20 May 2023 05:41:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 679C7900004; Sat, 20 May 2023 05:41:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 51A19900003 for ; Sat, 20 May 2023 05:41:38 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2AE61A0890 for ; Sat, 20 May 2023 09:41:38 +0000 (UTC) X-FDA: 80810141076.07.2537475 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 81591140019 for ; Sat, 20 May 2023 09:41:36 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RCKu+qWL; spf=pass (imf23.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684575696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3KnyM9AOumUnXi/cdaRPygqsQinbgxlV9Rd39FAtx8I=; b=0rmUbSgFLmCeTMGmQAZpz4T3PXpaRVAo+DM/Vr016uHeX0fhIyLW1OZtdix0y+kE/mQgv0 3gWCP0oH2QWXRO6vJjzPCE7V/Exr2oc93BBKVIjKFCOdzeinQmzQVbl2nFPkc2+hKHBnIt SzGzmVwx/6m184taocRQ0ySju9SM1Z8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684575696; a=rsa-sha256; cv=none; b=D1Pcteas3kxYM6C7zKZ8NjdVMAnRqPqX1pbGwXCUVueLXYIpYXkAOlPvjF04anSoCgbQQa 5owtQR0rC03yPuB1LCGXMa6Xlh7BXsSLSGvnc/It3d39cKxa6cG4Jq2TY1Y2FzDQofyos2 +InRt3vLsAPrfHMMdF/kklSouJrk3AA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RCKu+qWL; spf=pass (imf23.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8412D60B61; Sat, 20 May 2023 09:41:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90607C433EF; Sat, 20 May 2023 09:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684575694; bh=Qi34Xt1y6x93U61QykhNqil2JS5d/WED6AUV/H0U3cU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RCKu+qWLljLQMkOKKE7+IBqPv71gQvySDl07esuV8mxzFnjBimDFbJ+MeTXiImdwi LAo1oAYsycIi6Ngjivs8aWf09Cb9lAvSPT8V2b4vnr52AhA3wOa/eQDFYZZeo1f4LA 1dZwCOGQ7U8tRHWFm0WzUOBEiB2QJO1tfY0b2INLx6s4X3yorcUT+1egxyQYM79jmL VEwcuw7Dj4wzdbpCiR3/dZ5jcuQr/CBLIo4+1Q6Z325lA4XAokTZBbKp7ZzDfVTlP3 rPhjhxF3vQ/ENd4VZF5WlXEzG14C074CDwifY9/pZY9VpqGP7shdUgTnByBELcVTt2 V26DafIYZg3Tg== Date: Sat, 20 May 2023 11:41:27 +0200 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v21 08/30] splice: Make splice from a DAX file use copy_splice_read() Message-ID: <20230520-gepocht-akzeptabel-b117346c55b6@brauner> References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-9-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230520000049.2226926-9-dhowells@redhat.com> X-Stat-Signature: srgtp61dwxnyd5im5fch6xech11q1syb X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 81591140019 X-Rspam-User: X-HE-Tag: 1684575696-111973 X-HE-Meta: U2FsdGVkX1/sfSdSM/NHdeMy5hB7gHX5jM+DsnE3LJrvFcvDCL/0+zkBUTZI2va6YUW4ESGjgZIHwwn7fLTFQ5E0FD9bmE4b8CUaAX+kWfWAfpiItJ/6tmgrIb1JYLxRSwgDX1jF5r7+BKv2F7HsJ/vaPUrGPd4h/ewuXJISfc5y8mQolvJBcCfE0MZ9eyO6nNrUymzrdMOlvkTM0K50dspRoloS2rfoJ08sAD+YGFveWwcwD9x+wZ5d3HH91l3V1S6J0mipAVIw4QIycqzUrq/3HOfEfdhx0HZ2UI/6N1oPvQxbJStlizfpsZnJbP9v/cZLuG1/An9auhTvTWp4ybg95DWNSvOzuTT+155O6bOMmDb9Q3Hh+Xn5o4qM3XxI+LsmFVGe8Nu+f8liMGt3yBS6r9gxj1CBGSOtfO4WmUklIS7/xjOsPJmuZ0Chc0nWIFHWOIbmps3tq/O9HauI5yPGvgbUABo5uotkR/+AjOa1TXCrTCXiNdBlici+V2Ur/sRhmBMl+Z0enUu39lO3d2V0Oyf1Gn3ZFF5eCgaEvPlcvfx8G1Ve8vb53cJn0TlvCdmRSTf3KWcdAPj94J3zXr46uFfHqwCxvRJkjCRNp+T1dB4uqXUibY5onYak/qmqPs7FnI8Vp0//WxnCuSuqGyfqggNp4nEUESw+BIMU+sc+K5sZ4iFq9pGEKQ2rPZONYqKNraqOKOcBMSoATNNvdOaRKnYxt4VOUL49lq+oeZx9QlDUpa/1nm9Uxj2abJVyIKplk7Xo3H3fJz9f+3nlae2lX72ZMXGDw4XX+t1FcHK9VrrNi3LPihoYYUa5VILb911YhAm2T86hf3xRQr7RTaMC4IfSNhrCXNFWDqi9A4ZljoqJcAVwdif6Vutef0AaGMeBQvQGYqlHBCG4YvVUlGtJsYqzCqNqJREfgaO7Yww4WpZOlyak1874CsqYX6Az9StYvgKBjqfzXzGvUTd eQ3z98uc o/OLxCVsOiX58aFhbTCx9gCSMZEQVS16FoRLDiCGTs8bnmSiJHRhVOlE06WwIR3RtKnEkcUAeK2IYi+Czru51Zyz9U1yK8Lw4RZtM1/AhlPoWqi8aZGe3TIIiHaW+77xycbyBxfFtyA653fpUAscvpJxr/7kpidzxnMgFjWCBK+pJfxVJ6EgSfo2seIv4O1GeXVD4WwrDoN+2jeXFfY0USNkFW4e6OpvRubFwLihGuiarInVUgi1U82vxk86N7WqnOQx/VRjPX3DJBmUqf4puhEF4ZCI3So48LXeBTe8qX+Sm0jEIdMTyOoUUm5uU9nSBV7njBvCL1afWsboJpRrS3d9WeQ1jZoMGdHvY/VB0tEZMGp0w2zoLUDXNBM7G/1X6SL3TrC8+A3YxyaNoA5DWFvkO+JbnlA387QPDrhUgtOqjJBr2XSjE/TtasdMfW98pqccy/o5D7qbxLFXX4VKdKaLdZWfeeBrkULPOIwwxvry1Pjujhdk7f1/bo17fwM2xPCEw4TT0XxvUWjNbmiCCkRbgU1XrRTvp+XQVy6QYBPVs95zTNIsHe+bsgnLVLJ6D9PhWpdr28CxKCuTJVOKLfhVrPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 20, 2023 at 01:00:27AM +0100, David Howells wrote: > Make a read splice from a DAX file go directly to copy_splice_read() to do > the reading as filemap_splice_read() is unlikely to find any pagecache to > splice. > > I think this affects only erofs, Ext2, Ext4, fuse and XFS. > > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Al Viro > cc: Jens Axboe > cc: linux-erofs@lists.ozlabs.org > cc: linux-ext4@vger.kernel.org > cc: linux-xfs@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > cc: linux-block@vger.kernel.org > cc: linux-mm@kvack.org > --- Fwiw, O_DIRECT and DAX could've just been folded into one patch imho. Reviewed-by: Christian Brauner