From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7130C77B7A for ; Sat, 20 May 2023 09:34:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D82CE900004; Sat, 20 May 2023 05:34:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3206900003; Sat, 20 May 2023 05:34:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C20A8900004; Sat, 20 May 2023 05:34:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AEC01900003 for ; Sat, 20 May 2023 05:34:42 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 79AFC80BB6 for ; Sat, 20 May 2023 09:34:42 +0000 (UTC) X-FDA: 80810123604.28.E116075 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id CA645120009 for ; Sat, 20 May 2023 09:34:40 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=foeDhXxI; spf=pass (imf29.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684575280; a=rsa-sha256; cv=none; b=UW3J5DcGHXxPRSTq20IQeRFinnCczk0gAISjdpM2aoEfT/uWoqHXTkX7Fm/N0EtiyVZKqc 6k1bpqH28IA8L/pN8C+fzJTPy5NZVORJrGvupu9KPZstBn7WV95rFrsH+zZsLq87W4nGj4 mgKbkxBoIZ2EBq1Ft8E3ogvq9Mo2+mk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=foeDhXxI; spf=pass (imf29.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684575280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gl1P24fcznldntc9vM4UoeVfROMY63nXN9xG77RP260=; b=hHxAmBYr3qTFrJ5woUngrWIejIlTjm3KfaEHdKRMfKeC9f/eM9z4FpoLeutDj4Z2J04pTG VHKjYNLmWe9MKY1gF90+m65hveLXnjIS1IPUs1sOpZog3+wcjWM8X7DQMpygW/xvbNHROk Xcv/mSJ3X3U7dgzB2bvtYcjtgCj5NPc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DCF4E60A2C; Sat, 20 May 2023 09:34:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 151FEC433D2; Sat, 20 May 2023 09:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684575279; bh=nrrEdtmBB6Wb7o+hUn1Dip5xrGG4Byrj3iJNIPMqUEo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=foeDhXxI2PuHz7Q+qNEc/7IWEGb8BDWyk+PS3YX2CJWnBvwk6OXTf0aTprW0aj98l ZuZFHoe3kJWxosV1xt85J1vVEtNWMC4OJVyU0CpJd7LS2xSlgjprs0TJ5RLPNlkbDc EF8M3BomBWTqIxtocWFzE8ZDobcOmoh2J2SIYCz8oMmOd2Eg2KLTI04lVQPFOGcY60 MT/qFNwGdxD20aXv3GXEKSq5qQCq+45ZkDb6bGZ54PQLMjLTPN6N5gpdjpKOj/cJdi +8B3+rfWWiSlo8Igzx9FMHAFpRBIAGG9y/tlvFEn3HwMSMqNI8PrOJEu54GWcRMQbj zEsed/EcHyeMQ== Date: Sat, 20 May 2023 11:34:31 +0200 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v21 04/30] splice: Clean up copy_splice_read() a bit Message-ID: <20230520-geantwortet-pflanzen-5623c1881792@brauner> References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-5-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230520000049.2226926-5-dhowells@redhat.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CA645120009 X-Stat-Signature: 4poopcboduz8ty9eqddymc4dcpjh6sit X-Rspam-User: X-HE-Tag: 1684575280-226773 X-HE-Meta: U2FsdGVkX18V+5ofe6fDxeidvJ8kIanhQ1qPWLtCjWX3LAA83ZUnbUzZR6kPDYP8keZrV5QWkiVwFyKiHveba8VOup1r5hp+bbsV+gDw/LfUt6+CQNh5R/ZvfpoCDuMTtN+TNNuQ2I9mimNHd8IHrm16VNVhjMlzUJ0qhwPm7KgC6+1mq4vF58sDnyr9RBngLK3JaIcUrgXsM2bHBsDcUp0Dx8fgpP0vhp89UUzHGRxKTUIUtEutgreLPASgx8gOn+pVRYS7f8CFShxDwft2Ke2BwSYWxY0emWS+CS7zLI7UpMySg4p6UWW7Cd/gly5qW3XGB/9fFfDuLSza6PwvReHiWp6BLLPJXrqnMGR+xHtiXwoUWRKGpp+gNuB97TiwyUXjcg8W2s4OJ8EVOImGXaYzwfIC1amxWbI2Rz/R9GD2VBvnUOeC7DqPD3E91alhgr1/ssGthIwLAOGuH2QzDKxNiFsnA1NlyrfFtmbq7zijk1SfwC38PlJKJoDdHTtiYxbrCz4SG60m3QVUTT1SIwIWA4WDNgIAmFKA2RON8t2H11GPXc2epzKaLhadx7B5tGka6CACvUqpBovIuU7SmPYVNW3vekqoJdfw/z+ST6ahwOmWMEVwSXreogkb3WMTSi6WcXx0ClGf1mV27z67Vz1mwezAfHWCdT9IGjr3WeWgoDNqmuA/Vtd8AItMU0yF9Z5lnXfTEGL2bsK6flsB9G1nFGX2hKiwZ49sghlykJY725SggGCB5COucBSiwdWT9bBKNNTBAo2IIzFr81LV5w5rEjluay0vQdXauo7LX1nlyPa4ZCX0pwff9+4CMS1nvldH5FWPuWbrzfjJ27bXTEuotdQsFQELqlGZNZ3FSzKa4n9TZTjOQy3ebHkOwN51gqPU4DheAXbPzOX/5vNWzVnpFaMGvdc6sI9rgRtyk8A4GkGHBp5sxIcyMLvHSIiv4w39Sviet/88FjKQjgo /FSCgsuw Fcn4XHz8lilO9om6GA4hi9ex63wtXkLrx/XWSJLKa1TWm2/jT4pq11lw3/y7ArCnnLc5lNm5sdYg36iBkhVsIfXAZr/K/QeBOfz4TzOIbLrHN0oNaWzLssGNSnMcSeQ5Z/OpCdlS7qjoEZadAW+h2mwwPVlojHWt6Gautnr4LgD1LkdM3glW7hPrAO8P2dV4OlhHfKMaF4sVO1Nga/ExZeEnzxRTIjjhXPVdh4gkEew+zH2MPbXREoZVWQtPc/QsVDoQyNA6rwTZBJ0fPqc8MT8DmwNRPgQZ3GI/8afSjQNvS7FLt99iVj/0/YlZj6ijcj9cfzNlyRMu1Pao12LMaLST/3V/XYSapjO0sV78xjVI7/BLhifhlWkeECgz1+g8dFqeFpCcqfFjWlWehesTWVavI0HdLxjeKupHbYQtwZt/Rs58noxl7FAQheC9OP23EiFIDEzNeYHceINZW34iPcTx6qhC3TBnqX89MSmH2l2FovHdyI3sGyN8OIOW9cIaCr2IYDQM2G3MBuo2C64h4dXW1m0TqFThVsolWSnLBqqtNgC4bT+3i6aSj+RxAbt1niw+jZqBoCFtr4EQKdZl81lmhiAUeUR8g6BCbVrT06tVXGes= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 20, 2023 at 01:00:23AM +0100, David Howells wrote: > Do a couple of cleanups to copy_splice_read(): > > (1) Cast to struct page **, not void *. > > (2) Simplify the calculation of the number of pages to keep/reclaim in > copy_splice_read(). > > Suggested-by: Christoph Hellwig > Signed-off-by: David Howells > Reviewed-by: Christoph Hellwig > cc: Jens Axboe > cc: Al Viro > cc: David Hildenbrand > cc: John Hubbard > cc: linux-mm@kvack.org > cc: linux-block@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > --- Reviewed-by: Christian Brauner