From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09006C77B7F for ; Sat, 20 May 2023 09:39:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E395900004; Sat, 20 May 2023 05:39:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3931B900003; Sat, 20 May 2023 05:39:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2830C900004; Sat, 20 May 2023 05:39:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1BC0C900003 for ; Sat, 20 May 2023 05:39:37 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E51D5C0AD6 for ; Sat, 20 May 2023 09:39:36 +0000 (UTC) X-FDA: 80810135952.12.8AB1028 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 41FC812000D for ; Sat, 20 May 2023 09:39:35 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=C5yabXkE; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684575575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ufv8ZDbnqCL6C1QNtE0DARESlHUjZDcH8OZ6wUZMBII=; b=uU/1RAaHshG/AiDCt5YuPE0p87PlfIM29bfdqTWJY4llMZXzvNGAiDQ9KNdDdR5P4yc/6s 01RmUfpZvAduhjmO09PLqCx9mgVjBV6M+ABAT5a80yEa12zt4owsjLuUO6sjmu55OLeGTy Hq2zT2DlGCOyKonr9qSw04I23dRV5mk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=C5yabXkE; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684575575; a=rsa-sha256; cv=none; b=iHNL7jFYcSvbr31hUboLSnuXyBUHSMr/nL72Qz/tDSNViLGDLSr4MfeSU1AvGR84Qz8OSH xS9zhe5ZGKPql/hqBexvREZRLGe4BkiH3h9AnoDt0UeJv2nKTejtl7vqqgBQkTpt4NDZYG WWaOdu+yvROe3p3NLENOnQfnoI32UNA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7794860A50; Sat, 20 May 2023 09:39:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E075C433D2; Sat, 20 May 2023 09:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684575573; bh=u+XokJXJqqWsxP3R/qKZwNbpDIsXwkbgPE+7cCEi5+E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C5yabXkEj7EhC8yxQ6eikd9gU/GWKBSoj3yVXwPE1+J05/0n9c4I6o9AbLMfSm7gR StV/f5oSbkM3NwtWKHs0m5OIPj66YN1Cb2n2oT/k6ZOweNyp2Dqil3WY7TJeQ9fCxR RqY0YpXNOz8AmGF26SQZvTmoWT3YgxaJ9UkETKjQH33BpCHmagWzpbPMCbY76M8RNd I4oXSpz+kG8vAdoBC8oARR1nMu3c4q2zVFj4iMV+9VEZfvbJPfbDTIwG61Oc71Rg/v pzdPTE4ikoxokxMYS81mUEsCJ5BCGOy83EpomcJ7jtZGQhNc8jlP4sJ+fV+kjYXoXE 7jCzJRFUNurBQ== Date: Sat, 20 May 2023 11:39:27 +0200 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH v21 07/30] splice: Make splice from an O_DIRECT fd use copy_splice_read() Message-ID: <20230520-ethisch-wahlabend-1b7d9cf4dd13@brauner> References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-8-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230520000049.2226926-8-dhowells@redhat.com> X-Rspamd-Queue-Id: 41FC812000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: yfsrt6t3pjostegi9mk19d374964ngtf X-HE-Tag: 1684575575-205390 X-HE-Meta: U2FsdGVkX19Nzg6QrJmuBSPFOv3hG0eQZ4e/EJo02THYoSf8X45pU3A61xNRYFKDikElbrNMjITS82Ej9ngqfEUE6rwdHWGstVv7UAJIBinvC5cOnZtj1reNsGJKbFP7SJaOKOovHMgoweQf/eC9s+uM6J+cZma2rBjTy1KX3Hb7bRp43D8JPtVXToWDmM4iYWDtJ/Ok6nh6zupugSfpPTRzPGwRL059drXWw/dqDuTwH+m6A5l3rVCv68NqF4cO+WLYU0rVqxwEB/NR0VGEzfG1N1jez+nSMuMzjvmn2ttHSRsbn1Zclc7WfTQYfIG3tPVKDPkNuXS8KcqEND9WWKQ9NP8QE2z4fu7Bp37dW1GMI8R8nO5nRElIj3PVSdzHqmVuPQfWid0lIid7ugPuJWoDnvyrGiAydRAo1lVlkY7RGtEk3QjbT94J9IAgj4O/yI4Ig6Zo4KLBhGAAEO3nyQ5BlnmQOx55oEmA7Dg9fS9HAOZNHQS8E1VGE/o4sM3lV7C3vKaOylZB5YsDZqA4ID0XgoxDogtidFpkV7FYweMrWItweZ+sMq7+F7BZtvIX6V+8VGL7A12C840f0+2F50uHpcNODpkilPGfY+rWr9YmlnNRFNUTrLugYNPYUlnnQTek6IEbHpH+WEE9qn9fpoAn9pTYeLaaU7cECfMqkKIDbtQHUlG96I3ABQ2lTBkLX7AdAZl/SiCIVYhhzk5BSmNPeS1E20PJpwgEW3pGW9TT0rKjvxVWzgIuSkOcAvN11MtsIm6N8YoqNiuJIwGysUmj2ADLJsKKLym5fWR4bbGT7yUTHN+o8G5ykDWPpqk2hqJwaGgDwkBdHeg1Gj0a8X/k5/UD9DNDzDfDZ2P8/KgW/j5v5N7LgN9WSLuJGX2QnNb8VdHeh2+sMI0xKWXoD3eCC3eTMC038AfVGEEPcPFNL/CkGZkEt/N6hAU8DugTk2X64Qhh0Gq6WZqMpho kuDZ+PDj ++cmmx+kDZbeS1A6ebfZBme2qbHhmnNBDUy1fsPbxNFIOOygmfccLe92SwvL20lOuO5QYzFjjq7uEaSRFSf01RwwyhWr//uz/1gvwz7i7LpOmpf5eV1mPnpqTlxKq0PvV4wVsZWrguL/GbUtRXtdR/2iOJ1hNHKwSr0ZLdfLwkq7YrIBBNUsBFA4KL/4pL2OxxhrU09CFooKg7qfegD3RVRS5nnpFJsXriDYDp5wP14aVox86g9SoMwz0ORIJ89o7KGCoSpCSSf/m1b7jewUZ9pO4cZv7UvY7uM3l4wN7sgl0GxyWrMDMg8M3HelNZh/KrZ9460U8QVBs/RFeJ4Q+Zq4JHakpVzX3sGQOMRPN2CCcGrpOD7k7EPUhWXSyDkFMLiKhAZM3RLQ6f0vBCPTDXUDvP1Tjwr5MTU1LgVG7jPHHZpTk7aCLmqTtOQUzRTpS7wt4kOzIYQNj5f93dO2DOYICplpipwF4YEE26fKSrKuxlHzFdaRoLmhJgUsYt5MFgvyosaqDCaUKXC01Joz9LJL2YF6O2nuHcsc/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 20, 2023 at 01:00:26AM +0100, David Howells wrote: > Make a read splice from a file descriptor that's open O_DIRECT use > copy_splice_read() to do the reading as filemap_splice_read() is unlikely > to find any pagecache to splice. > > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Al Viro > cc: Jens Axboe > cc: linux-fsdevel@vger.kernel.org > cc: linux-block@vger.kernel.org > cc: linux-mm@kvack.org > --- Reviewed-by: Christian Brauner