From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3178C7EE26 for ; Sat, 20 May 2023 09:14:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28EF1900005; Sat, 20 May 2023 05:14:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21654900003; Sat, 20 May 2023 05:14:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B79C900005; Sat, 20 May 2023 05:14:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F0F8D900003 for ; Sat, 20 May 2023 05:14:31 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B008FAE751 for ; Sat, 20 May 2023 09:14:31 +0000 (UTC) X-FDA: 80810072742.19.DA9B0BA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 1DDC71C000A for ; Sat, 20 May 2023 09:14:28 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=c+WzSc1r; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684574069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=29+i/Bm8gwi/c+h4WMD3D/EMa3VIlxtnbQKHP1zGo8Y=; b=oy3ZX2UnPHBE1qBAgQcoA0RlKAwadD5tOTDksJELYBpvZ7Ap3Jaii8jKdcgbrRB3TO8vnW amucCLhJ+u89Ry7eonPCN4XLCrOrti3Xvkv1aC/Z5WrLnnJF2ZV73F31Yvg4l5N7ZwxpIf 8R+7N6XxgHNruE5D0U6jv38n++92fbg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=c+WzSc1r; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684574069; a=rsa-sha256; cv=none; b=LsS5uOhjl81zTPjh6TxpGYV8GpuVsjoIktQAP20L5LSNsLqe6qzF1pI/8K+DhQQatsd1mW GCP2ZHF4aDaRYKVOsLb4EzS2yiA7vrM7h/a0ve4u5/HRzDF9E7rC8Z2iEiTnsv2A2Dr+5P kP4SUb+GDiTazYv07TK+/NdOR38jPt0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0E89B60F78; Sat, 20 May 2023 09:14:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36FBEC433D2; Sat, 20 May 2023 09:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684574067; bh=VWYo/zrId8bi/ArfUMirZunxj8EOCtROc5ibvxwzPP4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c+WzSc1rAfsiZoi3Jdu+ms5yzCVF8c/Dnn3bCNFBGqv/DDAGUoVUT4Tul3e1BBjP8 SUY0x8OUvJz7+XMbCrrmAj+E5k4Fj52NA7EJP4pRJ47UDgZVWjpa29Ei9HRzj8knkn sLZT8isHaK8damZrH/Tgi7woimOkrwSJ7FCoYi2OXEdp+oYtvA2tqKP+pm6gqA0z5J Bz05Fd3c3ZcYSMnNIcD9m8dATvSE6jKH0wVmck3SPeoy5AxxTNUatmfHLs7ioJ3Mpn BLRrmR7u+ES70P5q8S/M6utY03FYWRaFIH1LA5HD4JbKo7LZl/tWnTNxJ0W1vAs50j MHWGh85L3AB5Q== Date: Sat, 20 May 2023 11:14:14 +0200 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Steve French , John Hubbard Subject: Re: [PATCH v21 01/30] splice: Fix filemap of a blockdev Message-ID: <20230520-bioladen-mitgift-7936402c233a@brauner> References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230520000049.2226926-2-dhowells@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1DDC71C000A X-Stat-Signature: bbtftegaijh7c7pxwimno87g8efhmnhj X-HE-Tag: 1684574068-822904 X-HE-Meta: U2FsdGVkX1+YOORhYY9vS346OV4u2PYy4YturNFlmS/ectWrJPmIxDNDlZaoxR/FkgrbKf68OqFuxx6a5/SlJzTq6oFJLkyil0BGzjITmUXrUzOdShNTeqzEufCUcbd12tOVkCxWcRA1mYA4L7gkycvg7bqSw4Pn6HxY168JU55V8jQA2VK5BozEIX/jtjBSHQYbcgO7c3adgkABk11eGI26T08MYNoM4zQUMbqnPUtUayYC+bzqRCbdArr0/0FC2FYWH7LLFY4GntzoKvwwGv5lL7gsZdk84YVEKGt5uW5ah6rOlI2d1DejBFFHlPyfjroym5HHsSPZptdaUT809GllqqYf7IEpvQERXwS9TpgVXZVz3zyXMPDhrPO96HGy1JERlvRqd69IHUto3Xt5ztMpOTaR95xwxkeedH+zQ42Axl5ONUu+cFcjYP9HYUPhX2qaqWmAe6wrw4lbnL1uJjMKTBHLmztzDiJKwMRQaIBYTDskgZnKdwCL5rx9qbzQ04v1QfIPtc2gDgBbIlIYlgBaUANhrFzdNE/HE6ZZVwztFZ7v66MxyA2STLWBdLkGraKt18UHtC74M5/YzHSLAKYhFl7XGqAsug1OlU6ZmQiyvDJfJ5e246g8uUM/4LAIbwC68cwTYZ7Hq03VE1bpztMeEc+MXABL5lXfWMTti1GqQtoaMWR2HVycqzIJ+xLNPe5jeUvxtTSv/2vUixoogdiYUToFzG9esSGdsHTKYMXonMuBy+gLHI5lrTFyBtzKW2kcwawW2UCEUf1czHYCswICL3oN/pN+tXaUSmRltSRIzYeXPrRAVk5uHeKumlX/TjCyweCBw/nM8Ru0fOtFYw5+JFmFWzWwwHfri3W+jYIO/aIxHzloKdKdFZKKwdcqsKBS8FqelDBbNll6QoEXf2bozDXlTgi+lQLYl0FGhKfqFwmU83v0HeIaltOrFcrcJcyv24XUBqsIugFEGWO PlgPoCK7 HG/UcIHF1K5BNSz04CFTbsxT7q7NMVJaNJbIFzfPc1Zc0l+vTIC9uYbaPqSxOrCr6fdgucI4eUniGumhisbMcrd2hqL/xQT+DEJLfuJKrSpmznT1ZnrLVwmiH80SmdG7Zcti18Hz8dATQMPo40ogOYwyMoNp4Aa37u2iHKcaVV1OuReXHeoFcOfL9mI6T7jIpTWfF4T8km9Fh5DXz0wslW5jo5yjaMCEouKuXAI5hG6J+hNaNPxt+pwdnLZW1dZ2iUa4/eqX1TICqHOat3V5vfAcr15nXtvMZWlZ6/V645InODaZloLF2eNhdNTrgrm1YbT+WhHpZ0/Sd8hPFWWDmOb1SHH4H2dm9GZREsviB6BsCMBJI4+w2hQy7zt2XQUH6hy6PbVqWKTM4fzsGLOYPCjoii2NbF+C5fxt4nYDJXBaKSuUPy1Dgm+q60uSFvr0lzALfHjyuT6aAvL3m4G05uhrIlq/0nC1px7n53REd/KDxznmzuvFIN9nKOMn3I0vvqwEpa+61DsfA+3o46pV13mOfgQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 20, 2023 at 01:00:20AM +0100, David Howells wrote: > Fix filemap_splice_read() to use file->f_mapping->host, not file->f_inode, > as the source of the file size because in the case of a block device, > file->f_inode points to the block-special file (which is typically 0 > length) and not the backing store. > > Fixes: 07073eb01c5f ("splice: Add a func to do a splice from a buffered file without ITER_PIPE") > Signed-off-by: David Howells > Reviewed-by: Christoph Hellwig > cc: Steve French > cc: Jens Axboe > cc: Al Viro > cc: David Hildenbrand > cc: John Hubbard > cc: linux-mm@kvack.org > cc: linux-block@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > --- Reviewed-by: Christian Brauner