From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B6B9C77B7A for ; Sat, 20 May 2023 09:21:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBFF7900006; Sat, 20 May 2023 05:21:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6FBD900003; Sat, 20 May 2023 05:21:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5E7F900006; Sat, 20 May 2023 05:21:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C84C9900003 for ; Sat, 20 May 2023 05:21:19 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9018940BD3 for ; Sat, 20 May 2023 09:21:19 +0000 (UTC) X-FDA: 80810089878.18.3968C03 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id E80B71C000D for ; Sat, 20 May 2023 09:21:17 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eYWLBFhT; spf=pass (imf18.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684574478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IhSX6TXpF35/GvnFLloDn/3SXtUDhj0qJzBie2Mlaww=; b=oVC+VWqmJJyGJjl1j/OhD4YAomVd1ygQJlN5zr7FIoOtZzeQ9CNXneITOdRLIMyGJpcMqI pT4cJOJkfUiCU4/k3PegsifRK9u+GvcOLGfiH99M0wDwfIRxKUgbw8Vzu2IJGv2OJSwniT X1V6Gr+sgZ+W2W4U/yoX69DFblEov2o= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eYWLBFhT; spf=pass (imf18.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684574478; a=rsa-sha256; cv=none; b=0gPprxoZuve1g2vP2964dYUsPFXKcD9zdrONewUQ4DDaeO8mux3kuNMtKto4iwBQj8NryI CwFKDqmc4wkN0pCPhCxwFsBxbQskR2o1rekX7ojRi5sGV8Z25KhR9e/Dn15ukS1BSyeQjg 3fce7zMhyO1rBG6+cLLBO2VwLHQD0yg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E082F601DB; Sat, 20 May 2023 09:21:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 005DDC433EF; Sat, 20 May 2023 09:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684574476; bh=1sk3KywmldKzQSQt90JNPQOI5X1ZWPtE36C3dU9orHM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eYWLBFhTwx1fR7Cz/5zG9pwLY+6U2pv9KX0owdf1450WutM3cJyiNdY4rcV1Aawm2 p72IcCpaimXVM4z+BiA0BX8BUYnw9tENkwNqpcid6Zpq3trS1XZavJi2ifTXO04UA2 XpphECjMHAyUP3W1Z2d6eJZ7evjMRFXuvBLcmsvxy96Q30fXTwvMLzYyqix16yi0zI jhVuGGD5CnY5nU0uBgfUYqmOUnJda4b5xIIl5FvnuB67fZxVL/UirSpknicVuJKsOS dW4ifc4rYuoJayLJuvSKpFr74JYHfUW95tBipXt3wXPh/Vtd3L+WO+YKZ1Ls0cgIFp tVmYwsuyzQwvg== Date: Sat, 20 May 2023 11:21:08 +0200 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Steve French , John Hubbard Subject: Re: [PATCH v21 02/30] splice: Make filemap_splice_read() check s_maxbytes Message-ID: <20230520-abzweigen-jurymitglied-600e651d784b@brauner> References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-3-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230520000049.2226926-3-dhowells@redhat.com> X-Rspamd-Queue-Id: E80B71C000D X-Rspam-User: X-Stat-Signature: s1ni1riyiftc14hrqh5samwb3tn38tgb X-Rspamd-Server: rspam01 X-HE-Tag: 1684574477-758512 X-HE-Meta: U2FsdGVkX180F3qJzdOqs0dIHmI9429jqTiqfxFckARUcCoQyHQRVZTJNtAGns43DxIFtHXynKXWevl43Bvw0+B3Bs+Z4+CAgPTuuFj39Bt+okPBOy9KnwZpZgHFEHJGhnVJZwiIZjs+5W11qhQ54RCTPOWak3LUJU2ISXXaSqqppT4KqduFRrZ+vQ11VR0x/BJvvHDfePaNeHsVyTSgLyAo/wgB2h6fDn5XxdgZwaKCb5Ikh3ApX1r8U/pwdstsqn+9e6haLhul5c7PWfaWSZyl1hSw1KhmyMIA0vc6s7QmNhbVO0M4cQIGyOwUaCHzQFWCnIZ+X269woyCDAl3Q9I3LSXmzgWN6VzEVLqP0Ofltv3BN5weksQgBuDc5NafbzGCo0oQHBHn1E9g3tMzs5cSTDul+oQu3ucbu7HXO8q7rOBwKc7vwprYb4dNaFfL1viThI4CYy6CFZeprQz6ggdEUS372YtQ1Q9lssPFTu3yYZfDXP4Tao1qRoc1KIOh/4+EqODEOxYgdqDmPsKCvKfL0y4dXQKWtYsLhntc0vxT7Zp8In5tKi5F9TI129o1Tje24ynT/R+Qll2G7t+hBDTuVC659A6JESwIBcM73QXEaVWVtdw5NSQbPHSvsLcA2W0jw5voy711ekw8YOPRXhPMCur7kQ6d76fmUpRUCZqFdMmhzSeXBjlJpmoY/JOAxxbPXrNfvpF7szb+WAGxjvs7BIPAYiDyH1cwG4tvuR/z3pBnPwPt1bHJYXP8RfDgjuMW7/I2JjVolc07+uEMRq12lfFtpMDEsK6fZonC+TuoTUfrE0m6q9U00uNthHpXDHy0+HR+O0au0J0vs40Xi4Gpu4C+H4I7YPZC1OGsbOOPuxall7mvAC0K4OLQWzwgYE6U0CD5NoMqNNGLzRg0JENkhKko0DOZorm7gii6xEd8u4hRvOdVG/qN672FfSk2QhEBy79b/r4ljia71lQ +sU4roI2 mDz3Ao8XXuFNiBG9Irj+KoM9LrNpfhpUWWkR5tRt3weRcobtD4hso5ETSBEaxZxkgizJEj1TJFx6xACNshhARRoazP84tLuZJkalpHXbUYINrcbxfMU9sdwy/E0YX27IoYFSOdNttEHrcZxXfHRbahDlmOkZEMdRmDLoedxwhNPrVdK0Nk+4kVus559uThaEYfd5j+AkbSp9qCSaApUwr9jORuK8Vk2fiDw27NLRl6tbIUNLwn7TXdhW28gyBGqqnAVQufLEr/VjS1g9XoFfsmllT9QhoVAgT7UDdRY6smQEyA7H52gsG4GVn4U6gnmm9NCiHcl72bNolqg3YF+oGFVSNBTULJUH8GuwyAJ5UZ4GfPOQzzjgS1dCXh6ok9jvIsOEeZ3sC4iK99Qj+jfjSIkVblnuYAjvL3g9JqsV4n30oqSjIjCTZiSnqLPkX//zUkvRi5MS802qdHzEi9w3UuTZYaHA9oYnUAI6bFUyyoxJhxQK0gFppR1/e+n+vznhXne22Kh6jGcSQoKu+UxPo5whbgOy+5JCFHiZTxs8QVEBfLVJ4q+uBoll+z/nhE/cw9Y5ustF4kf4eUcU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 20, 2023 at 01:00:21AM +0100, David Howells wrote: > Make filemap_splice_read() check s_maxbytes analogously to filemap_read(). > > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Steve French > cc: Jens Axboe > cc: Al Viro > cc: David Hildenbrand > cc: John Hubbard > cc: linux-mm@kvack.org > cc: linux-block@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > --- > mm/filemap.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/filemap.c b/mm/filemap.c > index a2006936a6ae..0fcb0b80c2e2 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -2887,6 +2887,9 @@ ssize_t filemap_splice_read(struct file *in, loff_t *ppos, > bool writably_mapped; > int i, error = 0; > > + if (unlikely(*ppos >= in->f_mapping->host->i_sb->s_maxbytes)) Pointer deref galore Reviewed-by: Christian Brauner