From: "Joel Fernandes (Google)" <joel@joelfernandes.org>
To: linux-kernel@vger.kernel.org
Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
Shuah Khan <shuah@kernel.org>, Vlastimil Babka <vbabka@suse.cz>,
Michal Hocko <mhocko@suse.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Lorenzo Stoakes <lstoakes@gmail.com>,
Kirill A Shutemov <kirill@shutemov.name>,
"Liam R. Howlett" <liam.howlett@oracle.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Suren Baghdasaryan <surenb@google.com>
Subject: [PATCH v2 2/4] selftests: mm: Fix failure case when new remap region was not found
Date: Fri, 19 May 2023 19:09:32 +0000 [thread overview]
Message-ID: <20230519190934.339332-3-joel@joelfernandes.org> (raw)
In-Reply-To: <20230519190934.339332-1-joel@joelfernandes.org>
When a valid remap region could not be found, the source mapping is not
cleaned up. Fix the goto statement such that the clean up happens.
Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
tools/testing/selftests/mm/mremap_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c
index 5c3773de9f0f..6822d657f589 100644
--- a/tools/testing/selftests/mm/mremap_test.c
+++ b/tools/testing/selftests/mm/mremap_test.c
@@ -316,7 +316,7 @@ static long long remap_region(struct config c, unsigned int threshold_mb,
if (addr + c.dest_alignment < addr) {
ksft_print_msg("Couldn't find a valid region to remap to\n");
ret = -1;
- goto out;
+ goto clean_up_src;
}
addr += c.dest_alignment;
}
--
2.40.1.698.g37aff9b760-goog
next prev parent reply other threads:[~2023-05-19 19:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 19:09 [PATCH v2 0/4] Optimize mremap during mutual alignment within PMD Joel Fernandes (Google)
2023-05-19 19:09 ` [PATCH v2 1/4] mm/mremap: Optimize the start addresses in move_page_tables() Joel Fernandes (Google)
2023-05-19 19:21 ` Linus Torvalds
2023-05-19 22:52 ` Joel Fernandes
2023-05-20 2:34 ` Linus Torvalds
2023-05-20 3:17 ` Joel Fernandes
2023-05-20 3:56 ` Joel Fernandes
2023-05-20 4:01 ` Linus Torvalds
2023-05-20 4:14 ` Joel Fernandes
2023-05-20 4:22 ` Joel Fernandes
2023-05-20 5:04 ` Joel Fernandes
2023-05-19 19:09 ` Joel Fernandes (Google) [this message]
2023-05-19 19:09 ` [PATCH v2 3/4] selftests: mm: Add a test for mutually aligned moves > PMD size Joel Fernandes (Google)
2023-05-19 19:09 ` [PATCH v2 4/4] selftests: mm: Add a test for remapping to area immediately after existing mapping Joel Fernandes (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519190934.339332-3-joel@joelfernandes.org \
--to=joel@joelfernandes.org \
--cc=kirill@shutemov.name \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=mhocko@suse.com \
--cc=paulmck@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox