linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/page_owner: set page_owner_* storage-class-specifier to static
@ 2023-05-18 13:47 Tom Rix
  0 siblings, 0 replies; only message in thread
From: Tom Rix @ 2023-05-18 13:47 UTC (permalink / raw)
  To: akpm; +Cc: linux-mm, linux-kernel, Tom Rix

smatch reports
mm/page_owner.c:739:30: warning: symbol
  'page_owner_stack_operations' was not declared. Should it be static?
mm/page_owner.c:748:5: warning: symbol
  'page_owner_threshold_get' was not declared. Should it be static?
mm/page_owner.c:754:5: warning: symbol
  'page_owner_threshold_set' was not declared. Should it be static?

This variable and functions are only used in their defining file,
so it should be static

Signed-off-by: Tom Rix <trix@redhat.com>
---
 mm/page_owner.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/page_owner.c b/mm/page_owner.c
index 28c519fc9372..f37c0b722b51 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -736,7 +736,7 @@ static int page_owner_stack_open(struct inode *inode, struct file *file)
 				sizeof(unsigned long));
 }
 
-const struct file_operations page_owner_stack_operations = {
+static const struct file_operations page_owner_stack_operations = {
 	.open           = page_owner_stack_open,
 	.read           = seq_read,
 	.llseek         = seq_lseek,
@@ -745,13 +745,13 @@ const struct file_operations page_owner_stack_operations = {
 
 unsigned long page_owner_stack_threshold;
 
-int page_owner_threshold_get(void *data, u64 *val)
+static int page_owner_threshold_get(void *data, u64 *val)
 {
 	*val = page_owner_stack_threshold;
 	return 0;
 }
 
-int page_owner_threshold_set(void *data, u64 val)
+static int page_owner_threshold_set(void *data, u64 val)
 {
 	page_owner_stack_threshold = val;
 	return 0;
-- 
2.27.0



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-05-18 13:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-18 13:47 [PATCH] mm/page_owner: set page_owner_* storage-class-specifier to static Tom Rix

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox