From: Tom Rix <trix@redhat.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Tom Rix <trix@redhat.com>
Subject: [PATCH] mm/page_owner: set page_owner_* storage-class-specifier to static
Date: Thu, 18 May 2023 09:47:18 -0400 [thread overview]
Message-ID: <20230518134718.926663-1-trix@redhat.com> (raw)
smatch reports
mm/page_owner.c:739:30: warning: symbol
'page_owner_stack_operations' was not declared. Should it be static?
mm/page_owner.c:748:5: warning: symbol
'page_owner_threshold_get' was not declared. Should it be static?
mm/page_owner.c:754:5: warning: symbol
'page_owner_threshold_set' was not declared. Should it be static?
This variable and functions are only used in their defining file,
so it should be static
Signed-off-by: Tom Rix <trix@redhat.com>
---
mm/page_owner.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/page_owner.c b/mm/page_owner.c
index 28c519fc9372..f37c0b722b51 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -736,7 +736,7 @@ static int page_owner_stack_open(struct inode *inode, struct file *file)
sizeof(unsigned long));
}
-const struct file_operations page_owner_stack_operations = {
+static const struct file_operations page_owner_stack_operations = {
.open = page_owner_stack_open,
.read = seq_read,
.llseek = seq_lseek,
@@ -745,13 +745,13 @@ const struct file_operations page_owner_stack_operations = {
unsigned long page_owner_stack_threshold;
-int page_owner_threshold_get(void *data, u64 *val)
+static int page_owner_threshold_get(void *data, u64 *val)
{
*val = page_owner_stack_threshold;
return 0;
}
-int page_owner_threshold_set(void *data, u64 val)
+static int page_owner_threshold_set(void *data, u64 val)
{
page_owner_stack_threshold = val;
return 0;
--
2.27.0
reply other threads:[~2023-05-18 13:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230518134718.926663-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox