From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA8DC77B73 for ; Thu, 18 May 2023 20:32:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C555C900006; Thu, 18 May 2023 16:32:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDE5B900003; Thu, 18 May 2023 16:32:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A587F900006; Thu, 18 May 2023 16:32:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 92EC2900003 for ; Thu, 18 May 2023 16:32:53 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 66203808E6 for ; Thu, 18 May 2023 20:32:53 +0000 (UTC) X-FDA: 80804524626.02.8DFC138 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id A18804000C for ; Thu, 18 May 2023 20:32:50 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=DHB1WPZK; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684441970; a=rsa-sha256; cv=none; b=Yi23q/+0uBkO0fPdNKdgm1GnMjaNiZ8+mBCbWkLQtkHZoclxJBLA3Z3yytYsIlypOqMSuB PUQxS2H3QRJpSx/MhwmX8u6iBvI8UjSJPnmnHQCHJjEdEsKDsqWK8e1TtiQLKx4g1JgG9V sQzrxnTrCsNnhxPcpXTMKe8nSrUD+xY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=DHB1WPZK; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684441970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A7gqKzSXxk0Q7WEn5s4owzB/OGxvNhl7Y5r1JWI4N3k=; b=OzC0kRIUJjOuLCRe82G0EVpfa/jR3H/JB3BJcIvyoOW1NIlf4gqhD9ubrHryuZyhKrflS5 omABUUkFymTC6bWLDl2X+hkW5Ww5w9tKfmY5xjQG7E3j4rjO0nOlkVs4NZv9wRuGvNqj/O JTCyLZJDM38s5XlllBIqzGBfqvKd1EQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 878A064F7D; Thu, 18 May 2023 20:32:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C89F4C433EF; Thu, 18 May 2023 20:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1684441969; bh=CrB/bMDggeeuRdZlMfMOz49UiznCyfb3hMwMaKppKro=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DHB1WPZKWeMAcedwOTX9Wr5BxegeuSRQX4Xqfayg2lHYegoFMr8xZe8EDvYnlfei0 8Wi2V+960f6nZAgud2iJUTxmOlAbvfrlWr6DOm5O4J9phYs6Mm8wNSnr5NbJB8c+Uw ZPm8oY1w7Sz1UnYCVS4oypVQa9gENAJuIhjjfEOI= Date: Thu, 18 May 2023 13:32:47 -0700 From: Andrew Morton To: kernel test robot Cc: Oscar Salvador , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [linux-next:master 2908/3314] lib/stackdepot.c:544 stack_print() warn: unsigned 'stack->size' is never less than zero. Message-Id: <20230518133247.a0ece8de7c3fc5dca9e1b67d@linux-foundation.org> In-Reply-To: <202305182345.LTMlWG84-lkp@intel.com> References: <202305182345.LTMlWG84-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A18804000C X-Stat-Signature: p6qwujs66yqruj8qu4ggx9bq3t4uxazo X-HE-Tag: 1684441970-864958 X-HE-Meta: U2FsdGVkX19bTe25wsgvQvITh7nqceysSAh43tlGJ2UBtTMZWatci/5z3PqQq5WEYPrGfw5H0fyGGSoAo2kSKy4mZ0KJmQ3FZmtr8Eh2t2t8Ycdt97e7VuU2jSqKq37tQBlLrMvYOd9k5QOs3jDsIwOsuY1O6jlULvn+H7nX/1Umt3VRCEGZA92NlvurgJpxxyhQQoqvH49fvaKHHQLEPI03u74ABE+NS5dyg5Pggchr2437y21UmCtb+ivcMVieUMCjBkHfrdo3Y5h5s1ZTR8rVoT1YTosShLkWn4QmF8WofhVH0EjSqIWpk49YnNBqoybdHAkH8Qq0SaO5z+w+1xh5wMCk1Ka+hHUoIDLPWEp1BQ4py3mfeo6QtHwbYLnUsqmnP4EdkKeUJfq72QnsMluAzt1juQw32Q6fzbcFUfJeweLBMl8Rbk4nwAhQ9oxaKaHu4RI0I+o4atZsieNXEsZN39DAgXEu/e0ebGwWFTrliWAV2FAqUgqppiqfrbjuQM/1kvrGXwJ5MwQN8D9GU6rzHqm3A1OTN/ttUqnwcB7xgo9el/gpXlKokTEYB9Z2zY/g0VwsU1s1UPWnIFYH9LTHBEBtgSzKIQiLaGkU94gkj1oFuGOgcoe3jRl9GzHXXeEdZjVeajEPK26u8c2XzlArYLw7JRtnt2MaUAfHWdASQMHmtJVeU5OKReGRKFFcPLuWXkNjLMrTLTrjNszUFHTdzz/4fye5RrfufWOR29tTyK/O7DzstrIK3+jqcw8Ex0Eta3oQLb+J2h9L99FTsek6Tcj8G0gt+P5b2kUajTH8/yfdftawx56NkIYBp2aYbmzWZMQzKrnZfhxWHGulk+BUs4Q1AE+2DQkHCy6HJuF5hx/45qmGTZSndxc+f6obb6CLApYUdiAkePHMNAQAkZyFD0G7POXkx37Ko4PU6ZfZHFBXNUeJfWqUafszrgAogAd2T5NY8vGLH4Wa5T+ kKG2lGh+ G3l+0dXB5VwWFVtaZJJQ8gt4+AsvWpi/iUy2QVQdx7cNuTlJF6hXUvT22EHGqZG2mDTfOnQxQLTZzCUdx1Bv7Y+ISs1RkqygsoPoY2ZZimqeDNq5qi/lHYAT2200n9WCs0BEKpncIc+TL4Z+UCSzi8y0pf57x7y7/nuqdOw3K0omP86vi5Fmm6i0lnkOWCU7wJcwB7I/uK8oaok/9wq33qU67W8aJIFXJwgyMvhplt9Wu6/1N67aKiK4HRih0UbNvI9FnvazJ7XOgJ81R0pg9P8/EqFcX/GElSUiuahA9CllXYXWh/5ok806AfRkKGJPrUE7GhnVeF9CMrJtdrZid3Ot9epLFJeGkG94f6EP0mZaIT0mdq842R4iAYowUAvZ5M8IGT4cN5sVuAp1u3CEWI8O/AypM2murURm8cGcQYdfon4ZXserIEXRoVrUyH3hOuzNqoAe8Ejpxl7s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 18 May 2023 23:44:10 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 798d276b39e984345d52b933a900a71fa0815928 > commit: e435b85a4aea7a82259105d5d8025655460052e1 [2908/3314] mm, page_owner: add page_owner_stacks file to print out only stacks and their counte > config: x86_64-randconfig-m001 > compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202305182345.LTMlWG84-lkp@intel.com/ > > smatch warnings: > lib/stackdepot.c:544 stack_print() warn: unsigned 'stack->size' is never less than zero. > Linus would complain about that warning. > > 537 > 538 int stack_print(struct seq_file *m, void *v) > 539 { > 540 char *buf; > 541 int ret = 0; > 542 struct stack_record *stack = v; > 543 > > 544 if (!stack->size || stack->size < 0 || > 545 stack->size > PAGE_SIZE || stack->handle.valid != 1 || > 546 refcount_read(&stack->count) < 1) How about <=? --- a/lib/stackdepot.c~mm-page_owner-add-page_owner_stacks-file-to-print-out-only-stacks-and-their-counte-fix-fix +++ a/lib/stackdepot.c @@ -541,9 +541,8 @@ int stack_print(struct seq_file *m, void int ret = 0; struct stack_record *stack = v; - if (!stack->size || stack->size < 0 || - stack->size > PAGE_SIZE || stack->handle.valid != 1 || - refcount_read(&stack->count) < 1) + if (stack->size <= 0 || stack->size > PAGE_SIZE || + stack->handle.valid != 1 || refcount_read(&stack->count) < 1) return 0; buf = kzalloc(PAGE_SIZE, GFP_KERNEL); _