From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 315AEC77B75 for ; Thu, 18 May 2023 02:10:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DA39900004; Wed, 17 May 2023 22:10:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78A18900003; Wed, 17 May 2023 22:10:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 651C9900004; Wed, 17 May 2023 22:10:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 53666900003 for ; Wed, 17 May 2023 22:10:45 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 14E17A0443 for ; Thu, 18 May 2023 02:10:45 +0000 (UTC) X-FDA: 80801747250.19.97AD377 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 583D718000E for ; Thu, 18 May 2023 02:10:41 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="vut9oY3/"; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684375841; a=rsa-sha256; cv=none; b=vbXP42I2dzXYLLPQYcUcUlEGx2ttdmUCRuq30y0YmC7mGAmr5Eg1pUKSXYPAps9mrKPAoB 3M53IXjx+mmUmbAiRxT8VeDpq0S0i2XsW2v7WKn/Hjtou+UUT8eKAD7MkP+1Elupw/7n5i cEgdOYZJLU1yJ5Y0OHkrwbzcSKa66ao= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="vut9oY3/"; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684375841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MAdFxYo+MfEQ869T0Bnx3dang5OzEod7RJ6S2X2H2dc=; b=WQi+Qcvt2wDSWnIFx8G0bv5Xbgg+4Xdavjuyc1qboA0BIB9i4L0b+dy1HqmX7W1ZgOypYa YngSFGwjOF46n0rlIbOrJK/vIm5SxzKM//nN0+QngeIsgKJ9tc4S9zlmvlv31+yUTp3cr0 gCsirf4XtBNZlBAsQ5lG2Uqmc/DRZpc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 24EDC64C0E; Thu, 18 May 2023 02:10:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 088CAC433D2; Thu, 18 May 2023 02:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1684375839; bh=dlKZujqMvvKJ+zXADboUqt8HKe3rP64mtoCT6SjbC6Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vut9oY3/uEDSHXakBDvrTsw1QJpb/bAK0R47BA3B3UoybpYIhwHSSvlve/fzGH40u 1u1MlR9QnS7o9yE/azuIZ/EKmTzTO4Wmp+BcXbrgoWLzzewGs/Z/fJSjPUtK1aB6ib 5gM9e/bQYEHqIGdRh0pLqfV3FXA+V2HpLcWdJiZQ= Date: Wed, 17 May 2023 19:10:38 -0700 From: Andrew Morton To: Kefeng Wang Cc: Mike Rapoport , , David Hildenbrand , Oscar Salvador , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Luis Chamberlain , Kees Cook , Iurii Zaikin , , , , Subject: Re: [PATCH v2 08/13] mm: page_alloc: split out DEBUG_PAGEALLOC Message-Id: <20230517191038.437a3750caa877cde58c054f@linux-foundation.org> In-Reply-To: References: <20230516063821.121844-1-wangkefeng.wang@huawei.com> <20230516063821.121844-9-wangkefeng.wang@huawei.com> <20230516152212.95f4a6ebba475cb994a4429f@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: tn5c5a8ydtw31t6zthh37j3uoqehz947 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 583D718000E X-HE-Tag: 1684375841-857643 X-HE-Meta: U2FsdGVkX19faouIJ88mB6yOgsX6UuOEouxxkJ+6mAKGBa6GPrkfZZ6KccXermVIhSSyaocamkDwOd/phoiFleUF69jiO7GQ8p2Lrc8Npr9hIPlUiseTlNmekBR0dQBE5DU1hfXAya0YDiSZPZ2PL9Z6JyIjImjh0qSma6hceToKiFxYdhkVm1vHNv8etMXp9M1lPdtPUEXlyB9mnWEPz/BWdGVZ7OgihB9sTmyLBj4/sQlcNlsjYKg+9P/aNgWuwc5xaNpzrLI4z24YBBIF/iRwlibJQ1V444tdEM8LM2o9/zj8DKRJp0nRh3dhRbjuxVTC/DevENFPInJF2Vdrpkp6sLvVPkvRT8YaWocmoaQnXGmefwAJp9XYDBE0uDFtGDnDfiE7CuqRy9OUIa42rId/RC1nZLNaNrbq8QVOi2fQh6aYyQlqTs3DWMlkA4HLfjRiD4SLac35mcfd4cvOGriOhwlQqOMGVpBlyJTxpMV+QgbbD3oRKTxlkprrruMPhNeDiltBWm0CN3LJMvCyV41YeRv3CqSqrOKdnH2hXWcb07NXcXObK2HuM68TgcOAZzptzaGKyUU2NzDB1xK6/bZ24XOwPRpn9TFDhg6glD5+1q7diRHOCVq/FpO3QcLKqyiFY/xcsZDNwTvWP5RYWZZ6GPkiqbIIp//gUK4UrTUC3v/bbP0DvuO7a4O8o7XxN/CljkfEOKePs2YQ7X33pwF0DpDs+T02eWSY1OW7opA5mOIv7/PSMPhk+I+8cWCZHPLAYXJ9WDZuvADAE8gCQAIyn088yoQM/CJI+gFAvsNyk7Kzf+vOVPtwO7ds1AtYTOP9bOhq3T296SjfSQFKoPeqM7GxNew5HRoPPttWzOPLnlIqy4vocNP1Baj+2OkOGbP+pBL/ek99/rYbMxBYiwyDKZaHQRRvOEjqLgrspN34PWJe12fgPHaqDMtNpdp4DO7EPp/FkRHs0ReceiF xG3AgLpJ uhSbYeDq9eLwtaRwUuXurxbNcuBtHwTpF6tyYrWJhRhzbDKcZlZMsc1QMJaSk07Dd80312zZKJruB5sXsT2F6ia75v7+jKD46EIsRf3YpC980sAYNw7uwKvfcYX49sGcsajNxH2tDvBsVzvgUV1V+w3fcBFTBR+01gM/dbiB6aRbOAlQQyCb6idCarzn6ZVXKeUXV+7OEpmEzN7sCjiBUhNatT73QtqoRtUtX7FQfPtWuqAux4EJUE6p6anY2+tvoptBne5Xv6ZBQBoa6AXoyzprFY7UkGgTJKWR6mkqVDUg7IglbmUWN9RbpNS21N4YW2DBkr4WSUpWvsjEVjmj8DjWSnUFujbcm9rmOSf/gPKKJXrRuZsla/71EMzejF7sJWjPux9hldTjOxU9mYCqigYFAfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 18 May 2023 09:35:29 +0800 Kefeng Wang wrote: > > We're irritatingly inconsistent about whether there's an underscore. > > > > akpm:/usr/src/25> grep page_alloc mm/*c|wc -l > > 49 > > akpm:/usr/src/25> grep pagealloc mm/*c|wc -l > > 28 > > All the 28 pagealloc naming is from DEBUG_PAGEALLOC feature, they chould > be changed to page_alloc except the cmdline, but it will lead to long > function name and don't gain too much advantage, so keep unchange? Sure, it's probably not the worst thing in there. I was just having a moan.